public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: srinuvasan.a@siemens.com, isar-users@googlegroups.com
Cc: cedric.hombourger@siemens.com, ubely@ilbers.de,
	Adithya.Balakumar@toshiba-tsip.com
Subject: Re: [PATCH v2 1/3] mmdebstrap: add "skip=cleanup/reproducible" option to mmdebstrap
Date: Fri, 7 Mar 2025 22:59:58 +0100	[thread overview]
Message-ID: <47d50bdd-2f10-4373-9009-554365643775@siemens.com> (raw)
In-Reply-To: <20250307122558.1882902-1-srinuvasan.a@siemens.com>

On 07.03.25 13:25, srinuvasan.a@siemens.com wrote:
> From: srinuvasan <srinuvasan.a@siemens.com>
> 
> Without this option, mmdebstrap deletes the var/log/dpkg.log and its siblings by default,
> but this is needed to download deb-src packages for base-apt creation.
> Basically, we are referring to the package's status under /var/log/dpkg.log file
> and performing the debsrc_download operation.
> 
> Without these changes, bootstrap related deb-src files are not downloaded
> under the /downloads/deb-src folder, due to this the repo sanity check
> functions failed during base-apt caching stage.
> 
> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> index 931f6f13..7380a658 100644
> --- a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> +++ b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> @@ -168,6 +168,11 @@ do_bootstrap() {
>          arch_param="$arch_param,${COMPAT_DISTRO_ARCH}"
>      fi
>  
> +    cleanup=
> +    if [ "${@bb.utils.contains('BASE_REPO_FEATURES', 'cache-deb-src', 'yes', 'no', d)}" = "yes" ]; then
> +        cleanup="--skip=cleanup/reproducible"
> +    fi
> +
>      # Cleanup mounts if fails
>      trap 'exit 1' INT HUP QUIT TERM ALRM USR1
>      trap '[ -r "${WORKDIR}/mmtmpdir" ] && tmpdir=$(cat "${WORKDIR}/mmtmpdir") \
> @@ -183,6 +188,7 @@ do_bootstrap() {
>  
>      sudo TMPDIR="${BOOTSTRAP_TMPDIR}" mmdebstrap $bootstrap_args \
>                     $arch_param \
> +                   $cleanup \
>                     --mode=unshare \
>                     ${MMHOOKS} \
>                     --setup-hook='mkdir -p "$1/var/cache/apt/archives/"' \

What has changed in this version? I'm not seeing my concerns addressed,
my questions answered.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/47d50bdd-2f10-4373-9009-554365643775%40siemens.com.

  parent reply	other threads:[~2025-03-07 22:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 14:25 [PATCH " srinuvasan.a via isar-users
2025-03-05 14:25 ` [PATCH 2/3] image: download deb-src packages after imager creation srinuvasan.a via isar-users
2025-03-06  6:05   ` Uladzimir Bely
2025-03-06  6:10     ` 'Arjunan, Srinu' via isar-users
2025-03-07 12:25     ` [PATCH v2 1/3] mmdebstrap: add "skip=cleanup/reproducible" option to mmdebstrap srinuvasan.a via isar-users
2025-03-07 12:25       ` [PATCH v2 2/3] image: download deb-src packages after imager creation srinuvasan.a via isar-users
2025-03-07 12:25       ` [PATCH v2 3/3] image: disable clean-log-files ROOTFS_FEATURES for deb-src caching srinuvasan.a via isar-users
2025-03-07 21:59       ` 'Jan Kiszka' via isar-users [this message]
2025-03-08 13:44         ` [PATCH v2 1/3] mmdebstrap: add "skip=cleanup/reproducible" option to mmdebstrap 'cedric.hombourger@siemens.com' via isar-users
2025-03-08 18:25           ` 'Arjunan, Srinu' via isar-users
2025-03-08 19:15             ` 'cedric.hombourger@siemens.com' via isar-users
2025-03-09  8:46               ` 'Arjunan, Srinu' via isar-users
2025-03-10  9:14                 ` 'cedric.hombourger@siemens.com' via isar-users
2025-03-10 12:01                   ` 'Arjunan, Srinu' via isar-users
2025-03-08 19:20             ` 'cedric.hombourger@siemens.com' via isar-users
2025-03-08 18:20         ` Srinuvasan Arjunan
2025-03-05 14:25 ` [PATCH 3/3] image: disable clean-log-files ROOTFS_FEATURES for deb-src caching srinuvasan.a via isar-users
2025-03-05 14:40 ` [PATCH 1/3] mmdebstrap: add "skip=cleanup/reproducible" option to mmdebstrap 'Jan Kiszka' via isar-users
2025-03-06  6:08   ` 'Arjunan, Srinu' via isar-users
2025-03-06  8:20     ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47d50bdd-2f10-4373-9009-554365643775@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=Adithya.Balakumar@toshiba-tsip.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=srinuvasan.a@siemens.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox