public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Isaac True' via isar-users" <isar-users@googlegroups.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] linux-custom: Sync provides value with build profiles
Date: Mon, 10 Nov 2025 12:20:04 +0100	[thread overview]
Message-ID: <48c754c9-6d5c-4612-b314-39cfc0cb0b75@emlix.com> (raw)
In-Reply-To: <20251110110626.309753-1-amikan@ilbers.de>

Hi,

This could be simplified down to something like this which would avoid 
creating new functions and be consistent with other places in 
linux-custom.inc:

RECIPE_PROVIDES:append = " ${@ bb.utils.contains('DEB_BUILD_PROFILES', 
'nolibcdev', '', 'linux-libc-dev linux-libc-dev-${DISTRO_ARCH}-cross', 
d) }"

What do you think?

Cheers,
Isaac

On 10/11/2025 12:06, Anton Mikanovich wrote:
> Packages linux-libc-dev and linux-libc-dev-${DISTRO_ARCH}-cross were
> added to PROVIDES variable unconditionally, while those packages are
> not really built until KERNEL_LIBC_DEV_DEPLOY enabled (which is set to
> "0" by default).
> 
> Add libc-dev packages to PROVIDES only if there are no 'nolibcdev'
> Debian build profile used so PROVIDES will be always in sync with real
> set of packages being built.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>   meta/recipes-kernel/linux/linux-custom.inc | 15 +++++++++++++--
>   1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
> index f2892921..cc12725b 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -144,13 +144,24 @@ RECIPE_PROVIDES:class-kbuildtarget = " \
>   DEPENDS:class-kbuildtarget = "${BPN}"
>   ISAR_CROSS_COMPILE:class-kbuildtarget = "0"
>   
> +# Provide linux-libc-dev packages unless nolibcdev profile used
> +def get_libc_dev_provides(d):
> +    additional_profiles = get_additional_build_profiles(d)
> +    if 'nolibcdev' not in additional_profiles:
> +        return d.getVar("RECIPE_PROVIDES_LIBC_DEV")
> +    return ""
> +
> +RECIPE_PROVIDES_LIBC_DEV = " \
> +    linux-libc-dev \
> +    linux-libc-dev-${DISTRO_ARCH}-cross \
> +"
> +
>   # Make bitbake know we will be producing linux-image and linux-headers packages
>   # Also make it know about other packages from control
>   RECIPE_PROVIDES = " \
>       linux-image-${KERNEL_NAME_PROVIDED} \
>       linux-headers-${KERNEL_NAME_PROVIDED} \
> -    linux-libc-dev \
> -    linux-libc-dev-${DISTRO_ARCH}-cross \
> +    ${@get_libc_dev_provides(d)} \
>       linux-image-${KERNEL_NAME_PROVIDED}-dbg \
>       linux-kbuild-${KERNEL_NAME_PROVIDED} \
>       ${BPN}-pseudo-native \

-- 
Isaac True
emlix GmbH, https://www.emlix.com
Fon +49 228 94 77 96 94
Bachstraße 6, 53115 Bonn, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsfuehrung: Heike Jordan, Dr. Uwe Kracke
Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/48c754c9-6d5c-4612-b314-39cfc0cb0b75%40emlix.com.

  reply	other threads:[~2025-11-10 11:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 11:06 Anton Mikanovich
2025-11-10 11:20 ` 'Isaac True' via isar-users [this message]
2025-11-10 11:39   ` Anton Mikanovich
2025-11-10 11:55     ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48c754c9-6d5c-4612-b314-39cfc0cb0b75@emlix.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=itrue@emlix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox