From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6790334981638979584 X-Received: by 2002:a17:906:c34a:: with SMTP id ci10mr4394900ejb.245.1581009682810; Thu, 06 Feb 2020 09:21:22 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:9558:: with SMTP id v24ls3431500eda.2.gmail; Thu, 06 Feb 2020 09:21:21 -0800 (PST) X-Google-Smtp-Source: APXvYqzSUGyDJPK7XGURXY+Qdg3by9V1OPcIDwsId17vekWGMtBGi6jgDIwQpIh0b998JvwgwXDb X-Received: by 2002:a05:6402:3046:: with SMTP id bu6mr4091588edb.139.1581009681906; Thu, 06 Feb 2020 09:21:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581009681; cv=none; d=google.com; s=arc-20160816; b=PJwgbhbFHmn3gPJ7cG+s0U7bPBGXAu9+K7BGNlZoao2kGNn7K1kecHSFvrN00ngT4Q AwbJwJh9oY2ZZfdt6/+chkQSxkaMix9b2wD7r0zpYxzbh4sFbmkAqXRsWnwnLYM33zae Yw3C3fABZ5HbL/NLTlmlXq6apbUjpSTc5hDY/yz0RJ8TWBvCc7pbv38KdemQQnFCDcmm tp1VjPY37B/QM966aBG3seBMRUKPb0d+GJfkT35Zb5NEA798LWGZhr0G65g75y+pqFo1 PpMWh7S6P6qhhWr+GB4KrU2amfpbxXz6r6yeUKgLccQ0AaytvUrosGe0gvOh9oybL/f0 TLuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=Ox9tAfcPluwbT4ZJaNAFDVRWcjc1kUdUbRN6tGy4BP8=; b=uQjfyGRCBS40P1NP9Isqbq8HAKBiSKe5MS1d4FjGT5GgfR7w3MyieXEmydetlYTzSY bIHyb0cJ7XiR6tBVgz0RigoC6EIjS5c9C/3EfBREDjDyaGU7ukKkgNzO63wdHARJ4qLU Bcb2hWn9s5sbtGGozlfkez8Rze5LanqlmaGoaI45HD4ild7icmjWM3rP8dfzispWSwM9 JYDZzn1qhVcj0YrJikx980d4SZkBHa7KsUlG4rxl/Al3uTeRqLxDsmNOQZuF5lEM4HrP kByZhEMm0oocFw3sG8P+oCnU6PVayfGFy4Vr9YRUA2Q95MgG3xOHgu5IjEwMqoMrIt5P ckEA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id b4si10561edf.5.2020.02.06.09.21.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Feb 2020 09:21:21 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 016HLK7i022474 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Feb 2020 18:21:20 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 016HLK0D015821; Thu, 6 Feb 2020 18:21:20 +0100 Subject: Re: [PATCH] rootfs: Make rootfs_postprocess_finalize the last step To: Vijai Kumar K , isar-users@googlegroups.com Cc: Vijai Kumar K References: <20200206140631.7928-1-Vijaikumar_Kanagarajan@mentor.com> From: Jan Kiszka Message-ID: <48d46a27-295c-a4d4-ea72-0ea2a1791809@siemens.com> Date: Thu, 6 Feb 2020 18:21:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200206140631.7928-1-Vijaikumar_Kanagarajan@mentor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: +J65WgE+tZaO On 06.02.20 15:06, Vijai Kumar K wrote: > Sometimes the additional postprocessing functions we add as > part our custom image needs a proper chroot environment. When exactly? > > Implicitly make rootfs_postprocess_finalize as the last step > to be executed in rootfs_postprocess task. > Well, that relies on no one else using _append to add things. Otherwise, the race is open again... Jan > Signed-off-by: Vijai Kumar K > --- > meta/classes/rootfs.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 64eaef7..b0394d5 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -197,7 +197,7 @@ rootfs_generate_manifest () { > ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest > } > > -ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'finalize-rootfs', 'rootfs_postprocess_finalize', '', d)}" > +ROOTFS_POSTPROCESS_COMMAND_append = "${@bb.utils.contains('ROOTFS_FEATURES', 'finalize-rootfs', ' rootfs_postprocess_finalize', '', d)}" > rootfs_postprocess_finalize() { > sudo -s <<'EOSUDO' > test -e "${ROOTFSDIR}/chroot-setup.sh" && \ > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux