Re: [PATCH 2/5] ccache: fix CCACHE_DIR owner for sbuild

[Anton Mikanovich <amikan@ilbers.de>]

12/01/2023 12:00, Moessbauer, Felix wrote:
> On Mon, 2022-12-19 at 17:29 +0300, Anton Mikanovich wrote:
>> If CCACHE_DIR do not exist before sbuild execution it is created with
>> root
>> privelegies. This results in permissions issues during the next usage
>> by the
>> imager. Create CCACHE_DIR before sbuild to fix that.
>>
>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>> ---
>>   meta/classes/sbuild.bbclass | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/sbuild.bbclass
>> b/meta/classes/sbuild.bbclass
>> index a29b745b..b49eae79 100644
>> --- a/meta/classes/sbuild.bbclass
>> +++ b/meta/classes/sbuild.bbclass
>> @@ -129,6 +129,7 @@ EOSUDO
>>   }
>>   
>>   schroot_configure_ccache() {
>> +    [ ! -e ${CCACHE_DIR} ] && mkdir -p ${CCACHE_DIR}
> This line creates the ccache folder as root user.

Why? It is placed outside sudo section, so should be executed from the 
current
user.

> A couple lines below we find the following:
>
> install --group=sbuild --mode=2775 -d ${CCACHE_DIR}
>
> If I read the code correctly, this line has no effect anymore, as the
> mkdir is always executed first (and with incorrect permissions).

This one should be probably removed.
Not sure why mode setting do not help here.
> Felix
>
>>       sudo -s <<'EOSUDO'
>>           set -e
>>   
>> -- 
>> 2.17.1
>>