From: Jan Kiszka <jan.kiszka@siemens.com>
To: Henning Schild <henning.schild@siemens.com>,
Joe MacDonald <joe_macdonald@mentor.com>
Cc: <isar-users@googlegroups.com>, <joe.macdonald@siemens.com>
Subject: Re: [PATCH v2] expand-on-first-boot: support resizing a btrfs root
Date: Fri, 22 Apr 2022 11:06:26 +0200 [thread overview]
Message-ID: <4a485b9e-9362-3138-f955-5a249ea0b665@siemens.com> (raw)
In-Reply-To: <20220422095728.410441bb@md1za8fc.ad001.siemens.net>
On 22.04.22 09:57, Henning Schild wrote:
> Hey Joe,
>
> will you follow up with a v3? We are having another patch for
> expand-on-first-boot coming up and discussions on how we could maybe
> eventually switch to systemd-repart.
systemd-growfs. Only this would be relevant for adding more fs types
like here. repart has nothing to do with that.
Jan
>
> https://groups.google.com/g/isar-users/c/p5QADbRC3EA
>
> Henning
>
> Am Fri, 22 Oct 2021 15:50:47 -0400
> schrieb Joe MacDonald <joe_macdonald@mentor.com>:
>
>> resize2fs fails if the build sets the root filesystem for an image to
>> btrfs though the partition is expanded properly. Since the rest of the
>> script works as intended, simply checking the last partition type with
>> lsblk and adding `btrfs resize` instead of `resize2fs` in the
>> appropriate circumstance allows everything to function as expected.
>>
>> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
>> ---
>> .../files/expand-last-partition.sh | 22
>> ++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git
>> a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
>> b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
>> index 7175dfd..6975d9c 100755 ---
>> a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
>> +++
>> b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
>> @@ -36,8 +36,20 @@ sfdisk -d "${BOOT_DEV}" 2>/dev/null | \ # Inform
>> the kernel about the partitioning change partx -u "${LAST_PART}" -#
>> Do not fail resize2fs if no mtab entry is found, e.g., -# when using
>> systemd mount units. -export EXT2FS_NO_MTAB_OK=1
>> -
>> -resize2fs "${LAST_PART}"
>> +# Determine the filesystem type and perform the appropriate resize
>> function +ROOTFS_TYPE=$(lsblk -fno FSTYPE ${ROOT_DEV})
>> +case ${ROOTFS_TYPE} in
>> + ext* )
>> + # Do not fail resize2fs if no mtab entry is found, e.g.,
>> + # when using systemd mount units.
>> + export EXT2FS_NO_MTAB_OK=1
>> + resize2fs "${LAST_PART}"
>> + ;;
>> + btrfs )
>> + btrfs filesystem resize max /
>> + ;;
>> + * )
>> + echo "Unrecognized filesystem type ${ROOTFS_TYPE} - no resize
>> performed"
>> + exit 1
>> + ;;
>> +esac
>
--
Siemens AG, Technology
Competence Center Embedded Linux
next prev parent reply other threads:[~2022-04-22 9:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 18:01 [PATCH] " Joe MacDonald
2021-10-22 18:19 ` Jan Kiszka
2021-10-22 19:50 ` Joe MacDonald
2021-10-22 19:50 ` [PATCH v2] " Joe MacDonald
2021-10-25 8:10 ` Henning Schild
2021-10-25 8:22 ` Henning Schild
2022-04-22 7:57 ` Henning Schild
2022-04-22 9:06 ` Jan Kiszka [this message]
2022-12-09 15:40 ` Henning Schild
2022-12-10 3:28 ` Roberto A. Foglietta
2022-12-10 16:29 ` Henning Schild
2022-12-10 20:37 ` Roberto A. Foglietta
2022-12-12 15:24 ` Henning Schild
2022-12-12 17:48 ` Roberto A. Foglietta
2022-12-13 2:10 ` Moessbauer, Felix
2022-12-13 6:02 ` Roberto A. Foglietta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a485b9e-9362-3138-f955-5a249ea0b665@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=joe.macdonald@siemens.com \
--cc=joe_macdonald@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox