public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "amikan@ilbers.de" <amikan@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH v11 3/3] CI: Check kernel artifacts deployment
Date: Mon, 29 Jun 2026 16:06:03 +0000	[thread overview]
Message-ID: <4a941ab7f3ea7c1c919163a3a12092649cc1ebfc.camel@siemens.com> (raw)
In-Reply-To: <20260609084422.3948645-4-amikan@ilbers.de>

On Tue, 2026-06-09 at 11:44 +0300, Anton Mikanovich wrote:
> Improve existing deploy testcases to be sure kernel and dtb files are
> really exist in deploy dir after the building.

"are really exist": typo

The code itself is fine.

Felix

> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  testsuite/citest.py | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index 5aa3e799..662af1de 100644
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -715,6 +715,20 @@ class DtbDeployTest(CIBaseTest):
>      :avocado: tags=dtbdeploy,full
>      """
>  
> +    def check_kernel_deploy(self, targets):
> +        for t in targets:
> +            dd, kernel_name, dtbs = \
> +                CIUtils.getVars('DEPLOY_DIR_IMAGE', 'KERNEL_IMAGE',
> +                                'DTB_FILES', target=t)
> +            self.log.info(f"dd={dd}, kernel_name={kernel_name}, dtbs={dtbs}")
> +            kernel_path = f"{dd}/{kernel_name}"
> +            if not os.path.exists(kernel_path):
> +                self.fail(f"Target {t} failed to deploy kernel image!")
> +            for dtb_name in dtbs.split():
> +                dtb_path = f"{dd}/{dtb_name}"
> +                if not os.path.exists(dtb_path):
> +                    self.fail(f"Target {t} failed to deploy {dtb_name}!")
> +
>      def test_dtb_deploy_distros(self):
>          """
>          Cover case: Same machine, different distros
> @@ -727,6 +741,7 @@ class DtbDeployTest(CIBaseTest):
>          self.init()
>          self.move_in_build_dir('tmp', 'tmp_before_dtbdeploy')
>          self.perform_build_test(targets, image_install='')
> +        self.check_kernel_deploy(targets)
>  
>      def test_dtb_deploy_images(self):
>          """
> @@ -740,6 +755,7 @@ class DtbDeployTest(CIBaseTest):
>          self.init()
>          try:
>              self.perform_build_test(targets, image_install='')
> +            self.check_kernel_deploy(targets)
>          finally:
>              self.move_in_build_dir('tmp', 'tmp_dtbdeploy')
>  
> -- 
> 2.34.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260609084422.3948645-4-amikan%40ilbers.de.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/4a941ab7f3ea7c1c919163a3a12092649cc1ebfc.camel%40siemens.com.

  reply	other threads:[~2026-06-29 16:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  8:44 [PATCH v11 0/3] Move kernel artifacts deployment from image recipe Anton Mikanovich
2026-06-09  8:44 ` [PATCH v11 1/3] meta: Fix do_copy_boot_files error for different distros of same machine Anton Mikanovich
2026-06-09  8:44 ` [PATCH v11 2/3] meta: Move kernel artifacts deployment from image recipe Anton Mikanovich
2026-06-29 16:04   ` 'MOESSBAUER, Felix' via isar-users
2026-06-30 12:21     ` Anton Mikanovich
2026-06-30 14:28       ` 'MOESSBAUER, Felix' via isar-users
2026-06-09  8:44 ` [PATCH v11 3/3] CI: Check kernel artifacts deployment Anton Mikanovich
2026-06-29 16:06   ` 'MOESSBAUER, Felix' via isar-users [this message]
2026-06-29 15:21 ` [PATCH v11 0/3] Move kernel artifacts deployment from image recipe Zhihang Wei
2026-06-29 15:54   ` 'MOESSBAUER, Felix' via isar-users
2026-06-30 12:21     ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a941ab7f3ea7c1c919163a3a12092649cc1ebfc.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox