Re: [PATCH 2/2] meta/base.bbclass: integrate COMPATIBLE_MACHINE feature

[Claudius Heine <ch@denx.de>]

Hi Anton,

On 2023-08-17 16:06, Anton Mikanovich wrote:
> 17/08/2023 16:57, Claudius Heine wrote:
>> Integrate the COMPATIBLE_MACHINE of OE, where recipes can specify a
>> regex in COMPATIBLE_MACHINE that needs to match to an entry of the
>> MACHINEOVERRIDES variable, otherwise the recipe will be skipped.
>>
>> Similar to OE, with `PARSE_ALL_RECIPES`, parsing of the recipe can be
>> enforced.
>>
>> This code was copied from the OE-core codebase.
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> ---
>>   meta/classes/base.bbclass | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>> index 17bebe94..68e88390 100644
>> --- a/meta/classes/base.bbclass
>> +++ b/meta/classes/base.bbclass
>> @@ -165,6 +165,16 @@ python() {
>>                   d.prependVar(
>>                       e, cleandir_code.format(ws=ws, dirlist=" 
>> ".join(dirs))
>>                   )
>> +
>> +    need_machine = d.getVar('COMPATIBLE_MACHINE')
>> +    if need_machine and not d.getVar('PARSE_ALL_RECIPES', False):
>> +        import re
>> +        compat_machines = (d.getVar('MACHINEOVERRIDES') or 
>> "").split(":")
>> +        for m in compat_machines:
>> +            if re.match(need_machine, m):
>> +                break
>> +        else:
>> +            raise bb.parse.SkipRecipe("incompatible with machine %s 
>> (not in COMPATIBLE_MACHINE)" % d.getVar('MACHINE'))
>>   }
>>   def isar_export_proxies(d):
> 
> Hello Claudius,
> Import re is not needed here because already done at top of the function.

Sure. Do you want a v2 or are you deleting that line on merge?

regards,
Claudius

> 

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de