From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6607825373868589056 X-Received: by 2002:a19:c206:: with SMTP id l6-v6mr491791lfc.16.1538512562984; Tue, 02 Oct 2018 13:36:02 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:350e:: with SMTP id z14-v6ls273446ljz.25.gmail; Tue, 02 Oct 2018 13:36:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV63WvOscIsOMdRSbjrXXNP3VkLPZQAMuy9KctYBEpDl5Jk7jw/aDNcgqnL7vlPY6+HTUQzaa X-Received: by 2002:a2e:b018:: with SMTP id y24-v6mr510120ljk.15.1538512561337; Tue, 02 Oct 2018 13:36:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538512561; cv=none; d=google.com; s=arc-20160816; b=dStfqHVXYXqFnTg8VBKsSAMbTeLIwKZJTUK1rJJE9rOLEmZ955TbcL9WZvkAnsvNcg cs6l4tADnOdwUI7dAGG/izReDu/bxH0n4wB33Rmlbcv3DFDA5zM/8tVKQCcnFIsczI6t FMTrSc5lLaeOw5jGt56DUz2fpkchkntbJJyRIiVPVzliZKoBvIIJUYMAIUHVgF8uXl4s 8w+JUMVD4OOaQrMuNKk9gI3TEJaJjwLdXJ/JjfPQW8Qx218IVfW6u1IRGLuclQ8Igivw 8VOa88hAB7ADjJyoTyQq7dPi/pg/TYvzebQbZlSoLSZQyme0KdHHT03XVmOJkPUb+z/L pSXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=0OsLtoeoX2KYWzZewH5RcGRKbR01V9xh7thGWFjfWWM=; b=DluhTfKu/fW4IOr3lMXQL5SqsFMl89eWaGt0SPYXhOftX/nhKH1aAGICl1TLZAvg+3 X725XXFb8+sLPUPk8flOASDOnJR+wFdSYTSRW32Si5k3WuesKYPCD1d6jk0j4FhI8YQw /nAhmG6eh0I6NbqB+Sc/yyOnrQ0mYDjgH2fYKdYxs6IFdvpqI0/K5mYbctg9ENL/4JZE wO8fzPyIXmPKbP6NOMVK4LvhDmCNgCwzowk6AZaEr8Yo+iIauUjxPaQalpShQ7QlD8E7 wOmIHTYa+U+h86Dk/pcZGCcWeNtACwXrkTcS89G45EQoD7d6eYUdy4UQyAfK4D8YxFd8 4dCA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id n81-v6si141731lfi.0.2018.10.02.13.36.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 13:36:01 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w92Ka0HU010352 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 2 Oct 2018 22:36:00 +0200 Received: from [167.87.33.119] ([167.87.33.119]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w92KZx9U008966; Tue, 2 Oct 2018 22:36:00 +0200 Subject: Re: [PATCH] recipes-app: rename example app and lib recipe to contain PV To: "[ext] Henning Schild" , isar-users References: <20181002181710.28456-1-henning.schild@siemens.com> From: Jan Kiszka Message-ID: <4bc18ffc-bd6b-4568-0a89-32c1fd8e9cd5@siemens.com> Date: Tue, 2 Oct 2018 22:35:59 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20181002181710.28456-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Ukqs1tfRpqaw On 02.10.18 20:17, [ext] Henning Schild wrote: > The PV of a package is best contained in its filename, that way a > version bump would be chaning the file name. Also switch to using the > git tag as SRCREV, now we can really just rename that file to update. > > Following that pattern we could also have multiple versions of the > recipe in one tree. > > While we do not need all of this for Isar or for this simple example, be > a good example for people reading those recipes. NACK for the SRCREV changes. That's an OE anti-pattern, (almost) like specifying a branch and ${AUTOREV}. You need some sort of checksum (md5, sha256 for files, SHA1 for git commits) to validate no one moved the upstream tag around. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux