public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] meta-isar: hello: Use <orig-version> in CHANGELOG_V
Date: Tue, 28 Apr 2020 18:01:53 +0200	[thread overview]
Message-ID: <4c1fbf72-b59c-9dc4-e8ff-01d0bf8f0674@siemens.com> (raw)
In-Reply-To: <20200428180026.45a7acf4@md1za8fc.ad001.siemens.net>

On 28.04.20 18:00, Henning Schild wrote:
> I think with this we might be able to put everything into one .bb. At
> the moment we have the inc plus two bbs that have PV in their names.
> 
> Taking PV from a bb filename is wrong when the inc uses <orig-version>.
> 

"We cannot consolidate the recipes carrying the upstream
versions, though, as that information needs to be propagated into
${S}."

Jan

> Henning
> 
> On Thu, 23 Apr 2020 19:29:11 +0200
> Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Make use of the new placeholder to append "+isar" to the original
>> version. We cannot consolidate the recipes carrying the upstream
>> versions, though, as that information needs to be propagated into
>> ${S}.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Depends on
>> https://groups.google.com/d/msgid/isar-users/ebf1ab25-74ea-b3ba-4c48-2ecac873c6f7%40siemens.com
>>
>>   meta-isar/recipes-app/hello/hello.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-isar/recipes-app/hello/hello.inc
>> b/meta-isar/recipes-app/hello/hello.inc index c5f322bb..d81085d8
>> 100644 --- a/meta-isar/recipes-app/hello/hello.inc
>> +++ b/meta-isar/recipes-app/hello/hello.inc
>> @@ -11,7 +11,7 @@ inherit dpkg
>>   SRC_URI = "apt://${PN}"
>>   
>>   MAINTAINER = "isar-users <isar-users@googlegroups.com>"
>> -CHANGELOG_V = "${PV}-99+isar"
>> +CHANGELOG_V = "<orig-version>+isar"
>>   
>>   do_prepare_build() {
>>   	deb_add_changelog
> 


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2020-04-28 16:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 17:29 Jan Kiszka
2020-04-28 16:00 ` Henning Schild
2020-04-28 16:01   ` Jan Kiszka [this message]
2020-04-29  5:54     ` Henning Schild
2020-04-29  6:10       ` Jan Kiszka
2020-04-29  6:27         ` Henning Schild
2020-04-29  6:37           ` Henning Schild
2020-04-29  6:51             ` Henning Schild
2020-06-05 17:46               ` Henning Schild
2020-06-05 17:55                 ` Jan Kiszka
2020-06-06  8:10                   ` Henning Schild
2020-06-06  8:37                   ` Baurzhan Ismagulov
2020-06-08  7:59                     ` Jan Kiszka
2020-05-07 20:09         ` Baurzhan Ismagulov
2020-05-08  6:05           ` Jan Kiszka
2020-05-08  6:13             ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c1fbf72-b59c-9dc4-e8ff-01d0bf8f0674@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox