From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6691586504498610176 X-Received: by 2002:a1c:9950:: with SMTP id b77mr19145729wme.46.1566197975124; Sun, 18 Aug 2019 23:59:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:c411:: with SMTP id k17ls3581349wmi.1.gmail; Sun, 18 Aug 2019 23:59:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyczzZh9VUqneJWSOsbdfCMkEDs8v5ME5ke1rzCBvjkXR572CYevivAsq5Ke9ZHQQ7b2Qjz X-Received: by 2002:a1c:4383:: with SMTP id q125mr19316749wma.16.1566197974636; Sun, 18 Aug 2019 23:59:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566197974; cv=none; d=google.com; s=arc-20160816; b=U8Lw3dcVN4zlbRq7OM7ZwC3i6fmEb7b0QAmuE099G8IAgzzHdBP4lAkCrYyOqY8pYe WzIncCO2xnC65TLiCf1VmyzSZLAjMvX+hC8FtYgEeQdLCfwcUYbJ5dIM3twtcMUAqbDE 0EAQY/FPMdfzjWV/3qCpSirktMIq7bCG5H2R0+IR0fHJrudOITWZjPNEUqGp+qZrKKMB lLJuSjJZCaqgLKsyLSalVx+PRTvNQglnybwIQ+ZtHm7EUfaskn72zVKzBGp56rvu7a9q 8Op5rdnOj2Iti4iBNsc9QEn+xsRphpkc6ua0KQwBXigFjCU7pz3pe38LUa4I3aO0k0re R40Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=92OSRTw3mA4vMOw/7BdEHK+D5IFaypexONQW07MUwXs=; b=OiTYKx51iKSl9GhLBwwmVO7dd/fLF3DJsmSgpphfBfhPAvvptr1Jxel22LYMSgsnTc +6ZBYUcLQx/LdCmC9T4uqzH7eT92eJtDoTAx3XCoMafbxwVmtRs5Qiz/JtxXdPweVj3p dcCBVWhGHrcabEIm8aLrGlS0jzLJwHdpSJeSMkpWgqKGxRwwF0lMv/GWcOk1+Cidyagk zYHNu4XDhuP/v6m8rZ2Oz2DxlPQoXfiIS394Ap65VXFnENCGp437A9OU4R44NOja5Icb Xt+8vYVLTSvdhWOg4eNPl24knVXtimIIRllo52CZZtoLfI24jxvWpb3r6pzlzlwHL+fH SRBA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id f13si590987wmc.3.2019.08.18.23.59.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Aug 2019 23:59:34 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x7J6xXkX004094 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Aug 2019 08:59:33 +0200 Received: from [139.25.69.208] (linux-ses-ext02.ppmd.siemens.net [139.25.69.208]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7J6xW7C012885; Mon, 19 Aug 2019 08:59:33 +0200 Subject: Re: [PATCH v4 2/8] split up isar-bootstrap helper and implement pre-process pipeline To: Jan Kiszka , isar-users@googlegroups.com Cc: Claudius Heine References: <20190523145521.23050-1-claudius.heine.ext@siemens.com> <20190523145521.23050-3-claudius.heine.ext@siemens.com> <9854b2df-897d-393a-e968-e23fccbb67a1@siemens.com> From: Claudius Heine Message-ID: <4cccc136-83f6-a7ea-ce94-686fdab09b1d@siemens.com> Date: Mon, 19 Aug 2019 08:59:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <9854b2df-897d-393a-e968-e23fccbb67a1@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: FCvFZvBnGNYR Hi Jan, On 14/08/2019 18.00, Jan Kiszka wrote: > On 23.05.19 16:55, [ext] claudius.heine.ext@siemens.com wrote: >> From: Claudius Heine >> >> This removes the isar-bootstrap-helper.bbclass and integrates its >> functionality into the rootfs.bbclass. >> >> It introduces the rootfs_install task that runs through multiple >> functions from command lists in order to allow easy integration of >> custom functions. >> >> The introduced functions are, in general order of execution: >> >>    rootfs_prepare: copy the isar-bootstrap rootfs base to workdir >>    rootfs_configure_*: basic configuration of the root file system, >>      before any custom packages where installed. (`/dev`, `/proc`, etc. >>      are not mounted). Functions are added to `ROOTFS_CONFIGURE_COMMAND`. >>    rootfs_do_mount: mount standard directories and repositories into the >>      rootfs >>    do_rootfs_install_*: downloading and installing packages. Functions >>    are added to `ROOTFS_INSTALL_COMMAND`. >> >> Signed-off-by: Claudius Heine >> --- >>   meta/classes/image.bbclass                    |  24 +-- >>   meta/classes/isar-bootstrap-helper.bbclass    | 132 -------------- >>   meta/classes/rootfs.bbclass                   | 172 +++++++++++++++++- >>   .../isar-bootstrap/isar-bootstrap.inc         |   5 + >>   .../buildchroot/buildchroot-host.bb           |  16 +- >>   .../buildchroot/buildchroot-target.bb         |   2 - >>   .../buildchroot/buildchroot.inc               |  26 ++- >>   meta/recipes-devtools/sdkchroot/sdkchroot.bb  |  48 ++--- >>   8 files changed, 228 insertions(+), 197 deletions(-) >>   delete mode 100644 meta/classes/isar-bootstrap-helper.bbclass >> > > [...] > >> diff --git a/meta/recipes-devtools/buildchroot/buildchroot-host.bb >> b/meta/recipes-devtools/buildchroot/buildchroot-host.bb >> index 73cd548..121992c 100644 >> --- a/meta/recipes-devtools/buildchroot/buildchroot-host.bb >> +++ b/meta/recipes-devtools/buildchroot/buildchroot-host.bb >> @@ -7,6 +7,8 @@ DESCRIPTION = "Isar development filesystem for host" >>   PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}" >>   require buildchroot.inc >> +ROOTFS_ARCH = "${HOST_ARCH}" >> +ROOTFS_DISTRO = "${HOST_DISTRO}" >>   BUILDCHROOT_PREINSTALL ?= "make \ >>                              debhelper \ >> @@ -18,15 +20,5 @@ BUILDCHROOT_PREINSTALL ?= "make \ >>                              automake \ >>                              devscripts \ >>                              equivs \ >> -                           libc6:${DISTRO_ARCH}" >> - >> -# According to the wiki page: >> -#     https://wiki.debian.org/CrossToolchains >> -BUILDCHROOT_PREINSTALL_append_armhf += "binutils-arm-linux-gnueabihf \ >> -                                        crossbuild-essential-armhf" >> -BUILDCHROOT_PREINSTALL_append_arm64 += "binutils-aarch64-linux-gnu \ >> -                                        crossbuild-essential-arm64" > > Where did binutils go after this patch? Don't we need them? Wondering > because there is no remark in the commit why they were removed. Well crossbuild-essential-* is added and just like 'build-essential' binutils is a dependency from it: crossbuild-essential-* > gcc-*-linux-gnueabi > gcc-8-*-linux-gnueabi > binutils-*-linux-gnueabi So that was just a removal of unneeded package names, that get installed anyway. Claudius > > Jan > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de