From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6802611076497145856 X-Received: by 2002:a2e:93d7:: with SMTP id p23mr2616420ljh.9.1587138395270; Fri, 17 Apr 2020 08:46:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:5a0e:: with SMTP id q14ls427683lfn.3.gmail; Fri, 17 Apr 2020 08:46:34 -0700 (PDT) X-Google-Smtp-Source: APiQypLn/nFUkcCs3diA/L8SoeTDuTOIZbUH2oPLYi+Ftjw21QcF7X+ztCDm61fkxCbknQLMzgLR X-Received: by 2002:a05:6512:1046:: with SMTP id c6mr2490243lfb.115.1587138394390; Fri, 17 Apr 2020 08:46:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587138394; cv=none; d=google.com; s=arc-20160816; b=I8/qRmsPC8L4LhgD9uk1w758DJ+6SzixAmNsJNb3czsrTiTwXgR8DZyxvzfLTFyh21 ZOwa8DVaQ2RcQ+UIO7ORUkeAZ/SJoqwJPCyobCWGGC4fCmQ9JW0z4BrO9zLYHkF1lQlb InQ7GBDunGWL5vn70HYZ9k4hkrkEHU8gMKUzwiVh/jBrJf6khYukcbjSK02DczpVMCXq u3NaIY0ltfNyuub1+Wce/D4rewWqdBnB0F92LcU/GGu8j9WgpRb/npw7XGDaeeLwMxOP 5esVDYlqxHOiPpELVo48N248oEzn0vIYQFbTtSn0YWs20OPpOqmoUOVTxdxKzU42eKWM P0/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=IOdzKFm54A4TecKxMbeKXd4KfY7MOtJB3BDooVMyuWQ=; b=iJAvHq4TxGAJQ7L11DMl87MEYZOwxgBNLkFZMUfnvEYF/LQ1eQbB63xxjbmguQpFcx /Ao5kJynef8ic/8a5RVUN/oPI4tec+H9wh/hAGuxgrkzPcFn+2UthtDu7OPmCnZqtbBj Y+r/ovz6nShnTlcWHcdPXLSN5C7v/KFWfSeEg3YI90WuG8I3hrlutCjFBv1wl2SMkDOV kZSDVxIMg6xRNt3FqbBl/bMizSZ6PNynBVYxJgjgrm+Ru9tZzSCHlkA/9jEg7A9sF4gG fFqINJsVpL/JIvS2FGEPCgb28N3FBAe7xP4WjRe1itNZZ1Vxadohh+K3AXA6WMEon2Gf eyhQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id k13si1156747lfg.5.2020.04.17.08.46.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Apr 2020 08:46:34 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 03HFkX89012092 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 17 Apr 2020 17:46:33 +0200 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 03HFkXDq003863 for ; Fri, 17 Apr 2020 17:46:33 +0200 Subject: Re: [[PATCH v2] 3/3] dpkg-raw: make sure templates are processed before do_install To: isar-users@googlegroups.com References: <20200316133934.223e4a0b@md1za8fc.ad001.siemens.net> <1584363352-866-1-git-send-email-Cedric_Hombourger@mentor.com> <1584363352-866-4-git-send-email-Cedric_Hombourger@mentor.com> <20200410121132.oaaxohphxq7qlqze@yssyq.m.ilbers.de> <20200417153003.ho7ymnq3gpbneav3@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: <4d21cb78-86b1-7103-c9b6-34e182d86ad8@siemens.com> Date: Fri, 17 Apr 2020 17:46:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200417153003.ho7ymnq3gpbneav3@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: QSwfMeSV34Yq On 17.04.20 17:30, Baurzhan Ismagulov wrote: > Hello Jan, > > On Tue, Apr 14, 2020 at 08:02:56AM +0200, Jan Kiszka wrote: >>>> --- a/meta/classes/dpkg-raw.bbclass > ... >>>> +inherit template >>>> +addtask do_transform_template after do_unpack before do_install >>> >>> How does this relate to "addtask do_transform_template after do_unpack" in >>> meta/classes/template.bbclass? Is one of them superfluous? If yes, would >>> modifying template.bbclass be better? >> >> do_install is dpkg-raw only, so you can't do that in template.bbclass. > > Indeed. > > >> But I >> would rather model this via the addtask of install which is under this >> class' control already. >> >> Also, that inherit is redundant because it's already part of the base class, >> thus every other class. > > Do I understand correctly, you suggest: > > 1. Keep both addtasks in template.bbclass and dpkg-raw.bbclass. > No. Change the addtask statement for do_install in dpkg-raw to express its new dependency on template, drop the addtask of do_transform_template there. And obviously do not touch template.bbclass. > 2. Remove "inherit template". ...from dpgk-raw, yes. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux