From: Zhihang Wei <wzh@ilbers.de>
To: Clara Kowalsky <clara.kowalsky@siemens.com>, isar-users@googlegroups.com
Cc: florian.bezdeka@siemens.com
Subject: Re: [PATCH] installer-add-rootfs: build target image for image data postfix
Date: Wed, 29 Oct 2025 08:53:24 +0100	[thread overview]
Message-ID: <4d4823c1-5040-4225-abfd-aab37d100e67@ilbers.de> (raw)
In-Reply-To: <20251016143650.1875846-1-clara.kowalsky@siemens.com>
Applied to next, thanks.
Best regards,
Zhihang
On 10/16/25 16:36, 'Clara Kowalsky' via isar-users wrote:
> Even if the image data postfix was set to something other than wic*, the
> do_image_wic task was executed for the target image. This fixes this
> issue and invokes the correct corresponding task.
>
> Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
> ---
>   meta-isar/classes/installer-add-rootfs.bbclass | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/meta-isar/classes/installer-add-rootfs.bbclass b/meta-isar/classes/installer-add-rootfs.bbclass
> index c738f690..6708932c 100644
> --- a/meta-isar/classes/installer-add-rootfs.bbclass
> +++ b/meta-isar/classes/installer-add-rootfs.bbclass
> @@ -44,9 +44,14 @@ def get_mc_depends(d, task):
>       installer_target_mc = d.getVar('INSTALLER_TARGET_MC') or ""
>       return f"mc:{installer_mc}:{installer_target_mc}:{installer_target_image}:{task}"
>   
> +def get_image_type(suffix):
> +    image_type = suffix.split(".")[0]
> +    return f"{image_type}"
> +
>   ROOTFS_ADDITIONAL_FILE_installer-target[source] = "${@ get_installer_source(d, d.getVar('IMAGE_DATA_POSTFIX'))}"
>   ROOTFS_ADDITIONAL_FILE_installer-target[destination] = "${@ get_installer_destination(d, d.getVar('IMAGE_DATA_POSTFIX'))}"
>   ROOTFS_ADDITIONAL_FILE_installer-target-bmap[source] = "${@ get_installer_source(d, "wic.bmap")}"
>   ROOTFS_ADDITIONAL_FILE_installer-target-bmap[destination] = "${@ get_installer_destination(d, "wic.bmap")}"
>   
> -do_rootfs_install[mcdepends] += "${@ get_mc_depends(d, "do_image_wic")}"
> +INSTALLER_TARGET_TASK ??="do_image_${@ get_image_type(d.getVar('IMAGE_DATA_POSTFIX'))}"
> +do_rootfs_install[mcdepends] += "${@ get_mc_depends(d, d.getVar('INSTALLER_TARGET_TASK'))}"
-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/4d4823c1-5040-4225-abfd-aab37d100e67%40ilbers.de.
     prev parent reply	other threads:[~2025-10-29  7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 14:36 'Clara Kowalsky' via isar-users
2025-10-29  7:53 ` Zhihang Wei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=4d4823c1-5040-4225-abfd-aab37d100e67@ilbers.de \
    --to=wzh@ilbers.de \
    --cc=clara.kowalsky@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox