From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6830344030104059904 X-Received: by 2002:a2e:5451:: with SMTP id y17mr132206ljd.223.1590731634027; Thu, 28 May 2020 22:53:54 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9042:: with SMTP id n2ls994541ljg.4.gmail; Thu, 28 May 2020 22:53:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+7uIuf2IXm4RmSQOqJYZFLT+SZRtjVXHzIGg+KyEdPZ8vmExEPAUrcwxhLiGzybQO6GUR X-Received: by 2002:a2e:8912:: with SMTP id d18mr2810022lji.419.1590731633203; Thu, 28 May 2020 22:53:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590731633; cv=none; d=google.com; s=arc-20160816; b=0BbOym+aez2T4trdEQxVCtbQLguVvUHQSkZbRpef7BTlLS5Y0igxbMly9AyVrKa3uf dPDJGBuGvKCsJ1SvrS1X0gWFyuAldXf0mdkunrUqtDtOJSzx4DjZ2ivfz2VlQLKjPRnE x5bUA2LAyZyC6J2jvTgx62o+7sd3+f2Q4suywu1KAOuonI2Gr4DW1DdfPqnval982Iam EM8BGDBYLt/+uB0BwP6E06gv56PPxmkhWmy9uZqpPWkOJ/Gwzh9dC08/lDZ2EFCZbd8d iJkrwPED7SlPkDQgQcAczOuGxtj1j4dTDpMrqkePlGKZ26ijLXVQJ2gf3vrapZCd8TFH y14A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=hNM0NnbFJnLta2zG2bAxHonW69k9XPPUSU9klJaT44I=; b=Pd4si89xIkLDZHunnVcFNTCPpGHREXUlL/IsKcM6wsuAysiEi54/FOWlG5Vky1sPeD VWkpM9k+814K1GdzskguJaZ2TNR4sTgo0iqsnKWROQdTuB6ff9WWa5HFjDFTE+YgGzpN DPXap4c0pqDSYSXJF3Wk7oDNxMQDUklz5yS/+Mk3+kbWHWtohBxF0t5dqpGup5koo681 oavq7b0v0LLfIkO0nmCl7Lgrqf9kQu+556klDLOqFasiVMKgT8MLx7ipzndGvnIBUd8a rm4njaeLp2e1RAlxWqgd/WiVSfsODklmeJoWBnNK+olEoO2tofuHE2KGAmSH26tnZBnS psXg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f16si540126lfm.0.2020.05.28.22.53.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2020 22:53:53 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 04T5rq9U003833 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 29 May 2020 07:53:52 +0200 Received: from [139.22.33.199] ([139.22.33.199]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 04T5rpZX030603 for ; Fri, 29 May 2020 07:53:52 +0200 Subject: Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl To: isar-users References: <289568e6-46d2-e2e3-9771-7668cd10bc01@web.de> <20200528200446.3zlpkejasd2gex4r@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: <4ddde1de-c1bc-451a-e9a1-dd2bd17712bf@siemens.com> Date: Fri, 29 May 2020 07:53:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200528200446.3zlpkejasd2gex4r@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: cc+jWdA5b3gs On 28.05.20 22:04, Baurzhan Ismagulov wrote: > On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote: >> .PHONY is not needed (and wasn't consistently used anyway). And that >> missing && before the last export was apparently not critical as well. > > Wow, export A=a export B=b is accepted at least by bash. The && fix is still > needed if there is an error in A=a, thanks for the catch. > > Regarding .PHONY, could you please comment why it is not needed? Usually it's a > safeguard against the case when a file with the name of a target exists (e.g., > override_dh_auto_clean). In that case, the target is not built, and .PHONY > enforces building. If there are no other reasons, I'd rather go towards making > it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install). I suspect the Debian's build framework sets them already because I haven't seen them in use in all examples and manuals I read. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux