From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6525492966897745920 X-Received: by 10.28.116.17 with SMTP id p17mr934769wmc.29.1520234186558; Sun, 04 Mar 2018 23:16:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.161.20 with SMTP id o20ls3906064wro.6.gmail; Sun, 04 Mar 2018 23:16:26 -0800 (PST) X-Google-Smtp-Source: AG47ELuzFi9Zo+brI7MO5gKr8W9vKObM55nwREYqgvfvvcEOJRFfs8JFeOwgYAz2n2lbsxxp/o1E X-Received: by 10.223.142.69 with SMTP id n63mr1140890wrb.28.1520234186037; Sun, 04 Mar 2018 23:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520234185; cv=none; d=google.com; s=arc-20160816; b=fNU1EmlFUDKMjYPRPUYGkOrWVJkObORYn92wASOw2XQDSEDQHhXft1ESAy0Lbklbw8 UkDO7XxH0Fxq40rQomIQTWJuBLAQCM2vfttKwuI2VAz8r+geI5di9JYW3/aleqYLkRP3 GzIWuJDAHZ9l8NKmg/8InTcrT3G2IJNp0Ff8Zaow65NdtoiyOi4PrU1IkV3/OXKxKhbs IWXrfQDJTCtqsXe90KO7NsWvD6U2HFy1TUJCvNRpFZHit9QfsicYadvusnrB5DE9TLj0 afLxNciF4jn/oKn1VwwSyn/Eu83h+cMzdfzPbrXHf1pQ5lSFy0yrZseT1BqkzlJP0dPj MlQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=m8xnAcwW8WWXiEu7w0dk8VpC7sV0sHlY4DM0T74guMs=; b=XV+sXDvitIwGEJKiD0P2meSvpiJXCu5calfhbfxYeiYf96Y/weKBZMrOcMu1IMzqLY hUudjvjiCvPI6lUXpaPQKxzT1pj3BJChhL5PLfc5dT/xTKzpRRss1OvIqvH45H/So7vH mPG5Jb6TrzA3bwC54qL8w+lVOhRZvsKiR7q/pmfQXu6eLfNtBtptRz5tklKr4UGGwxDk IgEPfIwnwA1c4azDmBvAwjm0Ih8LbAkKu+ZJ+XdzqS7GI2aBTlgA7Hi/Pz62G0lO/QHi t5nSWnlellNDEoK82GQs2cPjw/4MsPxc8dSGZBv1fY98hBEiLAFBhrNw86jwxK/XBcJL dAHg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id j199si194623wmj.1.2018.03.04.23.16.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Mar 2018 23:16:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w257GMZV004390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 5 Mar 2018 08:16:24 +0100 Subject: Re: [PATCH] linux-custom: Add lock to dependency installation To: Jan Kiszka , isar-users References: <561e3ebb-f877-596c-fde6-0f3bba770958@siemens.com> From: Alexander Smirnov Message-ID: <4e09e77e-07b7-c48a-894d-1c8f156c23f6@ilbers.de> Date: Mon, 5 Mar 2018 10:16:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <561e3ebb-f877-596c-fde6-0f3bba770958@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Ngw9zfjEQ6yw On 02/23/2018 12:25 AM, Jan Kiszka wrote: > From: Jan Kiszka > > The build script of linux-custom requires the same lock protection as > build.sh of the dpkg builder class. Otherwise, we see the infamous build > failures again due to contention on the dpkg database lock. > > Signed-off-by: Jan Kiszka > --- > meta/recipes-kernel/linux/files/build-kernel.sh | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh b/meta/recipes-kernel/linux/files/build-kernel.sh > index 94897ec..42c8ff6 100644 > --- a/meta/recipes-kernel/linux/files/build-kernel.sh > +++ b/meta/recipes-kernel/linux/files/build-kernel.sh > @@ -13,8 +13,10 @@ REPACK_DIR="$1/../repack" > REPACK_LINUX_IMAGE_DIR="${REPACK_DIR}/linux-image" > REPACK_LINUX_HEADERS_DIR="${REPACK_DIR}/linux-headers" > > -apt-get install -y -o Debug::pkgProblemResolver=yes --no-install-recommends \ > - ${KBUILD_DEPENDS} > +# Lock-protected because apt and dpkg do not wait in case of contention > +flock /dpkg.lock \ > + apt-get install -y -o Debug::pkgProblemResolver=yes \ > + --no-install-recommends ${KBUILD_DEPENDS} The same stuff as in "meta/recipes-devtools/buildchroot/files/build.sh", but different style. Can we keep things similar as much as possible? Why not ( ... ) 42>/dpkg.lock ? Alex