From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7259987580358230016 X-Received: by 2002:a2e:8496:0:b0:2b6:df23:2117 with SMTP id b22-20020a2e8496000000b002b6df232117mr1173364ljh.43.1690369174088; Wed, 26 Jul 2023 03:59:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:46d2:b0:3fb:422d:5005 with SMTP id q18-20020a05600c46d200b003fb422d5005ls47741wmo.2.-pod-prod-01-eu; Wed, 26 Jul 2023 03:59:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlGWZjjjhDpq4kOSISMZyP2FgrD9kF1GRpN4QhhY17wSV5u23FyC7fupFvKd4cPYIN+Tvw45 X-Received: by 2002:a05:6000:128f:b0:315:ade6:a52d with SMTP id f15-20020a056000128f00b00315ade6a52dmr1108874wrx.19.1690369172485; Wed, 26 Jul 2023 03:59:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690369172; cv=pass; d=google.com; s=arc-20160816; b=ucdRYb8u1Heup1+FeVvis29wDXHcPEiphf8mClap7r37enOmpLep2kaXAoF3viMhEE iuSUtp54HV3EPz4l+BMWYlzCfpk5MGNMta6j3vR8/CH5qswxB+80Nqq80GyDbmcItaAO KlG5Nbz8EkAiJNTHGqa0IQD0IWlLd0PXvgQKEvlRjH1bwANdSlKVFLvoiuCR+Le6Ock4 NCYn0LZIyMPUFmFl1NnX+Cw2zIiA0FUPQdkEhpzjhdbRBFt4Fr4SjiQNHKFQ689AZhIc VbsFt8bpdm0zqA5n0Mt7E6SaWJxc8z1OjPJh1vtIH7PKAc+aOhkbAPwyAF60xiQsVho/ CNNg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=8E9cM+x5uH1swYmD1E5wFbLcZbLhVimb+VaSONjQp0k=; fh=SO2BlidHVJZ3BaksvfmFMblhxrBB44z0hoy/rPjWxoM=; b=tIS5Ibtt02HlyqTbdFafw5jReGoReUk9gcjLk5K+1MMtHZOis8X/vVv3Hula0qxVv5 mYXXHIuxRRor5WjdN2A11/Tu3mMG9LLwBvtyOwLt9EB7zVjkGih7KNCxW9H1NZnJMDY8 Vzq4QD/eSINu+1XEmLctKOFanVVoDfJtyPcOuz9LVPQMSwm8HjVw0mQRIGCgMevNS+0f S6WZ9Ze0zowO6xF9vYsuSBG/VIwXanc4YiV1Ipnp0KqkVBScFQKil1GRerSs0whhTOc7 kEwI24somOrtnHiLo3KJQU7gyGYAdSfQS33+Mkcgk19wqMwc4yt8L+SBAeKFl1CIroJn HyXw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="q0w/8H4G"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 2a01:111:f400:7d00::623 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20623.outbound.protection.outlook.com. [2a01:111:f400:7d00::623]) by gmr-mx.google.com with ESMTPS id bq4-20020a5d5a04000000b0031770ca0886si209592wrb.2.2023.07.26.03.59.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2023 03:59:32 -0700 (PDT) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 2a01:111:f400:7d00::623 as permitted sender) client-ip=2a01:111:f400:7d00::623; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="q0w/8H4G"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 2a01:111:f400:7d00::623 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOZJhbDXV3ozZXE96+aGnhypNfQ2uwE0TXCJFbOWd+R01BYzw0gftc2tWtWaeegTiSIBGx6LuHpduj4UWoYm7WmHA2jEaDDk/jEpxXriC7bCIDyLrxto1pv4eBSXEUTHuOstMNLaMCE1BpTi/hIwbvCAGi12BQXCARUuqR7GP5++fEycOtUOTmjP0vMOxc4bEqm+q0TOTz+HL9OQPvZSYcUqSgXZE41SY9Hrt9zjmiEnVoxCpkaEPAM3nqBlMSJGmICAsKqNmKyA3KvHUzXyN5Jpr9cjLaYrn1++x5UvCpbay8W4nKguCtZUKtKth21/Ln2Tct0+flHU/WNlu8U+bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8E9cM+x5uH1swYmD1E5wFbLcZbLhVimb+VaSONjQp0k=; b=YRUyH0xF5KybpCcZ3G88rx9S3C3df0PV4OABQ4XnHyrxvoT3k+Lf+TaVmBdVe5M6eFxg6bZ6xuXn2ZupQF1fLNTkWPMSRCnLboG8yZpYhvEdDsoTAL81BawSdySU82V7rHY4mMIXObApdOm3W29DImkJtzBPZfb8BqKlslDCGqcTJI+swonLy241fZzu8b+kkz+rr39PuXvdzrMYpgTspydCzdJrfNBGOq5RAARTwvzl6mStlD8jJZoGA4bENnEAdGZDK9Iuu9JA+zZy6xLBI9xID+1i0Q2ZqF+gnUF1ShxnL7P5i1NU7cv1m48B5yLNGjIyb0CGJK3ah7m9WXnPpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8E9cM+x5uH1swYmD1E5wFbLcZbLhVimb+VaSONjQp0k=; b=q0w/8H4GR/SMGalSMwDjkQioK1pCtbSeB/gKaEAs5zw9IPnKtriHIH3a+SciVwTumrQECp7xWfoEsoCaYbQBNSXt2RDBnGdL+1CNQyo98mk1Z9Nfhc3kM+5nsIHfERE8YYS4ro1f0QmRS0UGWNzVs7+5ipU6llJ0hSuf+yp4so7+X8WY7rFm+ikddcv9z1YY4DfUdGSLt/KEh9jMqlMniDpGECWFl6COvGSkU8nGim9fDHXQURUdkbav56NPk/RRxDNYNoWkuLPyVE3bkleqBrFDITpsWdYHE4VH+1FjTjJlCfA5i9k9BRIfBqafb1CH1+joeWzByRvFAvdcRKTMBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM9PR10MB4085.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1f9::22) by DB9PR10MB5234.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:33d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 10:59:30 +0000 Received: from AM9PR10MB4085.EURPRD10.PROD.OUTLOOK.COM ([fe80::90a8:2018:8363:8691]) by AM9PR10MB4085.EURPRD10.PROD.OUTLOOK.COM ([fe80::90a8:2018:8363:8691%7]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 10:59:29 +0000 Message-ID: <4e818215-2824-30f3-d638-acfabd700652@siemens.com> Date: Wed, 26 Jul 2023 12:59:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/1] fix group splitting in user creation Content-Language: en-US, de-DE To: isar-users@googlegroups.com References: <20230726045920.1542471-1-felix.moessbauer@siemens.com> From: Gylstorff Quirin In-Reply-To: <20230726045920.1542471-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR08CA0027.namprd08.prod.outlook.com (2603:10b6:610:33::32) To AM9PR10MB4085.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1f9::22) Return-Path: quirin.gylstorff@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR10MB4085:EE_|DB9PR10MB5234:EE_ X-MS-Office365-Filtering-Correlation-Id: b60dbd4d-ddff-4a2a-2bf4-08db8dc7629e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vkM9FoiEB1FMXvoSPqTTqqkIuYEAC0EY7YrCn/5PIAmuqn50QWhQ4DEBHcn0AeFJP7ylazj9TYhqC2BcMkZfZdvMI8wmV+LdbNNwNn3LcylyvmLnaWr15fAbW1rsJYh+iAlChBFHUCkIN+1dUXDS192QDh5PUhqQ3s/7CUzh085K7W1sJGpskXjr4xfIokalZQz1mkrBB+f26NEYHOxw/MFfcbKJw1PUvoD3QfGinq//QJJbvCe8EcHS/iHPmGlQdnYBqHTUH/Jm/g/00mh8mB9B6uQS4uM1y/NY3yKktv8Oc1Bwr3p+l6c5I2Y9UOkmI6mUYAPe6NpOk4XaV8SrqmQjoOy0AVT3XQAXyEfTc+E4hc3zSGcxT/hviY0OyRVE7PQs5T2LTIkI+gVjlteQ+M9SAUlgVfZfAWoiNL50gPztX4mUQlq1KTSSvatWuhUHQEcor+jE1T9wpR2vCA088e7oWiTv95FFRzHPNazNF3AY+kKYHZWEijv3/imG9lyMctODfBqLjRc2b1qxSEJ7agBv+i7n9VXtozJwgXjx0I9j3FqVyAjZDfJYVlDQC1h4l3eNRNRi8FMIgKL1+a5xBiuBjEiLyKyOPRI8F/Ha3PhphRcaMeo+QcE6gQ4MU2kGmzpQKt8yDxlhqrP5s7e2AQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4085.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199021)(31686004)(6486002)(2616005)(6666004)(478600001)(6512007)(6506007)(83380400001)(31696002)(86362001)(36756003)(316002)(53546011)(26005)(2906002)(186003)(66476007)(82960400001)(38100700002)(66946007)(8676002)(41300700001)(8936002)(6916009)(66556008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVNLcWE2SFpSRXYwUXRSQVZUR1FuQy9EUHZxczg0SGFwelRuYnZNYW5zQlMv?= =?utf-8?B?cjF3SVFkWG1xM3FjVkx4TWJNam9hT3AvTy9MYzlzaUZ5dXlnMXpldVljNUF6?= =?utf-8?B?RHNzL1FsUDRyQmFBRHg3T0ZDcDBIaUdZUWwvcll1SVQ5eWp5YXhIcnF6MDds?= =?utf-8?B?OUV0SDZFNWdoYVpBK0Q1K1BpbHJoR0E3SUlCNE9HQm5Ra1d2VThBNW14OGVJ?= =?utf-8?B?UjlkcnY0S3BpOTNOdEc0ajhsOFBiRVJUcFF0WmZkUjZMNS9PRTNaZXR3UnlZ?= =?utf-8?B?MmxuTjJUbWgwZEloYzRENDA3dXlZeTRzWnJZRUxkeTFJa0x2b2VVSE82WVFv?= =?utf-8?B?ajRSNHd1cnVvK3pTalVVNmlZcDFwblRWVUUzelFsOStBR25zaGdUN2hKd0RH?= =?utf-8?B?S3d4QklnNEcwcWpJQUNDb2RvekhMNFdjSGtBNVhFU0g3b0l6cCtCSEZyUXRZ?= =?utf-8?B?VHRHbEd1NFFzdWZ6UjVUM2xla2ZQVkVoZGxVWkpTWFZtUVJGY0ZqNWZjUkl5?= =?utf-8?B?OE5JSHVNU3BsRzl3RkdnRk1qWEs3YTBQSEhCU1E1cVlVMzlKTGd3a0dOSnFT?= =?utf-8?B?aFdxV2RPYldUYjZTVW1kZmMvdlNtMjdZQ0N1VU1CbXIvSVl0R2dTUFBreFV5?= =?utf-8?B?dTJYVGJoOGE4eW1meTNPclpTdmpoLytqU2NmM3IxZHB6RktYQ2VGeFJ0Kys0?= =?utf-8?B?Qnoyc29pT1hiSnA4VCs0emRDTG9zSDM0Z2tadlRYZTNMV3k3M1MyeDNaZSs1?= =?utf-8?B?VnJjZ1NmZCs2VlJxL1VkM1llbFAveGxOTDA3Z01VRFNaZVVqTndWU3ZSNzdG?= =?utf-8?B?RUxZcWk2aEZWKzRjMjdUR0FkaElzWU5MUVYzc3ZFbmhBUEYydFp4dnkxR1lK?= =?utf-8?B?RUQrSEw5alVnL29SUGhXM2NTRGtsZzhvZi92Vi94N2JBUTR6enQwejRqS2sx?= =?utf-8?B?NzVyVVgyNEhKa25uNHJSa2ZGQUM1VTRDbnlEaGVYQlRCb0xjc21GdmVOMWZZ?= =?utf-8?B?am96eis2Tzhzdi9pKzVmZFdab09zL0dJaXdNY1o1RnVzaUhoVjltTXhjQ1dR?= =?utf-8?B?d21vSmNvdlBsSWNIWjhQVEdaL3JyUWVBbVE0Y3dPcVQxd3lYcDhkeWpseDB0?= =?utf-8?B?NE9KT2xKN1R5QlltOFRsR3R6Mk1pUmZBS2RrNHNsd1VDN2JkUkd4RUdVZXNR?= =?utf-8?B?VjFjazFNdU0raDZTUndjWDFDZjBoOFhWOVBIUW8xd0xvempFOEhFcnhCTWNm?= =?utf-8?B?L1F2Y3FrRW83Q0dDZ1I2dnlPRW84TUZPdlZPM2FzdlNkdVF5MHlJaXArcVla?= =?utf-8?B?YXlSRG4wUGZiMjZNSHhqQXl6Ymg2NkkxbTRPVWIrYlpuNjRPamVEdHBuRE9H?= =?utf-8?B?Y2pYNFkwZXpkbDJSeUhWdEpIU0RJNlpPNEV6eG1tLzZpeG8rT3ROemJVaVhu?= =?utf-8?B?eWZtR0tjSlMzcWw5d1dsMk1kK3hFaHlZdEtpeDNsazRDRGZUTStVSG1CMmhU?= =?utf-8?B?ZWQxYkJhRDlKOU41RHgwb0VHQi9mVTVnc09SVTI0dDJDL05WRlRadW42ZG5C?= =?utf-8?B?R3BLR1I5SkJmR0JHMTA1MnJoNnF3TXFQZFhuYXIwa0x3Wkh5NFJna3QyUFlR?= =?utf-8?B?UWdtYUNCekNkdWl0Mjh1c3NMWFI5Uy8yTVhlY21JMUlRcS9ORHZXNHQ4UWlS?= =?utf-8?B?U3IyTmhHUjlKSDgwS00xblNzVW9senpqSmFJaGpxeDNQQ2dCaVlJOWVrWnk4?= =?utf-8?B?Vm1yWjY4ZzM1dHpGMFB4OXc0MlIyV3g3TUhkMzczVXV1Qy91VktPWVphUmFN?= =?utf-8?B?T2UxNFJEZ1VaRXRIZWw4M1RKVFhDMlV2bHBTNjBNZy9Ed2hMWE42SGovaVlq?= =?utf-8?B?NjJpTCsrTDB2Z1d5RjZhRHRFWmh3SUhwSUtjSUpGejgvMWFDNDlxQzBnd3p2?= =?utf-8?B?UVVITzQwTjZIMmcvVHY1Nm00SWRaZXIwMGpEYVJpeTlsOFRzWm8yRjNDZlVk?= =?utf-8?B?WTJYQ1BPa3IxdC82WHpYemNqTXNmaEN3cC9PVmZqR3hYZXk0dkhNKzZEdEln?= =?utf-8?B?dXFVMVFIODBHYlFCdllueGhQMkdpRm8yb1E3eHd0aW9KcjYwWDkwcDI4QWxw?= =?utf-8?B?cTQrZUVzWnFNUTlVd3VSN2JuM21FbjNReFFUb0dRWkIyV04xZU12NGRIQkJP?= =?utf-8?B?WVE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: b60dbd4d-ddff-4a2a-2bf4-08db8dc7629e X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4085.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 10:59:29.8257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PCrZlwngX+huolAiVkoFK5aNJRTx5ergVkcxUUwb/u15Zk6R6A0HoBAkmkdzTtH1Q5W5eckU4OgHesuvXDVp/dvM1xwvx7LUBUanV8dQ70w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB5234 X-TUID: muZmOm8pQsD1 On 7/26/23 06:59, 'Felix Moessbauer' via isar-users wrote: > There is a bug when converting the USER_[groups] configuration > from the bitbake format (space separated) to the format useradd > expects (comma separated). We cannot simply replace spaces with commas, > as then multiple spaces in a row would create multiple commas. Instead, > we need to split it first into the tokens and then join these tokens by > comma. > > Signed-off-by: Felix Moessbauer > --- > meta/classes/image-account-extension.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/image-account-extension.bbclass b/meta/classes/image-account-extension.bbclass > index e783c135..6f67f459 100644 > --- a/meta/classes/image-account-extension.bbclass > +++ b/meta/classes/image-account-extension.bbclass > @@ -98,10 +98,10 @@ def image_create_users(d: "DataSmart") -> None: > add_user_option("--comment", "comment") > add_user_option("--shell", "shell") > > - groups = d.getVarFlag(user_entry, "groups") or "" > + groups = (d.getVarFlag(user_entry, "groups") or "").split() > if groups: > args.append("--groups") > - args.append(groups.replace(' ', ',')) > + args.append(','.join(groups)) > > flags = (d.getVarFlag(user_entry, "flags") or "").split() > I haved tested the patch. Looks good to me. Is it possible to add unittest for this? Quirin