From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Badrikesh Prusty <badrikesh.prusty@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no"
Date: Mon, 3 Nov 2025 07:03:57 +0100	[thread overview]
Message-ID: <4f317fc2-33e8-4dc8-84d2-53256beb06a4@siemens.com> (raw)
In-Reply-To: <d1d3cbc9-1fc8-4b79-b58e-cdbde00aef58n@googlegroups.com>
On 01.11.25 21:06, 'Badrikesh Prusty' via isar-users wrote:
>> ...but your change now sets it to no by default for all Debian releases,
>> not just trixie.
> 
> Yes, this change sets "no" for all releases, making older Debian
> versions consistent with the modern dpkg default on Trixie and later,
> non-root builds across all releases.  I’ll send patch v2 with an
> improved commit description.
But you don't explain why this should be correct. Bookworm and older
should be be built with its past defaults. If the defaults should
actually depend on the host's sbuild version (waiting for a proof), then
you need to take that one as decision input. Unconditionally flipping
defaults is very very likely just wrong.
Jan
-- 
Siemens AG, Foundational Technologies
Linux Expert Center
-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/4f317fc2-33e8-4dc8-84d2-53256beb06a4%40siemens.com.
     prev parent reply	other threads:[~2025-11-03  6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-25 16:57 'Badrikesh Prusty' via isar-users
2025-10-27 16:07 ` 'Jan Kiszka' via isar-users
2025-11-01 20:06   ` 'Badrikesh Prusty' via isar-users
2025-11-03  6:03     ` 'Jan Kiszka' via isar-users [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=4f317fc2-33e8-4dc8-84d2-53256beb06a4@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=badrikesh.prusty@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox