[PATCH] debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no"

[PATCH] debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no"

['Badrikesh Prusty' via isar-users]

From: badrikesh prusty <badrikesh.prusty@siemens.com>

With DEBIAN_RULES_REQUIRES_ROOT set to "no" by default, building Debian
packages no longer requires root privileges.

In dpkg version ≥ 1.22.13 (present in Debian Trixie), the default value
is "no". In earlier dpkg versions (used in Debian Bookworm and before)
the default value of Rules-Requires-Root was "binary-targets".

This ensures modern dpkg compatibility and safe, non-root builds for
older Debian versions, unless explicitly overridden.

Fixes: https://github.com/ilbers/isar/issues/113
Signed-off-by: badrikesh prusty <badrikesh.prusty@siemens.com>
---
 meta/classes/debianize.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
index 1f54e8f9..ad9e1a0d 100644
--- a/meta/classes/debianize.bbclass
+++ b/meta/classes/debianize.bbclass
@@ -18,7 +18,7 @@ DEBIAN_BUILT_USING ??= ""
 DEBIAN_MULTI_ARCH ??= "no"
 DEBIAN_COMPAT ??= "10"
 DEBIAN_CHANGELOG_TIMESTAMP ??= "3600"
-DEBIAN_RULES_REQUIRES_ROOT ??= ""
+DEBIAN_RULES_REQUIRES_ROOT ??= "no"
 DESCRIPTION ??= "must not be empty"
 MAINTAINER ??= "Unknown maintainer <unknown@example.com>"
 
-- 
2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251025165759.32388-1-badrikesh.prusty%40siemens.com.

Re: [PATCH] debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no"

['Jan Kiszka' via isar-users]

On 25.10.25 18:57, 'Badrikesh Prusty' via isar-users wrote:
> From: badrikesh prusty <badrikesh.prusty@siemens.com>
> 
> With DEBIAN_RULES_REQUIRES_ROOT set to "no" by default, building Debian
> packages no longer requires root privileges.
> 
> In dpkg version ≥ 1.22.13 (present in Debian Trixie), the default value
> is "no". In earlier dpkg versions (used in Debian Bookworm and before)
> the default value of Rules-Requires-Root was "binary-targets".

...but your change now sets it to no by default for all Debian releases,
not just trixie.

Jan

> 
> This ensures modern dpkg compatibility and safe, non-root builds for
> older Debian versions, unless explicitly overridden.
> 
> Fixes: https://github.com/ilbers/isar/issues/113
> Signed-off-by: badrikesh prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes/debianize.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
> index 1f54e8f9..ad9e1a0d 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -18,7 +18,7 @@ DEBIAN_BUILT_USING ??= ""
>  DEBIAN_MULTI_ARCH ??= "no"
>  DEBIAN_COMPAT ??= "10"
>  DEBIAN_CHANGELOG_TIMESTAMP ??= "3600"
> -DEBIAN_RULES_REQUIRES_ROOT ??= ""
> +DEBIAN_RULES_REQUIRES_ROOT ??= "no"
>  DESCRIPTION ??= "must not be empty"
>  MAINTAINER ??= "Unknown maintainer <unknown@example.com>"
>  

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/f9666528-693c-4732-a10f-2937bd491cd7%40siemens.com.

Re: [PATCH] debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no"

['Badrikesh Prusty' via isar-users]

[-- Attachment #1.1: Type: text/plain, Size: 719 bytes --]

> ...but your change now sets it to no by default for all Debian releases,
> not just trixie.

Yes, this change sets "no" for all releases, making older Debian versions 
consistent with the modern dpkg default on Trixie and later, non-root 
builds across all releases.  I’ll send patch v2 with an improved commit 
description.

Thanks,
Badrikesh

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/d1d3cbc9-1fc8-4b79-b58e-cdbde00aef58n%40googlegroups.com.

[-- Attachment #1.2: Type: text/html, Size: 1167 bytes --]

Re: [PATCH] debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no"

['Jan Kiszka' via isar-users]

On 01.11.25 21:06, 'Badrikesh Prusty' via isar-users wrote:
>> ...but your change now sets it to no by default for all Debian releases,
>> not just trixie.
> 
> Yes, this change sets "no" for all releases, making older Debian
> versions consistent with the modern dpkg default on Trixie and later,
> non-root builds across all releases.  I’ll send patch v2 with an
> improved commit description.

But you don't explain why this should be correct. Bookworm and older
should be be built with its past defaults. If the defaults should
actually depend on the host's sbuild version (waiting for a proof), then
you need to take that one as decision input. Unconditionally flipping
defaults is very very likely just wrong.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/4f317fc2-33e8-4dc8-84d2-53256beb06a4%40siemens.com.