From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH 4/6] dkpg-base: Clarify dependency logic between package recipes
Date: Sun, 2 Sep 2018 18:04:38 +0200 [thread overview]
Message-ID: <4fe5c52f7c005d9508a7d15341fca2592a17df9c.1535904280.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1535904280.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1535904280.git.jan.kiszka@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
No functional change, just reordering and comment enhancement.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/classes/dpkg-base.bbclass | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 84c56af..6299ef8 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -3,6 +3,8 @@
ISAR_CROSS_COMPILE ??= "0"
+DEPENDS ?= ""
+
# Add dependency from the correct buildchroot: host or target
python __anonymous() {
mode = d.getVar('ISAR_CROSS_COMPILE', True)
@@ -30,10 +32,6 @@ do_adjust_git[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
inherit patch
addtask patch after do_adjust_git before do_build
-# Add dependency between Isar recipes
-DEPENDS ?= ""
-do_prepare[deptask] = "do_deploy_deb"
-
def get_package_srcdir(d):
s = d.getVar("S", True)
workdir = d.getVar("WORKDIR", True)
@@ -85,6 +83,9 @@ do_prepare() {
addtask prepare after do_patch before do_build
do_prepare[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
+# If Isar recipes depend on each other, they typically need the package
+# deployed to isar-apt
+do_prepare[deptask] = "do_deploy_deb"
# Placeholder for actual dpkg_runbuild() implementation
dpkg_runbuild() {
--
2.16.4
next prev parent reply other threads:[~2018-09-02 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 16:04 [PATCH 0/6] dpkg class refactorings, API changelog, fixes Jan Kiszka
2018-09-02 16:04 ` [PATCH 1/6] linux-custom: Add missing proxy settings to prepare task Jan Kiszka
2018-09-02 16:04 ` [PATCH 2/6] linux-module: Run depmod for installed kernel versions Jan Kiszka
2018-09-02 16:04 ` [PATCH 3/6] dpkg-base: Relocate dpkg_runbuild and adjust comments Jan Kiszka
2018-09-02 16:04 ` Jan Kiszka [this message]
2018-09-02 16:04 ` [PATCH 5/6] dpkg, linux-custom: Split dependency installation from build preparations Jan Kiszka
2018-09-02 16:04 ` [PATCH 6/6] Add changelog for the recipe API Jan Kiszka
2018-09-02 16:13 ` [PATCH 0/6] dpkg class refactorings, API changelog, fixes Jan Kiszka
2018-09-10 9:37 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe5c52f7c005d9508a7d15341fca2592a17df9c.1535904280.git.jan.kiszka@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox