* [PATCH] images: Complete account related exceptions in do_rootfs_quality_check
@ 2023-02-10 19:19 Jan Kiszka
2023-02-10 19:45 ` Henning Schild
2023-02-16 4:38 ` Uladzimir Bely
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2023-02-10 19:19 UTC (permalink / raw)
To: isar-users; +Cc: Quirin Gylstorff, Henning Schild
From: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/classes/image.bbclass | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 539ec51d..ef7d5a2a 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -482,10 +482,12 @@ do_rootfs_quality_check() {
args="${args} ! -path ${ROOTFSDIR}/etc/passwd \
! -path ${ROOTFSDIR}/etc/subgid \
! -path ${ROOTFSDIR}/etc/subuid \
- ! -path ${ROOTFSDIR}/etc/shadow- \
! -path ${ROOTFSDIR}/etc/gshadow \
+ ! -path ${ROOTFSDIR}/etc/gshadow- \
! -path ${ROOTFSDIR}/etc/shadow \
- ! -path ${ROOTFSDIR}/etc/group"
+ ! -path ${ROOTFSDIR}/etc/shadow- \
+ ! -path ${ROOTFSDIR}/etc/group \
+ ! -path ${ROOTFSDIR}/etc/group-"
;;
esac
done
--
2.35.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] images: Complete account related exceptions in do_rootfs_quality_check
2023-02-10 19:19 [PATCH] images: Complete account related exceptions in do_rootfs_quality_check Jan Kiszka
@ 2023-02-10 19:45 ` Henning Schild
2023-02-16 4:38 ` Uladzimir Bely
1 sibling, 0 replies; 3+ messages in thread
From: Henning Schild @ 2023-02-10 19:45 UTC (permalink / raw)
To: Jan Kiszka; +Cc: isar-users, Quirin Gylstorff
Kind of hard to read what was changed and the commit message is also
not too verbose. I think i get it so ACK.
But i would suggest to sort that list in a p1 alphabetically ... no
change just sort.
And later do the real change in a p2.
You sort and add in one patch, which makes it hard to review.
Henning
Am Fri, 10 Feb 2023 20:19:03 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/classes/image.bbclass | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 539ec51d..ef7d5a2a 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -482,10 +482,12 @@ do_rootfs_quality_check() {
> args="${args} ! -path ${ROOTFSDIR}/etc/passwd \
> ! -path ${ROOTFSDIR}/etc/subgid \
> ! -path ${ROOTFSDIR}/etc/subuid \
> - ! -path ${ROOTFSDIR}/etc/shadow- \
> ! -path ${ROOTFSDIR}/etc/gshadow \
> + ! -path ${ROOTFSDIR}/etc/gshadow- \
> ! -path ${ROOTFSDIR}/etc/shadow \
> - ! -path ${ROOTFSDIR}/etc/group"
> + ! -path ${ROOTFSDIR}/etc/shadow- \
> + ! -path ${ROOTFSDIR}/etc/group \
> + ! -path ${ROOTFSDIR}/etc/group-"
> ;;
> esac
> done
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] images: Complete account related exceptions in do_rootfs_quality_check
2023-02-10 19:19 [PATCH] images: Complete account related exceptions in do_rootfs_quality_check Jan Kiszka
2023-02-10 19:45 ` Henning Schild
@ 2023-02-16 4:38 ` Uladzimir Bely
1 sibling, 0 replies; 3+ messages in thread
From: Uladzimir Bely @ 2023-02-16 4:38 UTC (permalink / raw)
To: isar-users, Jan Kiszka
In the email from Friday, 10 February 2023 22:19:03 +03 user Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/classes/image.bbclass | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 539ec51d..ef7d5a2a 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -482,10 +482,12 @@ do_rootfs_quality_check() {
> args="${args} ! -path ${ROOTFSDIR}/etc/passwd \
> ! -path ${ROOTFSDIR}/etc/subgid \
> ! -path ${ROOTFSDIR}/etc/subuid \
> - ! -path ${ROOTFSDIR}/etc/shadow- \
> ! -path ${ROOTFSDIR}/etc/gshadow \
> + ! -path ${ROOTFSDIR}/etc/gshadow- \
> ! -path ${ROOTFSDIR}/etc/shadow \
> - ! -path ${ROOTFSDIR}/etc/group"
> + ! -path ${ROOTFSDIR}/etc/shadow- \
> + ! -path ${ROOTFSDIR}/etc/group \
> + ! -path ${ROOTFSDIR}/etc/group-"
> ;;
> esac
> done
Applied to next, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-16 4:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10 19:19 [PATCH] images: Complete account related exceptions in do_rootfs_quality_check Jan Kiszka
2023-02-10 19:45 ` Henning Schild
2023-02-16 4:38 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox