Re: [URGENT][PATCH v2 0/2] Correctly determine kernel and initrd versions

[Alexander Smirnov <asmirnov@ilbers.de>]

On 10/19/2017 07:08 PM, Henning Schild wrote:
> On Thu, 19 Oct 2017 18:00:51 +0200
> "[ext] Henning Schild" <henning.schild@siemens.com> wrote:
> 
>> On Wed, 18 Oct 2017 16:06:40 +0200
>> "[ext] Henning Schild" <henning.schild@siemens.com> wrote:
>>
>>> I have not tested these patches, but they look good to me. The whole
>>> readlink thing is not too important.
>>
>> Just tested them and they break wic because the two variables are not
>> part of any config. Would require the eval(bitbake) stuff that is done
>> in start_vm. Probably not the best idea to do that over and over,
>> maybe the code should append that to local.conf or write it to a file
>> that everyone can read.
>>
>> Why are they on top of next in git and not on master? Would the urgent
>> not suggest we should test them on top of master and take them on the
>> fast lane before next?
>>
>> Setting the two guys back to what they where in multiconfig does not
>> work because the code would now look for /vmlinuz-4.9....
>>
>> Setting them to "boot/vmlinuz-4.9..." creates wic trouble again.
>>
>> I think a wic use-case needs to be added to CI, but since wic is not
>> integrated in bitbake i am afraid i can not send patches because the
>> change needs to happen in your CI.

Good idea, thanks.

Alex

> 
> All that being said, go ahead and merge them to master. If wic is not
> part of CI, wic users can carry fixes for the new issues in their
> branches for now.
> 
> Henning
> 
>> Henning
>>
>>> Henning
>>>
>>> On Tue, 17 Oct 2017 22:23:06 +0300
>>> Alexander Smirnov <asmirnov@ilbers.de> wrote:
>>>    
>>>> Hello all,
>>>>
>>>> IMPORTANT: lets try to review this series ASAP, becuase Isar build
>>>> is broken again due to recent update of Raspbian kernel version in
>>>> apt. Instead of yet-another-version update I'd like to commit
>>>> proper solution.
>>>>
>>>> In current Isar implementation, multiconfig file contains
>>>> hardcoded version for boot files: kernel and initrd. This is used
>>>> for both:
>>>>
>>>>   - Add respective package to multistrap config.
>>>>   - Copy boot files to deploy directory.
>>>>
>>>> This series drops this hardcoded versions, so now Isar is able to
>>>> determine version of boot files during building.
>>>>
>>>> Changes since v1:
>>>>   - Differentiate 'do_copy_boot_files' stamps.
>>>>   - Update start_vm script accordingly.
>>>>   - Check if symlinks 'vmlinuz' and 'initrd.img' exist before
>>>> reading them. If symlink doesn't exist, this function skips it.
>>>>
>>>> With best regards,
>>>> Alex
>>>>
>>>>
>>>> *** BLURB HERE ***
>>>>
>>>> Alexander Smirnov (2):
>>>>    meta-isar: Drop hardcoded kernel versions
>>>>    meta-isar: Rework boot files copying
>>>>
>>>>   meta-isar/conf/multiconfig/qemuamd64-jessie.conf  |  5 +----
>>>>   meta-isar/conf/multiconfig/qemuamd64-stretch.conf |  5 +----
>>>>   meta-isar/conf/multiconfig/qemuarm-jessie.conf    |  5 +----
>>>>   meta-isar/conf/multiconfig/qemuarm-stretch.conf   |  5 +----
>>>>   meta-isar/conf/multiconfig/qemuarm-wheezy.conf    |  5 +----
>>>>   meta-isar/conf/multiconfig/qemui386-jessie.conf   |  5 +----
>>>>   meta-isar/conf/multiconfig/qemui386-stretch.conf  |  5 +----
>>>>   meta-isar/conf/multiconfig/rpi-jessie.conf        |  3 ---
>>>>   meta/classes/ext4-img.bbclass                     |  8 --------
>>>>   meta/classes/image.bbclass                        | 24
>>>> ++++++++++++++++++++---
>>>> scripts/start_vm                                  |  8 ++++++-- 11
>>>> files changed, 34 insertions(+), 44 deletions(-)
>>>>      
>>>    
>>
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov