From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6477538949418975232 X-Received: by 10.46.91.65 with SMTP id p62mr106072ljb.29.1508440733365; Thu, 19 Oct 2017 12:18:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.18.153 with SMTP id 25ls1145450ljs.6.gmail; Thu, 19 Oct 2017 12:18:52 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TNNC5eMEVreQ4BfenUe9i2FsMV4oUrzupyxaCqAHVZfRCigYWNHLDYtDKticVJjvp+IJL1 X-Received: by 10.25.193.214 with SMTP id r205mr83972lff.21.1508440732697; Thu, 19 Oct 2017 12:18:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508440732; cv=none; d=google.com; s=arc-20160816; b=YFBjI6g/Uo6g4dmscjTckQpFloV7PmkpEQF3nMRQ3IDYME+4w0S3qXurL8snS7OGFq YjLyCi/CCYdxYPN6iiQR84OQXAr1znXDYm3HxTRAwm7NS5wA0mvbzzygL/iHPnWc+dsd yGl7o1QnvyovREbXZr4iS8ykCKIZib/hJux0cO0REXEmU6K7mKQBxQpWHE4VIeGPL7Z9 yjGbrzwx6mR8YfkinR2btjrTXQFz71GnICN0PZyfkzfSGY/l7xIfuAYPFgLD/ITIBHtG ZkpzVdOqppHG0PWWqj7DwGeg0MEsqJsLFx57BsqvC9LK2G6XhHwtjjgsUmwWQr+UxFxM +AYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=niMf9eHQSVgDNEnsbIinm1JdCIBzWHFt7KAyd1+CIGo=; b=tr9EEXUKCv9KoKkZ7tBsHmTaroa9rNjgGMUr+EvbsiLLifJnvSASdyMBsmC5h7N74e c5c7PF5quMPpZKBQNGcXy8ahl4rcaeu4JMsSVxtkha3nR9BhaOHUFfhorz5PGTeCtUr/ q4BjnIx/UL+jtyy+0mYENadziivHTdApCibGeYk+Xl5aMRDDHRAHc4w+RselG+/qDbop Q8u2kPuiLupTF0h1s78ds4PZLus3NZ8ONVro34dqw+rpdO73tZPJ9HaqKr8oQMMhOdct KMUpoTsrrIx22QD+qH3ttbY6asilUpY8R0beCkVhBTR38zGNYSsaJ+LP8wHQw7onRSKF P0Cg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id 72si567882ljf.5.2017.10.19.12.18.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 12:18:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v9JJImhd028114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 19 Oct 2017 21:18:50 +0200 Subject: Re: [URGENT][PATCH v2 0/2] Correctly determine kernel and initrd versions To: Henning Schild Cc: isar-users@googlegroups.com References: <20171017192308.3802-1-asmirnov@ilbers.de> <20171018160640.6b8f3beb@md1em3qc> <20171019180051.04ac5a52@md1em3qc> <20171019180819.02ccff13@md1em3qc> From: Alexander Smirnov Message-ID: <500b7044-8a78-e503-b6fa-76bbd2cb1433@ilbers.de> Date: Thu, 19 Oct 2017 22:18:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171019180819.02ccff13@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: g+dzCeEGUmkj On 10/19/2017 07:08 PM, Henning Schild wrote: > On Thu, 19 Oct 2017 18:00:51 +0200 > "[ext] Henning Schild" wrote: > >> On Wed, 18 Oct 2017 16:06:40 +0200 >> "[ext] Henning Schild" wrote: >> >>> I have not tested these patches, but they look good to me. The whole >>> readlink thing is not too important. >> >> Just tested them and they break wic because the two variables are not >> part of any config. Would require the eval(bitbake) stuff that is done >> in start_vm. Probably not the best idea to do that over and over, >> maybe the code should append that to local.conf or write it to a file >> that everyone can read. >> >> Why are they on top of next in git and not on master? Would the urgent >> not suggest we should test them on top of master and take them on the >> fast lane before next? >> >> Setting the two guys back to what they where in multiconfig does not >> work because the code would now look for /vmlinuz-4.9.... >> >> Setting them to "boot/vmlinuz-4.9..." creates wic trouble again. >> >> I think a wic use-case needs to be added to CI, but since wic is not >> integrated in bitbake i am afraid i can not send patches because the >> change needs to happen in your CI. Good idea, thanks. Alex > > All that being said, go ahead and merge them to master. If wic is not > part of CI, wic users can carry fixes for the new issues in their > branches for now. > > Henning > >> Henning >> >>> Henning >>> >>> On Tue, 17 Oct 2017 22:23:06 +0300 >>> Alexander Smirnov wrote: >>> >>>> Hello all, >>>> >>>> IMPORTANT: lets try to review this series ASAP, becuase Isar build >>>> is broken again due to recent update of Raspbian kernel version in >>>> apt. Instead of yet-another-version update I'd like to commit >>>> proper solution. >>>> >>>> In current Isar implementation, multiconfig file contains >>>> hardcoded version for boot files: kernel and initrd. This is used >>>> for both: >>>> >>>> - Add respective package to multistrap config. >>>> - Copy boot files to deploy directory. >>>> >>>> This series drops this hardcoded versions, so now Isar is able to >>>> determine version of boot files during building. >>>> >>>> Changes since v1: >>>> - Differentiate 'do_copy_boot_files' stamps. >>>> - Update start_vm script accordingly. >>>> - Check if symlinks 'vmlinuz' and 'initrd.img' exist before >>>> reading them. If symlink doesn't exist, this function skips it. >>>> >>>> With best regards, >>>> Alex >>>> >>>> >>>> *** BLURB HERE *** >>>> >>>> Alexander Smirnov (2): >>>> meta-isar: Drop hardcoded kernel versions >>>> meta-isar: Rework boot files copying >>>> >>>> meta-isar/conf/multiconfig/qemuamd64-jessie.conf | 5 +---- >>>> meta-isar/conf/multiconfig/qemuamd64-stretch.conf | 5 +---- >>>> meta-isar/conf/multiconfig/qemuarm-jessie.conf | 5 +---- >>>> meta-isar/conf/multiconfig/qemuarm-stretch.conf | 5 +---- >>>> meta-isar/conf/multiconfig/qemuarm-wheezy.conf | 5 +---- >>>> meta-isar/conf/multiconfig/qemui386-jessie.conf | 5 +---- >>>> meta-isar/conf/multiconfig/qemui386-stretch.conf | 5 +---- >>>> meta-isar/conf/multiconfig/rpi-jessie.conf | 3 --- >>>> meta/classes/ext4-img.bbclass | 8 -------- >>>> meta/classes/image.bbclass | 24 >>>> ++++++++++++++++++++--- >>>> scripts/start_vm | 8 ++++++-- 11 >>>> files changed, 34 insertions(+), 44 deletions(-) >>>> >>> >> > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov