public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Florian Bezdeka <florian.bezdeka@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>,
	"Q. Gylstorff" <Quirin.Gylstorff@siemens.com>,
	isar-users@googlegroups.com, jan.kiszka@siemens.com
Subject: Re: [PATCH v12 0/2] CPIO & OVA Images
Date: Fri, 25 Jun 2021 17:06:14 +0200	[thread overview]
Message-ID: <503d2985-38f4-d240-cc44-19e6401df96d@siemens.com> (raw)
In-Reply-To: <a5e94d28-51bf-6c48-4c91-d62abd589be4@ilbers.de>

Hi all,

On 25.06.21 13:30, Anton Mikanovich wrote:
> 18.06.2021 16:39, Q. Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> - Generate cpio images for rescue images
>> - generate ova images for VMWare & Virtualbox
> 
> Can you please add image_undo_mounts calls in all the functions using
> image_do_mounts?
> This requirement is not jet mentioned in documentation, but it is
> mandatory after the latest mount rebuild.
> 

Isn't that a performance killer doing mount/umount all the time?

I would expect a lot of recipes to break if we have to follow a new
pattern now. Can't that be done in a backward compatible manner like
locating the mount/umount inside "pre" and "post" tasks, so that recipes
can stay as they are?

If there is no way to do that in a backward compatible manner I would
vote for postponing the mount/umount refactoring to the next major release.

Best regards,
Florian

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

      reply	other threads:[~2021-06-25 15:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  8:32 [PATCH v11 " Q. Gylstorff
2021-04-22  8:32 ` [PATCH v11 1/2] meta/classes: Generate ova image for VMWare or Virtualbox Q. Gylstorff
2021-04-27 17:16   ` Henning Schild
2021-04-30 18:21     ` Jan Kiszka
2021-04-22  8:32 ` [PATCH v11 2/2] meta/classes: add cpiogz-img Q. Gylstorff
2021-05-31 10:33 ` [PATCH v11 0/2] CPIO & OVA Images Anton Mikanovich
2021-06-18 13:39   ` [PATCH v12 " Q. Gylstorff
2021-06-18 13:39     ` [PATCH v12 1/2] meta/classes: Generate ova image for VMWare or Virtualbox Q. Gylstorff
2021-06-18 13:39     ` [PATCH v12 2/2] meta/classes: add cpiogz-img Q. Gylstorff
2021-06-25 11:30     ` [PATCH v12 0/2] CPIO & OVA Images Anton Mikanovich
2021-06-25 15:06       ` Florian Bezdeka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503d2985-38f4-d240-cc44-19e6401df96d@siemens.com \
    --to=florian.bezdeka@siemens.com \
    --cc=Quirin.Gylstorff@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox