public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	<isar-users@googlegroups.com>
Subject: Re: [PATCH 3/5] prepend ccache wrappers in devshell
Date: Mon, 1 Aug 2022 17:00:18 +0200	[thread overview]
Message-ID: <5069ffbc-bc6e-b2f3-0ebf-532c526a2a49@siemens.com> (raw)
In-Reply-To: <20220801145719.546953-4-felix.moessbauer@siemens.com>

Reasoning / impact of this change is missing. Does it fix something?

Jan

On 01.08.22 16:57, Felix Moessbauer wrote:
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/dpkg-base.bbclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
> index ef04ef31..12d18592 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -311,6 +311,8 @@ python do_devshell() {
>      isar_export_proxies(d)
>      isar_export_ccache(d)
>      isar_export_build_settings(d)
> +    if d.getVar('USE_CCACHE') == '1':
> +        bb.build.exec_func('schroot_configure_ccache', d)
>  
>      schroot = d.getVar('SBUILD_CHROOT')
>      isar_apt = d.getVar('ISAR_APT_REPO')
> @@ -328,6 +330,7 @@ python do_devshell() {
>          echo {2} > /etc/apt/sources.list.d/isar_apt.list; \
>          apt-get -y -q update; \
>          {3}; \
> +        export PATH=$PATH_PREPEND:$PATH; \
>          $SHELL -i \
>      '"
>      oe_terminal(termcmd.format(schroot, pp_pps, isar_apt, install_deps), "Isar devshell", d)

-- 
Siemens AG, Technology
Competence Center Embedded Linux

  reply	other threads:[~2022-08-01 15:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 14:57 [PATCH 0/5] Improve debug infrastructure for build debugging Felix Moessbauer
2022-08-01 14:57 ` [PATCH 1/5] get architecture specific build deps for devshell Felix Moessbauer
2022-08-01 14:57 ` [PATCH 2/5] move CCACHE_DISABLE env var to function Felix Moessbauer
2022-08-01 14:57 ` [PATCH 3/5] prepend ccache wrappers in devshell Felix Moessbauer
2022-08-01 15:00   ` Jan Kiszka [this message]
2022-08-02  7:50   ` Felix Moessbauer
2022-08-01 14:57 ` [PATCH 4/5] do not warn on CCACHE related variables Felix Moessbauer
2022-08-01 14:57 ` [PATCH 5/5] allow to switch CCACHE_DEBUG mode from environment Felix Moessbauer
2022-08-10 11:32 ` [PATCH 0/5] Improve debug infrastructure for build debugging Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5069ffbc-bc6e-b2f3-0ebf-532c526a2a49@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox