[PATCH v2] fix: remove unneeded unconditional recipes

[PATCH v2] fix: remove unneeded unconditional recipes

[Silvano Cirujano Cuesta]

Commit 9c3499adf91 introduced the unconditional inclusion of the recipes
isar-exclude-docs and isar-disable-apt-cache, but they would only needed
for container images.

That would have been anyway an optimization with questionable demand,
therefore removing it.

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
---
 meta/classes/image-container-extension.bbclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass
index f693627..e26604a 100644
--- a/meta/classes/image-container-extension.bbclass
+++ b/meta/classes/image-container-extension.bbclass
@@ -6,7 +6,6 @@
 # This class extends the image.bbclass for containerizing the root filesystem.
 
 CONTAINER_FORMATS ?= "docker-archive"
-IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache"
 
 containerize_rootfs() {
     local cmd="/bin/dash"
-- 
2.30.2

Re: [PATCH v2] fix: remove unneeded unconditional recipes

[Jan Kiszka]

On 14.04.21 17:18, [ext] Silvano Cirujano Cuesta wrote:
> Commit 9c3499adf91 introduced the unconditional inclusion of the recipes
> isar-exclude-docs and isar-disable-apt-cache, but they would only needed
> for container images.
> 
> That would have been anyway an optimization with questionable demand,
> therefore removing it.
> 
> Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
> ---
>  meta/classes/image-container-extension.bbclass | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass
> index f693627..e26604a 100644
> --- a/meta/classes/image-container-extension.bbclass
> +++ b/meta/classes/image-container-extension.bbclass
> @@ -6,7 +6,6 @@
>  # This class extends the image.bbclass for containerizing the root filesystem.
>  
>  CONTAINER_FORMATS ?= "docker-archive"
> -IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache"
>  
>  containerize_rootfs() {
>      local cmd="/bin/dash"
> 

Thanks!

This is a high-prio regression fix IMHO.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Re: [PATCH v2] fix: remove unneeded unconditional recipes

[Anton Mikanovich]

14.04.2021 18:18, Silvano Cirujano Cuesta wrote:
> Commit 9c3499adf91 introduced the unconditional inclusion of the recipes
> isar-exclude-docs and isar-disable-apt-cache, but they would only needed
> for container images.
>
> That would have been anyway an optimization with questionable demand,
> therefore removing it.
>
> Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>

Applied to next, thanks.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov