Re: [PATCH 0/3] One-shot configuration packages

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Alex,

On 2018-05-23 15:16, Alexander Smirnov wrote:
> 
> 
> Claudius Heine <claudius.heine.ext@siemens.com> 23 мая 2018 г. 15:56:29 
> написал:
> 
>> Hi.
>>
>> I apparently need to do a v2 for this, since Alex 'Last fixes for
>> locales' patchset was on the fast lane and has gone to next and
>> simultaneously to master without any time to review it.
> 
> 1. The patches were sent on May 15 and pushed on May 18 in the evening. 
> In my opinion 3 days is quite enough to perform the review. So no fast 
> lane for my patches.

Ok, then its just my experience that patches are on the list for longer, 
even if they aren't commented on. (I also was on vacation for this 
period, so I couldn't review it in time and it might seemed shorter for 
me. But that is my issue :)

> 
> 2. Master branch merged after next branch becomes green.
> 
> Probably you assume that git commit date represents actual repository 
> pushing, what is wrong. It represents git am date.

I was mainly missing the 'merged' confirmation on the Mailinglist. I 
normally use that to know if I need to rebase or review.

Claudius

> 
> Alex
> 
>>
>>
>> Claudius
>>
>> On 2018-05-23 14:17, [ext] claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> Hi,
>>>
>>> here is my implementation of one-shot packages.
>>>
>>> I also implemented a packages that does the localepurge step.
>>>
>>> Claudius
>>>
>>> Claudius Heine (3):
>>> isar-bootstrap|configscript: implement one shot config option
>>> meta/isar-cfg-localepurge: added locale purge recipe
>>> meta-isar/isar-image-base: switch use isar-cfg-localepurge
>>>
>>> .../images/files/debian-configscript.sh       | 31 -------------------
>>> .../images/files/raspbian-configscript.sh     | 30 ------------------
>>> .../recipes-core/images/isar-image-base.bb    |  6 ++--
>>> meta/classes/isar-bootstrap-helper.bbclass    | 23 +++++++++++---
>>> .../isar-cfg-localepurge/files/locale.debconf | 12 +++++++
>>> .../isar-cfg-localepurge/files/locale.gen     |  1 +
>>> .../isar-cfg-localepurge/files/postinst       | 30 ++++++++++++++++++
>>> .../isar-cfg-localepurge.bb                   | 19 ++++++++++++
>>> 8 files changed, 84 insertions(+), 68 deletions(-)
>>> create mode 100644 
>>> meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
>>> create mode 100644 
>>> meta/recipes-support/isar-cfg-localepurge/files/locale.gen
>>> create mode 100644 
>>> meta/recipes-support/isar-cfg-localepurge/files/postinst
>>> create mode 100644 
>>> meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
>>
>> -- 
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>>
>> -- 
>> You received this message because you are subscribed to the Google 
>> Groups "isar-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send 
>> an email to isar-users+unsubscribe@googlegroups.com.
>> To post to this group, send email to isar-users@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/isar-users/bf3f2835-98b0-1ee0-1b88-5609af44bef6%40siemens.com. 
>>
>> For more options, visit https://groups.google.com/d/optout.
> 
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de