From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647450695491387392 X-Received: by 2002:a50:ad61:: with SMTP id z30mr1291417edc.0.1548845386651; Wed, 30 Jan 2019 02:49:46 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:1c50:: with SMTP id l16ls386574ejg.0.gmail; Wed, 30 Jan 2019 02:49:46 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Ou2uMqH5PMTHRQJms8BT+wZrSSbZKY9pJbJdvkO9+L7Ko5mfuph25EA+ZGcrzwnKPOrHH X-Received: by 2002:a17:906:6006:: with SMTP id o6-v6mr1226409ejj.4.1548845386245; Wed, 30 Jan 2019 02:49:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548845386; cv=none; d=google.com; s=arc-20160816; b=xFp0qn+VnvxqWtIv87mR4fW9ieFRAv+KIlXB/Hx5Of+xcqyFP1/NIOaUZfvZKOpKaz NeleHz2QE79kzgrMO8ZSN05Obon6EQ+0Q+6ceg0r1uTBlmnIE+gFa1h+BOYfrc5jbkOd gV9vy0qe5sgi5koZV7lMh/t+zwrLn/uYU+NiMeOXSgBKqZWVn51lAAKDbjpaYGCdUFaW UFMBWy+RPGdprILIbsnZNJn0LaYboLtXbr0lYgFo0KB+49/kQepARn4SQ/GEw92yWGTA MhX9RDeaYRhVQaMNGyuRtP4HG95MZLwcHfriQwetKKfQXYmGYGBkEKrnM90dPsPXXe9n oa7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=yNQev45CCr8WZjSm02c7l/fJNRYX44ujY9Fs4c7n4h4=; b=mPpNhmKZmuhNcnuwZZSOhcW1KOD5CWbm27Al2ArYdyd9/HIKLh+Z+PHgLf2f/TUjHM CSU5udH3jqKgTPTCyQA92JDzlKY+4Y77YMhW0PYroWiODwfgI4r9bnyPtjjzO+IRfkeY TIfurQM69LJFvXRsE+hPphWBP0Tx3/wL5raDShwAv5+PkCjHmB0KVB0Te+5OE8TSIVPP kea4PULsZ5EhQ1VaObcVL5rhVRr+urmG0I7bK8fZVOmOsJ9efpFgNNXxqDZogEMB/gGF G966g0WKGWXeV85xmQumWWO4UUDqDNj8JxC7GPTizqKZCizOCCqlpcKG6k+feFdpgje8 40HQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id l31si51795edb.5.2019.01.30.02.49.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 02:49:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id x0UAnhH9017570 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 30 Jan 2019 11:49:45 +0100 Subject: Re: [PATCHv2] linux-custom: skip linux-libc-dev deployment on downgrade To: Henning Schild , isar-users@googlegroups.com References: <20190117130342.15743-1-henning.schild@siemens.com> <20190128115108.2386-1-henning.schild@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <50bb897b-78c9-32bb-e363-e1459f66df61@ilbers.de> Date: Wed, 30 Jan 2019 11:49:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190128115108.2386-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: C6w2kPAJa7cj On 1/28/19 12:51 PM, Henning Schild wrote: > From: Henning Schild > > A custom kernel usually deploys linux-libc-dev in the kernels version. > But some packages in the distribution depend on >= expected upstream > version of that package. If we deploy a linux-libc-dev in a lower > version, installing packages like build-essential will not be possible > anymore. > That is especially problematic since incremental builds will pull that > into our buildchroot and break package installation in there. > > If detecting a downgrade, do not deploy the package and issue a warning. Applied to the 'next', Thanks, Maxim. > Signed-off-by: Henning Schild > --- > meta/recipes-kernel/linux/files/build-kernel.sh | 7 +++++++ > meta/recipes-kernel/linux/linux-custom.inc | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh b/meta/recipes-kernel/linux/files/build-kernel.sh > index dbd6162..745c89a 100644 > --- a/meta/recipes-kernel/linux/files/build-kernel.sh > +++ b/meta/recipes-kernel/linux/files/build-kernel.sh > @@ -122,3 +122,10 @@ rm -f linux-image-${PV}_${PV}-1_*.deb > fakeroot dpkg-deb -b ${REPACK_LINUX_HEADERS_DIR} \ > linux-headers-${KERNEL_NAME}_${PV}-1_${KERNEL_NAME}.deb > rm -f linux-headers-${PV}_${PV}-1_*.deb > + > +# linux-libc-dev causes dependency problems if we downgrade > +# remove it after the build so the downgraded version does not get deployed > +LINUX_LIBC_DEV_V=$( dpkg-query --show --showformat '${Version}' linux-libc-dev ) > +if dpkg --compare-versions $LINUX_LIBC_DEV_V gt $PV; then > + rm -f linux-libc-dev_${PV}*.deb > +fi > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index f33bb9d..ac37412 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -62,4 +62,7 @@ dpkg_runbuild() { > export KERNEL_HEADERS_DEBIAN_DEPENDS="${KERNEL_HEADERS_DEBIAN_DEPENDS}" > > sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} ${PP}/build-kernel.sh ${PP}/${PPS} ${DISTRO_ARCH} > + if [ ! -f ${WORKDIR}/linux-libc-dev_${PV}*.deb ]; then > + bbwarn "Kernel downgrade detected, not deploying linux-libc-dev" > + fi > } > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov