public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>,
	Uladzimir Bely <ubely@ilbers.de>
Cc: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
Subject: [PATCH] Revert "dpkg: sbuild allows extra arguments via DPKG_SBUILD_EXTRA_ARGS"
Date: Thu, 2 Feb 2023 15:42:36 +0100	[thread overview]
Message-ID: <51601d94-280d-b903-785c-3bef73f75fb1@siemens.com> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

This reverts commit 6d5fbbab9c9e3c894cbc9cf18180fb0057f82f20.

There are no concrete use cases for this interface known. Adding it
without an idea what it should be good for can create downstream
problems as the class evolves and also motivate inappropriate use of
this low-level interface in recipes.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/dpkg.bbclass | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 39308696..d5285032 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -23,8 +23,6 @@ do_prepare_build:append() {
     env > ${DPKG_PREBUILD_ENV_FILE}
 }
 
-DPKG_SBUILD_EXTRA_ARGS ?= ""
-
 # Build package from sources using build script
 dpkg_runbuild[vardepsexclude] += "${SBUILD_PASSTHROUGH_ADDITIONS}"
 dpkg_runbuild() {
@@ -111,7 +109,6 @@ dpkg_runbuild() {
         --chroot-setup-commands="echo \"APT::Get::allow-downgrades 1;\" > /etc/apt/apt.conf.d/50isar-apt" \
         --chroot-setup-commands="rm -f /var/log/dpkg.log" \
         --chroot-setup-commands="ln -sf ${ext_deb_dir}/*.deb -t ${deb_dir}/ || :" \
-        ${DPKG_SBUILD_EXTRA_ARGS} \
         --finished-build-commands="rm -f ${deb_dir}/sbuild-build-depends-main-dummy_*.deb" \
         --finished-build-commands="cp -Ln --no-preserve=owner ${deb_dir}/*.deb -t ${ext_deb_dir}/ || :" \
         --finished-build-commands="cp /var/log/dpkg.log ${ext_root}/dpkg_partial.log" \
-- 
2.35.3

             reply	other threads:[~2023-02-02 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 14:42 Jan Kiszka [this message]
2023-02-02 19:06 ` Roberto A. Foglietta
2023-02-02 20:14   ` Henning Schild
2023-02-02 22:44     ` Roberto A. Foglietta
2023-02-03 18:50       ` Henning Schild
2023-02-03 20:49         ` Roberto A. Foglietta
2023-02-07  8:54 ` Uladzimir Bely
2023-02-07  9:45   ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51601d94-280d-b903-785c-3bef73f75fb1@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox