public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Alexander Smirnov <asmirnov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH v2 2/4] example-module: Do not return error on init
Date: Tue, 6 Mar 2018 19:26:16 +0300	[thread overview]
Message-ID: <51626f42-394c-f6dd-ea70-7426c2cb7dcf@ilbers.de> (raw)
In-Reply-To: <2c4c122e-15e6-cbeb-8030-12d8d51d7149@siemens.com>



On 03/06/2018 06:56 PM, Jan Kiszka wrote:
> On 2018-03-06 16:40, Alexander Smirnov wrote:
>> Also make module re-loadable by adding exit hook.
>>
>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>> ---
>>   .../recipes-kernel/example-module/files/src/example-module.c      | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-isar/recipes-kernel/example-module/files/src/example-module.c b/meta-isar/recipes-kernel/example-module/files/src/example-module.c
>> index 07cb214..4e74ee7 100644
>> --- a/meta-isar/recipes-kernel/example-module/files/src/example-module.c
>> +++ b/meta-isar/recipes-kernel/example-module/files/src/example-module.c
>> @@ -11,9 +11,15 @@
>>   static int __init example_module_init(void)
>>   {
>>   	printk("Just an example\n");
>> -	return -ENOANO;
>> +	return 0;
>> +}
>> +
>> +static void __exit example_module_exit(void)
>> +{
>> +	return;
>>   }
>>   
>>   module_init(example_module_init);
>> +module_exit(example_module_exit);
>>   
>>   MODULE_LICENSE("GPL");
>>
> 
> Looks better :)

Thanks for the hint, you were right regarding exit. :-)

Alex

  reply	other threads:[~2018-03-06 16:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 12:40 [RFC][PATCH 0/4] Kernel module autoload Alexander Smirnov
2018-03-06 12:40 ` [PATCH 1/4] kernel/module: Add AUTOLOAD option Alexander Smirnov
2018-03-06 12:59   ` Jan Kiszka
2018-03-07  7:19   ` Jan Kiszka
2018-03-07  7:36     ` Alexander Smirnov
2018-03-07  7:39       ` Jan Kiszka
2018-03-07  8:13         ` Alexander Smirnov
2018-03-07 10:46   ` [PATCH v3 " Alexander Smirnov
2018-09-12 13:15     ` Henning Schild
2018-03-06 12:40 ` [PATCH 2/4] example-module: Do not return error on init Alexander Smirnov
2018-03-06 12:58   ` Jan Kiszka
2018-03-06 15:40   ` [PATCH v2 " Alexander Smirnov
2018-03-06 15:56     ` Jan Kiszka
2018-03-06 16:26       ` Alexander Smirnov [this message]
2018-03-06 12:40 ` [PATCH 3/4] example-module: Enable autoload Alexander Smirnov
2018-03-06 12:40 ` [PATCH 4/4] vm_smoke_test: Add check for kernel module Alexander Smirnov
2018-03-07 10:47   ` [PATCH v2 " Alexander Smirnov
2018-03-09  8:49     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51626f42-394c-f6dd-ea70-7426c2cb7dcf@ilbers.de \
    --to=asmirnov@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox