From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6529810911788531712 X-Received: by 10.25.80.68 with SMTP id z4mr1362758lfj.31.1520353587515; Tue, 06 Mar 2018 08:26:27 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.25.151 with SMTP id 23ls2007155ljz.5.gmail; Tue, 06 Mar 2018 08:26:26 -0800 (PST) X-Google-Smtp-Source: AG47ELv91RHukEPWvlyEyCt7zicwuIiyUGmaGRVFPTgakirmpVyWeG5ANgAVKlrIj90Fe5CuzRK7 X-Received: by 10.46.129.206 with SMTP id s14mr1315153ljg.9.1520353586830; Tue, 06 Mar 2018 08:26:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520353586; cv=none; d=google.com; s=arc-20160816; b=vYP21eU4FmsAzMRF+bsf+E3TMdqf0ca9xlxx+/PAyfuhtn0CypimOHtzdg/p/rnM7k xh7pSdC+hmhBe17en337AUbv+tERT118VfL3vLzX/9i2rT7msCSenbA3JUVqyvchHRYD wsMVqqGmLn/KDpr2pcU+0hvvgZtHvjn0CSRcJ08VeJa07B/MUPmJT6YweLWWGCnStjB8 8UaZirheAbr9Y/RU85AovuyOfmBYkp5XVlwSVAQIuOFuncGFYu0opHREOk9QvTEByBMX n5nTBSxnN+Xxj6yGaki2R5RXLM7fYvRZVI+czF11o7H8wvhTKwWZbLT4fh/ySJDTat7l j5ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=hY1oL2wRAl6zzoJLpZJimD1bwMjnycaE+Wlk0WkN580=; b=XwrCnqZ0CDDHDYVKRvpnCmOAX53jJaU2OUMLLn9UnHNiioWuXq6y6tse8DVKZPqPuC s6ofxjAQyPdAI/lS7tXr5zVDsPawF9of3LqWk4cBl4BwbS9KtnEWqXqXxLhzJjiNCC3V TRXczG7bHXp4TGfQk5cQGmh/+pSn+TrUcI8jUF79406i4dGUnTcbPND61r/z/BqRAzGi jNKpQa0JL1trhic2KgDVYX1KQXcNKZ5JsaeE7wkVJzILxuCKOOIcSx6ExOcxFA7xxMrC 3ng3g71+EqrSM3JgAJX9Or7t5m0GIFAsJc1Onrl10e3XkiQIvbGSYZPt731kvSyh0KX/ pK0A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id s26si616254lfi.1.2018.03.06.08.26.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 08:26:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w26GQMbW014166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 6 Mar 2018 17:26:24 +0100 Subject: Re: [PATCH v2 2/4] example-module: Do not return error on init To: Jan Kiszka , isar-users@googlegroups.com References: <20180306124055.15990-3-asmirnov@ilbers.de> <20180306154012.17121-1-asmirnov@ilbers.de> <2c4c122e-15e6-cbeb-8030-12d8d51d7149@siemens.com> From: Alexander Smirnov Message-ID: <51626f42-394c-f6dd-ea70-7426c2cb7dcf@ilbers.de> Date: Tue, 6 Mar 2018 19:26:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2c4c122e-15e6-cbeb-8030-12d8d51d7149@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 42XlekLGKkfs On 03/06/2018 06:56 PM, Jan Kiszka wrote: > On 2018-03-06 16:40, Alexander Smirnov wrote: >> Also make module re-loadable by adding exit hook. >> >> Signed-off-by: Alexander Smirnov >> --- >> .../recipes-kernel/example-module/files/src/example-module.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/meta-isar/recipes-kernel/example-module/files/src/example-module.c b/meta-isar/recipes-kernel/example-module/files/src/example-module.c >> index 07cb214..4e74ee7 100644 >> --- a/meta-isar/recipes-kernel/example-module/files/src/example-module.c >> +++ b/meta-isar/recipes-kernel/example-module/files/src/example-module.c >> @@ -11,9 +11,15 @@ >> static int __init example_module_init(void) >> { >> printk("Just an example\n"); >> - return -ENOANO; >> + return 0; >> +} >> + >> +static void __exit example_module_exit(void) >> +{ >> + return; >> } >> >> module_init(example_module_init); >> +module_exit(example_module_exit); >> >> MODULE_LICENSE("GPL"); >> > > Looks better :) Thanks for the hint, you were right regarding exit. :-) Alex