From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH 3/4] template: Remove KERNEL_NAME from default TEMPLATE_VARS
Date: Tue, 2 Apr 2019 08:20:50 +0200 [thread overview]
Message-ID: <51c4512929e938e7d7f525ad6df9ddcbe78cda54.1554186051.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1554186051.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1554186051.git.jan.kiszka@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
KERNEL_NAME is a globally defined variable but is only used for
templating by the module recipe include. As the templating step is
inherited by all packages, changing the KERNEL_NAME can cause unneeded
recipe rebuilds. Therefore, make this template variable specific.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/classes/template.bbclass | 2 +-
meta/recipes-kernel/linux-module/module.inc | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbclass
index 3eb9114..f3b5f80 100644
--- a/meta/classes/template.bbclass
+++ b/meta/classes/template.bbclass
@@ -4,7 +4,7 @@
# SPDX-License-Identifier: MIT
TEMPLATE_FILES ?= ""
-TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME DISTRO_ARCH"
+TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH"
do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}"
do_transform_template[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
index 44edd58..6506e39 100644
--- a/meta/recipes-kernel/linux-module/module.inc
+++ b/meta/recipes-kernel/linux-module/module.inc
@@ -21,6 +21,7 @@ inherit dpkg
TEMPLATE_FILES = "debian/control.tmpl \
debian/changelog.tmpl"
+TEMPLATE_VARS += "KERNEL_NAME"
do_prepare_build() {
cp -r ${WORKDIR}/debian ${S}/
--
2.16.4
next prev parent reply other threads:[~2019-04-02 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 6:20 [PATCH 0/4] Patch improvements, more templating fallouts, linux-libc-dev fix Jan Kiszka
2019-04-02 6:20 ` [PATCH 1/4] patch: Add support for patchdir parameter Jan Kiszka
2019-04-02 6:20 ` [PATCH 2/4] Make patch task repeatedly applicable Jan Kiszka
2019-04-02 6:20 ` Jan Kiszka [this message]
2019-04-02 6:20 ` [PATCH 4/4] linux-custom: Fix linux-libc-dev version check Jan Kiszka
2019-04-03 18:36 ` [PATCH 0/4] Patch improvements, more templating fallouts, linux-libc-dev fix Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51c4512929e938e7d7f525ad6df9ddcbe78cda54.1554186051.git.jan.kiszka@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox