From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221105623410147328 X-Received: by 2002:ac2:5095:0:b0:4eb:3b60:a642 with SMTP id f21-20020ac25095000000b004eb3b60a642mr1667038lfm.8.1681463823218; Fri, 14 Apr 2023 02:17:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3ba4:b0:4ec:7b3a:89b8 with SMTP id g36-20020a0565123ba400b004ec7b3a89b8ls244740lfv.2.-pod-prod-gmail; Fri, 14 Apr 2023 02:17:01 -0700 (PDT) X-Google-Smtp-Source: AKy350axyucBLjEWKX9nJqVHHGRFXsfskGOCLx9I+3gVLDJWN4SHxWk9X4wyA60ayCFuvwoPO2QZ X-Received: by 2002:ac2:4241:0:b0:4eb:3bb9:5a6d with SMTP id m1-20020ac24241000000b004eb3bb95a6dmr1448074lfl.1.1681463821391; Fri, 14 Apr 2023 02:17:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1681463821; cv=pass; d=google.com; s=arc-20160816; b=shaKpMzQcinkKAyO1lMmLRhVT3MjMbV1snkaMCAMeAvJB+I4ccQ8VHi8ELhQfu2wwc N/M6Yv4S6e3g5yyyU5qWfdk7Ia7/yj+zQJB9K3txvxkG0qkeLeTg5Xv6UWN3kGJEMaNG L6I1KqMdTHqsokhvoCXssSuzBZtgvZ7fZ33A3aX5BcWjtI9iUjdQ77qu52vLb7WIB6pr dsSvkAeHSm0+1aojmRGD7hoxsnI7z5fTVMA8vQuB7XqDuCS8bZruhVEu3lwxRHHNtW+N xxMnUJG+hbKOA19y38efpMb0Nx738f+UBZ8Fx57YcZxUFWzj76snR6LyMJMAVJI5cE/A ZWtw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=rdWIK3GcAC+jIl75lflSBJk2M2d+p9vQf+e5brKlv9k=; b=OQzCajc18+DtwWTpS91Hq4zXe/xwaq4mYz6lxiMxSNqdRxbfkSAWYwZVjaRTVNaDv0 14zLt45M1SKRRVmhdUjtuVH0butHT/w1f6mSdHAa5srwYlpU7zbEi6cg69bCA/dFOGYb 9j3NPn25kQFPXPTYf9DG45rETr5ZQAzqGFgyXjvqH6oVNFvatmqDB1lrNXqEdRfB8r6t lGogW2T9QU/uXxwxZvaymWVBiMX1LKH3wMCDhKdKaddveQ6LsszIJ379zxBqH6YD3bur PVQ+o2fU2CVs3PaIR1uj78UOnvxhpK/s8CAVPRtID87pwolk4t3o/Jo5jeXqynN7GKji UF8w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wakS9NxZ; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::610 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0610.outbound.protection.outlook.com. [2a01:111:f400:fe0e::610]) by gmr-mx.google.com with ESMTPS id f18-20020a0565123b1200b004ec6206f60esi220547lfv.9.2023.04.14.02.17.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2023 02:17:01 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::610 as permitted sender) client-ip=2a01:111:f400:fe0e::610; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wakS9NxZ; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::610 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3YcJrH1fdJ9xHccNkhCwRU8ahxWMBD3GkcutHU7COwLQM3GFwfvLjGVCVDDW1zD+mSBxVuoxbyvH6Ao9ALNyGPZzHGXihNMbds12IjHaP+J+CT+JfUhl5iZrIFI4WzlKJ+G55uevB60FA+dNhy+J0/mCt/rNDDexXOyErmWKltAyXlj+071lwvhc08DRA0uN/Vq2jUGgmUMH7T8OV4ZIAEBaxDYuDQe8WfgvpNsvWfz9xuxxF3V2+qZb7T17LojqU7+KETBB6Ne+9mbwrf7ZSbxzIDO+h13BoW5LhBLcZeP3fHun5Y1Xn+6uskqs6pAC9busDfpJQOAbfxH/q5+3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rdWIK3GcAC+jIl75lflSBJk2M2d+p9vQf+e5brKlv9k=; b=ipxtNjVDS3r+7jM/fdP/r+g3OL32jqWkVzAAKlIRpLRIktwK/VCe6u4hQOkMZaizJIrAwlYIAni9djSU9DR3HuRd9SIC77dB6+OItfZ/vyr9iCKo01HhqLARj6mH+QJHvKqKibjRf3dBTtjfpVKOvsFutXTer4A9AZ/eobIhqh4GoEoiJPjJkIqRDErIgyhirYpQKrLLNYxdpmPLsSCOA2va+ygePIB1ZHyCMJBv1y7jvs9+m0eIvomQXKKybI0JDSpws6ZFgOtjaZWh8tQNJje+635nXFi9gJmoPNN/gEyJALvQhB59MazQ2bc6VJMgwFrpHLgqyVbzpFcj1/LXOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rdWIK3GcAC+jIl75lflSBJk2M2d+p9vQf+e5brKlv9k=; b=wakS9NxZlkfDaxNwgskxd73NjkAm7tXNRQvplVqjnQLyFqMXMVBaWlKCe/G34JmqlMMBqSyjiA1h/YPOyGULZT8fTU1SSMdBILF55375aC0Mbs8IKb9pWW3Mt94uFRCxBrFrMnPIIleH4nGHwtmptP2WogrfZvaHCZxW2RkdiyOimaZitzezM4QwMafgGltPMOR8PJOqvza0v89/S1uXqQC7j8DdwmbfxH2vDc9QVf6rZ014AZDV4Sa3Q2zjy2J21DGMKaUWX4P/SZs7TEoNXboYT3tnX/Wn87uxvX+VqbnsefdQNhSiz1YSJJWJIgNCwot5iUu6ld/4A6tlYXThAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DU0PR10MB6780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:47b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 09:16:59 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e%5]) with mapi id 15.20.6319.004; Fri, 14 Apr 2023 09:16:59 +0000 Message-ID: <526d9fd9-a8ab-ba29-d925-6c77afaaf985@siemens.com> Date: Fri, 14 Apr 2023 11:16:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] meta/conf/bitbake.conf: enable SRCPV support for AUTOREV Content-Language: en-US To: Srinuvasan Arjunan Cc: Srinuvasan Arjunan , isar-users@googlegroups.com References: <20230414085742.844733-1-srinuvasan_a@mentor.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM8P189CA0012.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::17) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DU0PR10MB6780:EE_ X-MS-Office365-Filtering-Correlation-Id: c6f6e959-40c9-4330-dad2-08db3cc90032 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wTTTlrqpqDlcoVJ3XXLdXY9eh27OF/HyqBy2lD0F+Vebw3GEFeuSbUj7cOAXU7sCquR9Gu2eKTaiLt8Nx/PjRv1FxyAgXU3WU3VAnTuGjnT+XoTyfG6/MdbRvfJ1VI8pZfTtvYEh7cq8Vp5+Ua91GnR5tNcqz0ekPbAWJCiNsrLs+/rS5s7/ZYXnGK/Z8fO5KUJoVvMsb8ezMSzyUB2sbuz6pSjL7odqjuzIjedTXz+hqifQ+s7Ao0DtYb23IR8ZgHR9D1hnqiyQUR4X/MHWppjdNfsxNG7HN66XejmiGPVowAHB+ql4S/hm1+7SOV9iertxs1TbkczNI+XcQQLLQG0lRZx9pN4YbBExssG9wnZQcI6yJXHrVwt3z3WfiSGxTC8nWV/cUVq1taESQHbPtefpAnLJd/CP9kKbcVatHKUs498x6UDzjeoqp2VrP26zNHwTncK+me1PWTHiyI98F1M6blZwzgxt+E4ycMZfabnnvagIYvwwzYe7dh/U3Es4Ym9a3TWSY71/j04kkiyTeaosY6Yp0ENz13HEDOReFUEQAzcRigNfSF1pkmStR2uqWp9BwnjhPo/LEhM7wHVyQJUZ+Ke5dyrUF1fXINknMmIxGqueetm/MHZEoXLAvTPoc2jKAfalU4NLGsZPs5nZtg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199021)(5660300002)(31686004)(478600001)(41300700001)(316002)(6486002)(8936002)(6666004)(66946007)(26005)(53546011)(44832011)(6512007)(6916009)(66556008)(4326008)(66476007)(8676002)(6506007)(186003)(2906002)(83380400001)(2616005)(82960400001)(86362001)(38100700002)(31696002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEplUU5ydWFjOWtkZ0p5RW9PeUxrT0E1SUEzNWp1ckxUbUd4TUNlK21MVjQw?= =?utf-8?B?eVhEdnVzYmpOSVhQTlJDcWhFblpxL0tlM3A4WGJVaTNjWUthenZaVkpOcDQ2?= =?utf-8?B?c0lXNmtpUGU5TGViTzdCN3RySUc3Q05PaFRqUWhhS0VSa2ZiemdJdlU4cHVs?= =?utf-8?B?WHlRRUpBaFp3YkRNb2NJb0JDVVJRMXhSK0dWY3JMMkVaaExZOVJWR1lWSDFS?= =?utf-8?B?dG11ZUpTUlY2TlM3cTZjbGNZNXRCMDNxdGNNR3VDcFJVUE02Nk5RZkZ2ZWYw?= =?utf-8?B?T0UxajdOZFFGQlFPSkt6cG5PVFp2eHRZRXJoUDRxYUsxL3duZnBVNEpSUmli?= =?utf-8?B?ZnVEN1Y3WVc1WVA5cnpReHRTVHczWVljUUxiOWg0SGZHbDl2dnhNelduZlUx?= =?utf-8?B?QVpucjVQZUovcE8zbnpxN25VdnA5TWZBUHlQNVVGcDFReDQ5RWxFQlA4aWJV?= =?utf-8?B?cVU5V0dxdGgyRTJKSk9rZnlUcVcwUmdndWJYTFdOQTQwMzQrN0RxWjFYeDZS?= =?utf-8?B?ZHZRMExudERpZDVSa1N2V2xYeW5jRDZidjZBMEV3cytlU2hUVTJiUnVBOUhE?= =?utf-8?B?aXhYNGZURFliOVpiVlFMZ3YrYlRnR2I4dEY4Z205Y2xwY1lzQUUwN0l4U25F?= =?utf-8?B?VSs1KzYrakR1bDloZTMrL1JOWnBacjk5Ym4yaERDZ2dRZXQ0Z3pnck5DaFA0?= =?utf-8?B?TTlnZ3oycjI1UmpIZnBPOHhDVjFkcExXendWNWlEa0k2eTR3VDA3a05JQ1Rk?= =?utf-8?B?YWthT2VRN0pRMG9FNlJOR2JnbzJVMHRjZlhQTmJUN0V3eW5IckEwbEY2S0ln?= =?utf-8?B?MDJ4UncwRHlyUlBFbWpQRHUra0N6U2VQRDRQdTdDMzZFaWVhbzRUSHlFekFh?= =?utf-8?B?TVNFdy80Sm0wcndGY1FjTkx3M0x2c3IyRmdFMjQza2tOZEdpOGdsemg4U2Ew?= =?utf-8?B?cWRyY011Z0ttOTZsV1d1TWxNbDlzazlaZzdJZU5maTFJMm1palVGNUtqSmJw?= =?utf-8?B?dzM4R2RVcTc2NVpMREo4NnR6bFMzb2MyM3dENUVXMUpqUHlaNG9WNGN1VW02?= =?utf-8?B?ai82V1hoOC9idlRJSEZXWXNRd2NzYXFlbUZHSng1NEFkMjExRmhnUWVVZXNr?= =?utf-8?B?YmdkRlNBb3dURmJwbWpRNnNZSmFyVUd2OTFwK0tsT3N4cklFRk1ndThvOUQ5?= =?utf-8?B?bENSOTJwT2F5ZzdUZTZSd093MFYybzdnaTZyK0srWGprNEl2SHMvUjRSa01q?= =?utf-8?B?ZzM1S3hnZjNRUytONGdEcytsT3F3RnhXU2JzQ2JPMGVDcGcrcWlaMVpJMzRW?= =?utf-8?B?QjRLbGtZUlplWG1TQ2g5cEF0NmdvYTIwSGtWTnpwdGxjYmRFeUk4WExXVHg3?= =?utf-8?B?ZVA0TTcwSnlBUmVQT1NaMUZOQjVXTGFzL3ZTcTBRVTd2aXVldWU4MyttTmhQ?= =?utf-8?B?OTFxR1NLY240UitTekJheXgxQlJ2TjBOUTNHZTA2Z3FxTVpycFBjNFMrZXMy?= =?utf-8?B?djBxdVJqVTNQUzFCRjBJbnRWVEdnMWhxZ3JOVkJTOVNFYXlybFdXajRmRzF5?= =?utf-8?B?b3BVclJiRWIzRThxVFB0TGdTYjc4ZUUvUHZyVmgrM05ockJPUThYSW5xYlJQ?= =?utf-8?B?aFo4S0phazI5QjA0ejQ1RU5YMWNPU2FDTVpFdzNMdjQxSS8rbytlcUl1MUx1?= =?utf-8?B?VmZCSk1Kb0J4bFp2aTROR1dSL3RrLzY4SUJ6QXV0azA1YzUraG9NSjFWMjcy?= =?utf-8?B?WWdNLzJJRitEYlEwbU81MHM3ZkNlaUsrc2FWeG4xYTdJL2xlVUdQQ0ovZjZN?= =?utf-8?B?Y0lBcnVIaUFwdG5KYVAzWnlSRldITm5TbjRvOFp5ejVjemxrMVR3ak14WkJm?= =?utf-8?B?QjlKQmN5KytDY1hZVGtUTU83VnAwMU9IY01ZQWlIK2hDcFlBSmZSYzZYa0Zk?= =?utf-8?B?ZGFCUmZpRFJJVmpWb2hsZ1p4N1pIU3VYTkQxQUFxenUwajRuVCtKcE9PWGR3?= =?utf-8?B?Q1QzRHVYUGVxcm8zanp0d1dISklORGd5ZlF5SUNaSGJMb3JNZ0dtTFM5cVNh?= =?utf-8?B?azlUYmJaTjJGNXlWNktFMisvYWVFamZDSm5pR3h3d0JDVHRFVnJmYmxHN2l5?= =?utf-8?Q?e6IqWGAPfa7QyQ4VH6CNs1e1g?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6f6e959-40c9-4330-dad2-08db3cc90032 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 09:16:59.3714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a08pfcIEDNYTS6d6IjDRKEji+NmQJzZhdP+T58AUmKXA9r7AhRKVElo6c54nnZG9dOErdFpLDq8PtomoZDXqDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6780 X-TUID: XXWdG9hQLL8C On 14.04.23 11:12, Srinuvasan Arjunan wrote: > > > On Fri, Apr 14, 2023 at 2:30 PM 'Jan Kiszka' via isar-users > > wrote: > > On 14.04.23 10:57, Srinuvasan Arjunan wrote: > > From: Srinuvasan A > > > > > One of our downstream project recipe uses `SRCREV = "${AUTOREV}"` > to get > > the latest changes always, but this not works after bitbake 2 > migration, > > it throws the below error. > > > > do_fetch: Fetcher failure: Recipe uses a floating tag/branch > without a fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use > SRCPV in PV for OE). > > > > Till now we don't have support for SRCPV in ISAR, hence add this > support > > as like OE. > > > > Signed-off-by: Srinuvasan A > > > --- > >  meta/classes/base.bbclass | 4 ++++ > >  meta/conf/bitbake.conf    | 4 ++++ > >  2 files changed, 8 insertions(+) > > > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > > index 53550ae..819f8a2 100644 > > --- a/meta/classes/base.bbclass > > +++ b/meta/classes/base.bbclass > > @@ -120,6 +120,10 @@ root_cleandirs() { > >  python() { > >      import re > >  > > +    srcuri = d.getVar('SRC_URI') > > +    if srcuri: > > +        d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}") > > + > > Still not the logic that OE uses - why? > > Jan > >   >   I thought it would be enable when SRC_URI contains any SCM >   They have a logic like get the uri and validating the uri.scheme > against with many SCM , and set the needsrcrev variable if needed >   f.e : git >   > if uri.scheme in ("git", "gitsm"): >             needsrcrev = True > > >  Would we need to check like this? > Counter question: Does your solution also work if SRC_URI is only containing "file://"? Jan -- Siemens AG, Technology Competence Center Embedded Linux