[PATCH 0/1] Cleanup of the configscripts

[PATCH 0/1] Cleanup of the configscripts

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Hi,

this patch contains some cleanup of the configuration scripts.
I tried testing it with the raspberry pi, but could do it since isar is
apparantly incompatible with rasberry pi 3. And thats the only version I
had available.

But I took a look at the files on the boot partition and they look fine.

Cheers,
Claudius

Claudius Heine (1):
  meta-isar/isar-image-base: remove uncesessary cmd lines from cfg
    scripts

 .../images/files/debian-configscript.sh            | 26 -----------------
 .../images/files/raspbian-configscript.sh          | 33 ++--------------------
 2 files changed, 3 insertions(+), 56 deletions(-)

-- 
2.16.3

[PATCH 1/1] meta-isar/isar-image-base: remove uncesessary cmd lines from cfg scripts

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Since we changed to use debootstrap and apt for the installation of
every package, additional runs of 'dpkg configure' and postinst scripts
are no longer necessary.

This removes also the defunct revert of the 'deamon disable steps' used
with the multistrap version of isar and the setting of the root
password, since that should be done in a postinst step of a package
instead.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 .../images/files/debian-configscript.sh            | 26 -----------------
 .../images/files/raspbian-configscript.sh          | 33 ++--------------------
 2 files changed, 3 insertions(+), 56 deletions(-)

diff --git a/meta-isar/recipes-core/images/files/debian-configscript.sh b/meta-isar/recipes-core/images/files/debian-configscript.sh
index f2fa2d9..042b530 100755
--- a/meta-isar/recipes-core/images/files/debian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/debian-configscript.sh
@@ -37,19 +37,6 @@ locales locales/locales_to_be_generated multiselect en_US.UTF-8 UTF-8
 locales locales/default_environment_locale select en_US.UTF-8
 END
 
-# Set up non-interactive configuration
-export DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true
-export LC_ALL=C LANGUAGE=C LANG=C
-
-# Run pre installation script
-/var/lib/dpkg/info/dash.preinst install
-
-# Configuring packages
-dpkg --configure -a
-
-# set the root password if that has not been done before
-grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd
-
 cat > /etc/fstab << EOF
 # Begin /etc/fstab
 /dev/$ROOTFS_DEV	/		$ROOTFS_TYPE		defaults		1	1
@@ -76,16 +63,3 @@ fi
 # Purge unused locale and installed packages' .deb files
 localepurge
 apt-get clean
-
-# Undo setup script changes
-if [ -x "$TARGET/sbin/start-stop-daemon.REAL" ]; then
-    mv -f $TARGET/sbin/start-stop-daemon.REAL $TARGET/sbin/start-stop-daemon
-fi
-
-if [ -x "$TARGET/sbin/initctl.REAL" ]; then
-    mv $TARGET/sbin/initctl.REAL $TARGET/sbin/initctl
-fi
-
-if [ -x "$TARGET/sbin/init" -a -x "$TARGET/usr/sbin/policy-rc.d" ]; then
-    rm -f $TARGET/usr/sbin/policy-rc.d
-fi
diff --git a/meta-isar/recipes-core/images/files/raspbian-configscript.sh b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
index 1a85c40..ec05a6b 100644
--- a/meta-isar/recipes-core/images/files/raspbian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
@@ -37,23 +37,6 @@ locales locales/locales_to_be_generated multiselect en_US.UTF-8 UTF-8
 locales locales/default_environment_locale select en_US.UTF-8
 END
 
-# Set up non-interactive configuration
-export DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true
-export LC_ALL=C LANGUAGE=C LANG=C
-
-# Run pre installation scripts
-/var/lib/dpkg/info/dash.preinst install
-
-# Prevent removing of boot firmware
-/var/lib/dpkg/info/raspberrypi-bootloader-nokernel.preinst install
-rm /var/lib/dpkg/info/raspberrypi-bootloader-nokernel.postinst
-
-# Configuring packages
-dpkg --configure -a
-
-# set the root password if that has not been done before
-grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd
-
 cat > /etc/fstab << EOF
 # Begin /etc/fstab
 /dev/$ROOTFS_DEV	/		$ROOTFS_TYPE		defaults		1	1
@@ -72,21 +55,11 @@ if [ -f /etc/inittab ]; then
         >> /etc/inittab
 fi
 
-# Undo setup script changes
-if [ -x "$TARGET/sbin/start-stop-daemon.REAL" ]; then
-    mv -f $TARGET/sbin/start-stop-daemon.REAL $TARGET/sbin/start-stop-daemon
-fi
-
-if [ -x "$TARGET/sbin/initctl.REAL" ]; then
-    mv $TARGET/sbin/initctl.REAL $TARGET/sbin/initctl
-fi
-
-if [ -x "$TARGET/sbin/init" -a -x "$TARGET/usr/sbin/policy-rc.d" ]; then
-    rm -f $TARGET/usr/sbin/policy-rc.d
-fi
-
 KERNEL_IMAGE=`ls /boot | grep vmlinuz`
 
 cat > /boot/config.txt << EOF
 kernel=$KERNEL_IMAGE
 EOF
+
+localepurge
+apt-get clean
-- 
2.16.3

Re: [PATCH 0/1] Cleanup of the configscripts

[Claudius Heine]

On 04/10/2018 03:14 PM, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Hi,
> 
> this patch contains some cleanup of the configuration scripts.
> I tried testing it with the raspberry pi, but could do it since isar is
> apparantly incompatible with rasberry pi 3. And thats the only version I
> had available.
> 
> But I took a look at the files on the boot partition and they look fine.

We also might want to start the discussion about what to do with the 
rest of the configuration script content:

   1. Setting up the locale settings
   2. Setting up /etc/fstab
   3. Creating /dev/console
   4. Setting up getty for serial connection
   5. purging unused locale setting and man files
   6. executing 'apt-get clean'

I sort of see reason to do general cleanup jobs in the configuration 
script. Since that should be done after all packages are installed but 
before we could extract all used packages for the reproducable build 
feature. Most of those other steps I would rather do in post/preinst 
steps of a package. The order is not really that important there. Maybe 
its possible to create some sort of 'isar-general-setup' package, that 
does all of that based on bitbake variables and is included in every 
image per default.

What do you think?

Cheers,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH 0/1] Cleanup of the configscripts

[Claudius Heine]

Hi,

On 04/10/2018 03:14 PM, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Hi,
> 
> this patch contains some cleanup of the configuration scripts.
> I tried testing it with the raspberry pi, but could do it since isar is
> apparantly incompatible with rasberry pi 3. And thats the only version I
> had available.
> 
> But I took a look at the files on the boot partition and they look fine.

Apparently there is an issue with the raspbian-configscript. I will send 
a new version of it soon.

regards,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH 0/1] Cleanup of the configscripts

[Claudius Heine]

Hi,

On 04/11/2018 11:24 AM, [ext] Claudius Heine wrote:
> Hi,
> 
> On 04/10/2018 03:14 PM, [ext] claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> this patch contains some cleanup of the configuration scripts.
>> I tried testing it with the raspberry pi, but could do it since isar is
>> apparantly incompatible with rasberry pi 3. And thats the only version I
>> had available.
>>
>> But I took a look at the files on the boot partition and they look fine.
> 
> Apparently there is an issue with the raspbian-configscript. I will send 
> a new version of it soon.

Ok, sorry. All-clear!

It was apparently just an error that occurred with a dirty build 
directory. The issue was that it could not find the 'localepurge' binary 
in the configscript, but this should be deployed in a clean build.

regards,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de