From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6995471841453146112 X-Received: by 2002:a05:6512:3391:: with SMTP id h17mr10592678lfg.173.1629102439794; Mon, 16 Aug 2021 01:27:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3f02:: with SMTP id y2ls537342lfa.3.gmail; Mon, 16 Aug 2021 01:27:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCjNWb1UqxioIORqvkgB++9G87vP1jdwMtNZgo2HUBR6HvVsdGjph2KcL3QSKWlAOIOrBI X-Received: by 2002:a05:6512:a84:: with SMTP id m4mr10846633lfu.393.1629102438559; Mon, 16 Aug 2021 01:27:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629102438; cv=none; d=google.com; s=arc-20160816; b=zifnyUUbtRh/YIoVssWaofYOo7v4iiC4iot80UOW5bnSYMfqat5BQPXpV9KmGd1HXN HCdI4izCM2MjCrf4JCl8G970YqlBVH43PYYDFVPu7iDVrKtAysgC7RatILnKPF3fuHGe ZTvYpxYmzoSHJGFcRMp/8UZYcZr/jAhpt8BxZNpkHwpj8VqwAa7feeVfDf7fss6WUC9g nlnrQDyaIQ7TJ/haIjfgzcsjPRjiVb1ArVoeeyf+SHNswxynbqqzeZtaw/+mHr0pjyQO FqpMBz9Wpv4nj6FJMylrz5xkeq9qVVYNclaAGIQwE9Y9Zw44jFNk5o1eUREzmxH6k7/s L6kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=x25EHl5nAtNEtENc8U5wv0C6ovsjHeeRPN6LEVeCgAM=; b=xhnwWeA236CF05zw6w7ckGyB2h453U5Als0pVABzKFeAOseyYp1WLFOXXEjw5BtbeU NQ+jzlzqzx6OH+gjQq0IQOvjJkfm07HpcWT6FNwQ2pfl0LDA6MsU1b1t+rnxMrzWl3a0 ktrQXmPuGwpLUBgPiHNRxPkVbxzjbCVvkA+rte48ABElJlfKYyblSEPdJ77uKM29jUwK sEDJRDxxDjAmXRjO7O4rpfYTzu/m9LDX42HqsLrhXf8ghNQrb1ttkZ5JJaG9wNMScPCx WwV87mr0YZODIUOjGbEYs/1X6/nswyrtIUt5zusdH9hRWSkLRvtk5ls6gAPP6Lf6Z+E0 7xIw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id v15si402633lfa.6.2021.08.16.01.27.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Aug 2021 01:27:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 17G8RGvk002795 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Aug 2021 10:27:17 +0200 From: Uladzimir Bely To: isar-users , Jan Kiszka Subject: Re: [PATCH v2 0/4] Make adjust_git work in both worlds Date: Mon, 16 Aug 2021 11:27:15 +0300 Message-ID: <5292418.rdbgypaU67@home> In-Reply-To: References: <2143861.vFx2qVVIhK@home> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: hPQ25pCtEcOH In the email from =D0=BF=D0=BE=D0=BD=D0=B5=D0=B4=D0=B5=D0=BB=D1=8C=D0=BD=D0= =B8=D0=BA, 16 =D0=B0=D0=B2=D0=B3=D1=83=D1=81=D1=82=D0=B0 2021 =D0=B3. 10:55= :31 +03 user Jan Kiszka=20 wrote: > On 16.08.21 09:52, Uladzimir Bely wrote: > > In the email from =D0=B2=D0=BE=D1=81=D0=BA=D1=80=D0=B5=D1=81=D0=B5=D0= =BD=D1=8C=D0=B5, 15 =D0=B0=D0=B2=D0=B3=D1=83=D1=81=D1=82=D0=B0 2021 =D0=B3.= 22:02:25 +03 user Jan > > Kiszka>=20 > > wrote: > >> On 13.08.21 14:40, Uladzimir Bely wrote: > >>> When I previously looked at patch.bbclass, I noted, that we don't use= it > >>> completely. > >>>=20 > >>> There are some patch_task_patch_prefunc() and patch_task_postfunc() h= ere > >>> that are used in OE when PATCHTOOL=3D'git'. But in our case they are = never > >>> run due to not using PATCH_COMMIT_FUNCTIONS in isar. > >>>=20 > >>> I suppose (but can't be completely sure without deep look to OE) that > >>> prefunc may fix this 'patch is allready applied' issue in OE. > >>=20 > >> If you can still reproduce the issue, just set PATCH_COMMIT_FUNCTIONS= =3D1 > >> to check if it has any impact. > >>=20 > >> Browsing poky and OE-core, I only find devtool setting this var. But > >> both aren't using git as patch tool anyway, a downstream layer/recipe > >> needs to requests that. > >>=20 > >> Jan > >=20 > > Yes, I also tried this way. > >=20 > > Actually, enabling PATCH_COMMIT_FUNCTIONS also forces to make some more > > changes in patch.bbclass (like sys.path.insert for OE lib path) that ma= kes > > the difference increase. > >=20 > > Anyway, even if this set to "1", the problem of patch reapply is still > > here - custom patch is going to be applied despite it was already done = on > > previous build. So, reset to SRC_REV is still required. >=20 > Strange. Did you try the same procedure in an OE setup, to compare what > happens there? >=20 > Jan Not yet, while it's expected to take much time to compile. Anyway, to catch the similar error, I need to find some package to rebuild = in=20 Yocto/OE that follows the approach similar to one isar's cowsay uses: a pat= ch=20 used by recipe that adds new patch to debian series. =2D-=20 Uladzimir Bely Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov