public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: Re: [PATCH] isar-image: Make do_rootfs normal shell function
Date: Fri, 7 Dec 2018 16:47:37 +0300	[thread overview]
Message-ID: <52981674-aa39-4b48-f87d-eda43a97343d@ilbers.de> (raw)
In-Reply-To: <07d197fb-ce72-ae62-4497-706221fbdeec@siemens.com>

On 12/6/18 11:13 AM, Jan Kiszka wrote:
> This restores logging support for the invoked subroutines which is more
> important then the convenience to chose python for overloading any of
> them.

Applied to the 'next',

Thanks,
Maxim.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> As it was the second time this annoyed me, remove this anti-pattern.
> 
>   meta/classes/isar-image.bbclass | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
> index 14b97dd..81738ff 100644
> --- a/meta/classes/isar-image.bbclass
> +++ b/meta/classes/isar-image.bbclass
> @@ -69,9 +69,9 @@ isar_image_cleanup() {
>       fi
>   }
>   
> -python do_rootfs() {
> -    bb.build.exec_func("isar_image_gen_fstab", d)
> -    bb.build.exec_func("isar_image_gen_rootfs", d)
> -    bb.build.exec_func("isar_image_conf_rootfs", d)
> -    bb.build.exec_func("isar_image_cleanup", d)
> +do_rootfs() {
> +    isar_image_gen_fstab
> +    isar_image_gen_rootfs
> +    isar_image_conf_rootfs
> +    isar_image_cleanup
>   }
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

      reply	other threads:[~2018-12-07 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06  8:13 Jan Kiszka
2018-12-07 13:47 ` Maxim Yu. Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52981674-aa39-4b48-f87d-eda43a97343d@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox