[PATCH] isar-image: Make do_rootfs normal shell function

[PATCH] isar-image: Make do_rootfs normal shell function

[Jan Kiszka]

This restores logging support for the invoked subroutines which is more
important then the convenience to chose python for overloading any of
them.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

As it was the second time this annoyed me, remove this anti-pattern.

 meta/classes/isar-image.bbclass | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index 14b97dd..81738ff 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -69,9 +69,9 @@ isar_image_cleanup() {
     fi
 }
 
-python do_rootfs() {
-    bb.build.exec_func("isar_image_gen_fstab", d)
-    bb.build.exec_func("isar_image_gen_rootfs", d)
-    bb.build.exec_func("isar_image_conf_rootfs", d)
-    bb.build.exec_func("isar_image_cleanup", d)
+do_rootfs() {
+    isar_image_gen_fstab
+    isar_image_gen_rootfs
+    isar_image_conf_rootfs
+    isar_image_cleanup
 }
-- 
2.16.4

Re: [PATCH] isar-image: Make do_rootfs normal shell function

[Maxim Yu. Osipov]

On 12/6/18 11:13 AM, Jan Kiszka wrote:
> This restores logging support for the invoked subroutines which is more
> important then the convenience to chose python for overloading any of
> them.

Applied to the 'next',

Thanks,
Maxim.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> As it was the second time this annoyed me, remove this anti-pattern.
> 
>   meta/classes/isar-image.bbclass | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
> index 14b97dd..81738ff 100644
> --- a/meta/classes/isar-image.bbclass
> +++ b/meta/classes/isar-image.bbclass
> @@ -69,9 +69,9 @@ isar_image_cleanup() {
>       fi
>   }
>   
> -python do_rootfs() {
> -    bb.build.exec_func("isar_image_gen_fstab", d)
> -    bb.build.exec_func("isar_image_gen_rootfs", d)
> -    bb.build.exec_func("isar_image_conf_rootfs", d)
> -    bb.build.exec_func("isar_image_cleanup", d)
> +do_rootfs() {
> +    isar_image_gen_fstab
> +    isar_image_gen_rootfs
> +    isar_image_conf_rootfs
> +    isar_image_cleanup
>   }
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov