From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631790245711970304 X-Received: by 2002:a05:6000:114e:: with SMTP id d14mr173879wrx.5.1544190465402; Fri, 07 Dec 2018 05:47:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:e919:: with SMTP id q25ls377905wmc.6.gmail; Fri, 07 Dec 2018 05:47:44 -0800 (PST) X-Google-Smtp-Source: AFSGD/W8PAQjKMuoJVv4Yzp5Qg2sIZLJ7rx/z0F/vpBfPSL+vIgOqSuWxXOX0WWuOJRBjYyF3rGm X-Received: by 2002:a1c:5412:: with SMTP id i18mr263168wmb.19.1544190464962; Fri, 07 Dec 2018 05:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544190464; cv=none; d=google.com; s=arc-20160816; b=VxBARprg32C6+k2MBizdycFOIETLNmMlqxe91KYuqJgKePrzIV6YO3+rr2zigo1m9b mek1bESKBda9n4vlK4XYyL150QRSJaphdpph+WO2+pv92++n4w5zW+kYj5QNXAuf/ZDL XUbHkIrugC8vjevPMJxz/AzYKezPhSSwnrw2P2Bs7JS9pV0GiwMtYC+lbWlEofDVyuar RsR7K8jswBgNyCUWQMEDFBD5Ai2WduvfgW+VJl8V3qiND3KrXR/Kt+RTYnU1v/fkq5rw 3Fd1dxcT8RquB4iyIG+uQX9ZH6Kz/RbL8Fwa8lGBPrK70TEZtIyCWxXFJOG4Hdg/tWI7 DiCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=LpVnncAWQsZqJKTKCQK1CuyoqA+FyB+ve39xvfth340=; b=C2DW6jzARdtIJaUfNjcgIxgrV2HrIwleB9zeQ6fiyv2baJs0VSDznuPd82KNtDRWL/ gxdNC2S6VY8/02+PUMVRJuZIpJ+ug286io18XzUAmr6XqwZ6j/kFcV2reuKyZtYT3W0O VwQ2q9jqERRHaKWN0ZMOSHKxsr57j/5oZwRS205Tg3Q+EVHp4tuZBU7HMsPnSKpNZVDJ 9TYx3aOGN0ukLpyKMDnQ7ryNhnSUF9uOIla1iCgxuZaV5b9fTIVnNgJgXQ8nPbzXk2eH DoJ2qONBsAiWaU/ekTZxg52Ozz9J4WsgEjYeHdh19pxQyyU6WpNa6EpmJ/ylE1ZMdUZ0 kzLA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id z207si76217wmc.2.2018.12.07.05.47.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 05:47:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wB7Dlg0r004605 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 7 Dec 2018 14:47:43 +0100 Subject: Re: [PATCH] isar-image: Make do_rootfs normal shell function To: Jan Kiszka , isar-users Cc: Cedric Hombourger References: <07d197fb-ce72-ae62-4497-706221fbdeec@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <52981674-aa39-4b48-f87d-eda43a97343d@ilbers.de> Date: Fri, 7 Dec 2018 16:47:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <07d197fb-ce72-ae62-4497-706221fbdeec@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: RYTkglFSVk1q On 12/6/18 11:13 AM, Jan Kiszka wrote: > This restores logging support for the invoked subroutines which is more > important then the convenience to chose python for overloading any of > them. Applied to the 'next', Thanks, Maxim. > Signed-off-by: Jan Kiszka > --- > > As it was the second time this annoyed me, remove this anti-pattern. > > meta/classes/isar-image.bbclass | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass > index 14b97dd..81738ff 100644 > --- a/meta/classes/isar-image.bbclass > +++ b/meta/classes/isar-image.bbclass > @@ -69,9 +69,9 @@ isar_image_cleanup() { > fi > } > > -python do_rootfs() { > - bb.build.exec_func("isar_image_gen_fstab", d) > - bb.build.exec_func("isar_image_gen_rootfs", d) > - bb.build.exec_func("isar_image_conf_rootfs", d) > - bb.build.exec_func("isar_image_cleanup", d) > +do_rootfs() { > + isar_image_gen_fstab > + isar_image_gen_rootfs > + isar_image_conf_rootfs > + isar_image_cleanup > } > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov