From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6566555412143800320 X-Received: by 2002:adf:9d84:: with SMTP id p4-v6mr77557wre.32.1528958678037; Wed, 13 Jun 2018 23:44:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7508:: with SMTP id o8-v6ls790895wmc.1.canary-gmail; Wed, 13 Jun 2018 23:44:37 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI5cqXK8Ouc18pqBT/9vQEuNXDRN5FD3IEJYlItCEaHIQjChsArin5wW2qYHY46UMAjZOwh X-Received: by 2002:a1c:9993:: with SMTP id b141-v6mr88646wme.20.1528958677530; Wed, 13 Jun 2018 23:44:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528958677; cv=none; d=google.com; s=arc-20160816; b=1FRSQZuOvyj2shWoLRpOtvP7Do5YeaP2TJH8wRJOUbNmJIZMNiniS5vhQc8Caa94ag XDMi4S7Q5etKvm+bKb34qAdvcc2OHq4+jM4s02NMCuZ4B4XkosUPEU0hhFRRwFd3lT0v rFZgFQ54ryMmcMkvjDaxQlIMx4D+v3csteqv9pfR81u7CTE3PWWzMn19PaTkKGbsOrVV mOG+gr/qZVvkgBLBX0zaNX6ni++k3HVsLXunWHPB4Vvs6ar4F4Vr4cafuQ1eCre4c0bZ HGNWvOUOYrBiSKvx6gSdNpmAc1RuLUsT8+mILIXW8234BH6l4MwkQ0gfZx6mkCtcSQNt K2mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=DFGXkSWABss9kGg1VGK99pQqXgoS6YXQBaOyARK5xGA=; b=tjWUFpJ5ti64e8kTvByLb9N57VnG4nrjoFfKnBYTeRwggg3QnHvEPcsytGsQ1Qr2hy i1vOmdR2gFkdllBe5efBuOeaF0ZVQrNmOjZV26pgvYqgATeIR93WX2+jXSsXMrxxXBCg 4mv877CR/Y/xvTzZ9XmxIOvVodKtTxFyloSLlQ4MkHWRd2vKzfYh1Y60Xqzu/lw+3WMz 98xvPpBuDv13XOus+k7fTZRWesHN2zkQcyz5kidFT8L9DkfKnnutA16ewfosBPWfoVxZ OgVQmfCXvv1ZD8kfd3wQc71e4QkPqvEy0yG7ollIfm/Ck3ogSicPpb/WKXvzPgcg+v2F BJRA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id a6-v6si40678wmg.4.2018.06.13.23.44.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jun 2018 23:44:37 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w5E6ib5a002994 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Jun 2018 08:44:37 +0200 Received: from [167.87.53.194] ([167.87.53.194]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w5E6iaKZ021204; Thu, 14 Jun 2018 08:44:36 +0200 Subject: Re: [PATCH 6/9] classes/dpkg*: Relocate dependency from buildchroot To: Alexander Smirnov , isar-users@googlegroups.com References: <20180613130807.2461-1-asmirnov@ilbers.de> <20180613130807.2461-7-asmirnov@ilbers.de> From: Jan Kiszka Message-ID: <52e8023e-b6b2-d4a0-4d92-36f9f6d03568@siemens.com> Date: Thu, 14 Jun 2018 08:44:36 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180613130807.2461-7-asmirnov@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: lL/o4A0vUK/A On 2018-06-13 15:08, Alexander Smirnov wrote: > Move dependency from buildchroot to the classes that actually require > buildchroot. This will make possible to re-use dpkg-base class for > buildchroot-cross. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/dpkg-base.bbclass | 3 --- > meta/classes/dpkg-raw.bbclass | 3 +++ > meta/classes/dpkg.bbclass | 3 +++ > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 75b45a7..24fe2ca 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -14,9 +14,6 @@ do_adjust_git[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > inherit patch > addtask patch after do_adjust_git before do_build > > -# Add dependency from buildchroot creation > -do_build[depends] = "buildchroot:do_build" > - > # Add dependency between Isar recipes > DEPENDS ?= "" > do_build[deptask] = "do_deploy_deb" > diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass > index 28233ac..5c7be6b 100644 > --- a/meta/classes/dpkg-raw.bbclass > +++ b/meta/classes/dpkg-raw.bbclass > @@ -6,6 +6,9 @@ inherit dpkg-base > DEBIAN_DEPENDS ?= "" > MAINTAINER ?= "FIXME Unknown maintainer" > > +# Add dependency from buildchroot creation > +do_build[depends] = "buildchroot:do_build" > + > D = "${WORKDIR}/image/" > > # Populate folder that will be picked up as package > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index c8d4ac5..c483fe2 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -3,6 +3,9 @@ > > inherit dpkg-base > > +# Add dependency from buildchroot creation > +do_build[depends] = "buildchroot:do_build" > + > # Build package from sources using build script > dpkg_runbuild() { > E="${@ bb.utils.export_proxies(d)}" > You also need to update meta/recipes-kernel/linux/linux-custom.inc. It inherits dpkg-base as well and, thus, now also needs this explicit dependency. Same is true for patch 7 regarding ROOTFS_DIR variable. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux