public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Claudius Heine <ch@denx.de>
Subject: [PATCH v2] Set STAMPCLEAN variable
Date: Wed, 14 Aug 2019 14:39:04 +0200	[thread overview]
Message-ID: <52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com> (raw)

This ensures that stamp files are cleaned when a task is rebuilt. Not
providing this pattern likely caused a lot of failures when doing
partial rebuilds.

As we are at it, switch do_clean to STAMPCLEAN as well.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/base.bbclass | 4 ++--
 meta/conf/bitbake.conf    | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index ca80bf8..b6638ca 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -206,8 +206,8 @@ python do_clean() {
     workdir = d.expand("${WORKDIR}")
     subprocess.check_call(["sudo", "rm", "-rf", workdir])
 
-    stamppath = bb.data.expand(d.getVar('STAMP', False), d)
-    stampdirs = glob.glob(stamppath + ".*")
+    stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
+    stampdirs = glob.glob(stampclean)
     subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
 }
 
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 3d18223..ee86ee0 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
 AUTOREV = "${@bb.fetch2.get_autorev(d)}"
 SRC_URI = "file://${FILE}"
 STAMP = "${TMPDIR}/stamps/${PF}"
+STAMPCLEAN = "${TMPDIR}/stamps/${PN}-*"
 SVNDIR = "${DL_DIR}/svn"
 T = "${WORKDIR}/temp"
 TMPDIR = "${TOPDIR}/tmp"
-- 
2.16.4


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

             reply	other threads:[~2019-08-14 12:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 12:39 Jan Kiszka [this message]
2019-08-14 14:10 ` Claudius Heine
2019-08-14 14:17   ` Jan Kiszka
2019-08-19 19:00     ` Jan Kiszka
  -- strict thread matches above, loose matches on Subject: below --
2019-08-12 17:15 Jan Kiszka
2019-08-13  7:27 ` Claudius Heine
2019-08-13  8:01   ` Jan Kiszka
2019-08-13  8:17     ` Claudius Heine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox