From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044773043327991808 X-Received: by 2002:adf:e444:: with SMTP id t4mr7176039wrm.325.1641819013667; Mon, 10 Jan 2022 04:50:13 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:2142:: with SMTP id h63ls6512014wmh.0.canary-gmail; Mon, 10 Jan 2022 04:50:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4PbS/Gs8rk5NeJqGSfXMGK0EWivuc9YN0QyoU1X+xvdwFOoyzCcaZ5dUuD7RaYikKx5/3 X-Received: by 2002:a7b:c10b:: with SMTP id w11mr2778376wmi.192.1641819012620; Mon, 10 Jan 2022 04:50:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641819012; cv=none; d=google.com; s=arc-20160816; b=glFkH3h+T+D/o+cfdsCqYIYdA6k75oZAuPIH7ARrHz3QXsuJq2L+NgAoQtltQvCzGL epSfQ07ZpqeCHUKHfTzKai2cvBE6hjjlJopXegSpbisaUZzhzSkooPUSnrNcr2Tv807E aa0t0tHDAG/LC8hFdETWUiRWv3aTZBWwzNl8Dr8rE6Xe+dFK7/eRWZ4gItpBcCI8iwNz 1Ue017zIzimjS/4jewE2YstpuEgECIorxTW7zHgUJL3/ljlLmSZqFaJ962UdtixwSllH n76Fv6w9CzmNj4L8nb7fYT2uynwcRzvRU6ZtAXD8XKSmZa6Mo0S3I87NOVx/32dD5Wgi +Img== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=qKZiwb9n2Cf7LbWVWoBNRRTwTsXQSJmMdAQDg6nEhi0=; b=kVucNyhtFY6CzZ5C+dHOev7lSxbwt3GvWCVNrpczuHOjVesahUwWPHWYS4r1QF+PWZ tvMf7I9lCwpt5fbRDLiG8I+8q/GLCOEX9vetgmL/U2IVtzK84DbagSVZP9wgKVtBz2OG z4jW5FCMy0IzPsbTXs5D2zEqPg5D+KoJgWWWgR5ZLD/b0360SoQprxv1D7lNXsTaOR9V dSupyt2kU6O5dZ5WLgh/bQsylt+3BEXYZu4FqqxYvdjJFu9IoewxCiCrGWKCLQ2ORfuQ WlLq50haxE6M4Umlnajh62BPB+FJbcfqkJof5eb0Y1yVuDpOlXiw2JNtJ/VJ+Z9c1jy9 vHgw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id m12si215157wrp.3.2022.01.10.04.50.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Jan 2022 04:50:12 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from hp.localnet (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 20ACo1K3018928 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jan 2022 13:50:11 +0100 From: Uladzimir Bely To: Henning Schild Cc: isar-users@googlegroups.com Subject: Re: [PATCH] ci: make vm_start logs readable by all users Date: Mon, 10 Jan 2022 15:50:00 +0300 Message-ID: <5338758.rdbgypaU67@hp> In-Reply-To: <20220104205839.2fdbb6c9@md1za8fc.ad001.siemens.net> References: <20211223055720.4147-1-ubely@ilbers.de> <20220104205839.2fdbb6c9@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: xeiGposyhQiK In mail from =D0=B2=D1=82=D0=BE=D1=80=D0=BD=D0=B8=D0=BA, 4 =D1=8F=D0=BD=D0= =B2=D0=B0=D1=80=D1=8F 2022 =D0=B3. 22:58:39 +03 user Henning Schild wrote: > Am Thu, 23 Dec 2021 06:57:20 +0100 >=20 > schrieb Uladzimir Bely : > > This changes permissions for ${BUILD_DIR}/vm_start_.*_log.txt from 600 > > to 644 to make them readable not only for jenkins user. >=20 > not everybody uses jenkins ... make it "CI user" >=20 OK. > > Signed-off-by: Uladzimir Bely > > --- > >=20 > > testsuite/vm_boot_test/vm_boot_test.py | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/testsuite/vm_boot_test/vm_boot_test.py > > b/testsuite/vm_boot_test/vm_boot_test.py index 01623c5c..69e7f4ae > > 100644 --- a/testsuite/vm_boot_test/vm_boot_test.py > > +++ b/testsuite/vm_boot_test/vm_boot_test.py > >=20 > > @@ -46,6 +46,7 @@ class VmBase(Test): > > fd, output_file =3D tempfile.mkstemp(suffix=3D'_log.txt', > > =20 > > prefix=3D'vm_start_' + > >=20 > > distro + '_' + arch + '_', dir=3Dbuild_dir, text=3DTrue) > > + os.chmod(output_file, 0o644) >=20 > This smells like other output files could also have wrong permissions > while being relevant. It looks like a specific behaviour of tempfile.mkstemp() function, that alw= ays=20 creates file readable/writable only by the user ID. So, only vm logs are=20 affected. > If that might be the case, maybe centrally adjust umask for all of the > testsuite. I've just played a bit with umask and it seems to work nice with something= =20 like 'touch', but python's tempfile.mkstemp() still always creates files wi= th=20 0600 permissions, regardless of umask set for the same directory. >=20 > Henning >=20 > > cmdline =3D start_vm.format_qemu_cmdline(arch, build_dir, > >=20 > > distro, output_file, None)