public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH v2 1/8] crossvars: Account for PACKAGE_ARCH = "${BUILD_ARCH}"
Date: Tue,  9 Jan 2024 08:33:17 +0100	[thread overview]
Message-ID: <53436f40b81b741acc11a791d1cd1a7bebe4f0f9.1704785604.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1704785604.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

95427cc8 forgot about the case that PACKAGE_ARCH is to be derived from
BUILD_ARCH - while that is considering PACKAGE_ARCH before setting
BUILD_ARCH at all. Account for that case by adding the unresolved value
of PACKAGE_ARCH into the cross-build case because that is what the
statement is about: Set PACKAGE_ARCH to HOST_ARCH only if cross-building
is enabled for a package.

Fixes: 95427cc8a760 ("crossvars: Adjust logic to account for -native package builds in non-cross setups")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/crossvars.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass
index a7834b99..828afe46 100644
--- a/meta/classes/crossvars.bbclass
+++ b/meta/classes/crossvars.bbclass
@@ -22,7 +22,7 @@ python __anonymous() {
 
     if distro_arch != host_arch and \
         (package_arch == host_arch or \
-         (package_arch in [distro_arch, compat_arch] and mode == "1")):
+         (package_arch in [distro_arch, compat_arch, '${BUILD_ARCH}'] and mode == "1")):
         d.setVar('BUILD_ARCH', host_arch)
         schroot_dir = d.getVar('SCHROOT_HOST_DIR', False)
         sbuild_dep = "sbuild-chroot-host" + flavor_suffix + ":do_build"
-- 
2.35.3


  reply	other threads:[~2024-01-09  7:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09  7:33 [PATCH v2 0/8] Restore cross-build for RISC-V, update VisionFive 2 Jan Kiszka
2024-01-09  7:33 ` Jan Kiszka [this message]
2024-01-09  7:33 ` [PATCH v2 2/8] meta-isar: jh7110-u-boot-spl-tool: Use BPN instead of PN Jan Kiszka
2024-01-09  7:33 ` [PATCH v2 3/8] meta-isar: starfive-visionfive2: Use kernel DTB Jan Kiszka
2024-01-09  7:33 ` [PATCH v2 4/8] meta-isar: jh7110-u-boot-spl-tool: Rework Jan Kiszka
2024-01-09  7:33 ` [PATCH v2 5/8] meta-isar: starfive-visionfive2: Switch to upstream U-Boot Jan Kiszka
2024-01-09  7:33 ` [PATCH v2 6/8] meta-isar: starfive-visionfive2: Drop obsolete recipes Jan Kiszka
2024-01-09  7:33 ` [PATCH v2 7/8] meta-isar: linux-mainline: Update to 6.6.10 Jan Kiszka
2024-01-09  7:33 ` [PATCH v2 8/8] meta-isar: Switch VisionFive 2 to mainline kernel Jan Kiszka
2024-01-16 11:08   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53436f40b81b741acc11a791d1cd1a7bebe4f0f9.1704785604.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox