Re: [PATCH v3 2/3] sbuild: Set high prio for the packages from isar-apt repo

[Uladzimir Bely <ubely@ilbers.de>]

In the email from Wednesday, 11 January 2023 20:34:27 +03 user Jan Kiszka 
wrote:
> On 11.01.23 15:52, Jan Kiszka wrote:
> > On 11.01.23 15:36, Jan Kiszka wrote:
> >> On 31.10.22 07:06, Uladzimir Bely wrote:
> >>> This sets high priority for `isar-apt` repo during sbuild session.
> >>> So, even if some dependency in other repos has higher version than
> >>> one we previously built and placed in isar-apt, the second one wil
> >>> be selected.
> >>> 
> >>> This repeats the behaviour that is implemented in rootfs.bbclass
> >>> via `rootfs_configure_isar_apt` that is disabled for sbuild chroot.
> >>> 
> >>> We can't simply enable this task for sbuild while we don't want to
> >>> have `/etc/apt/sources.list.d/isar-apt.list` file in sbuild chroot
> >>> while it's handled via sbuild by `--extra-repository` option
> >>> 
> >>> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> >>> ---
> >>> 
> >>>  meta/classes/dpkg.bbclass | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>> 
> >>> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> >>> index dfa097f8..c7e7dd34 100644
> >>> --- a/meta/classes/dpkg.bbclass
> >>> +++ b/meta/classes/dpkg.bbclass
> >>> @@ -91,6 +91,7 @@ dpkg_runbuild() {
> >>> 
> >>>          --host=${PACKAGE_ARCH} --build=${SBUILD_HOST_ARCH} ${profiles}
> >>>          \
> >>>          --no-run-lintian --no-run-piuparts --no-run-autopkgtest
> >>>          --resolve-alternatives \ --no-apt-update \
> >>> 
> >>> +        --chroot-setup-commands="echo \"Package: *\nPin: release
> >>> n=${DEBDISTRONAME}\nPin-Priority: 1000\" >
> >>> /etc/apt/preferences.d/isar-apt" \>>> 
> >>>          --chroot-setup-commands="rm -f /var/log/dpkg.log" \
> >>>          --chroot-setup-commands="cp -n --no-preserve=owner
> >>>          ${ext_deb_dir}/*.deb -t ${deb_dir}/ || :" \
> >>>          --finished-build-commands="rm -f
> >>>          ${deb_dir}/sbuild-build-depends-main-dummy_*.deb" \>> 
> >> This remains a nop, doesn't it? There is no isar-apt in sbuild-chroot as
> >> far as I understand the logic so far. I didn't understand yet how
> >> isar-apt packages are otherwise injected into the build env, but this is
> >> not working at all.
> > 
> > Finally found it: sbuild --extra-repository ...
> > 
> >> What definitely works better here is properly
> >> mounting isar-apt into the schroot via its config.
> > 
> > That was too fast, still no preferences in effect here.
> > 
> > Could it be that we would need some "--extra-preferences" (which do not
> > exist) because sbuild creates a clean /etc/apt for the build, ignoring
> > the preferences in the schroot?
> 

Hi.
Yes, sbuild uses clean /etc/apt, so this additional command was required when 
I was fixing the "isar-apt prio" issue. For "pure" schroot there might be 
another way to inherit apt preferences, but I didn't test how it would works 
in devshell.

> No, preferences are working. I'm "just" seeing local conflicts of
> incomplete essential package rebuilds (missing archs) that were surfaced
> by my latest sbuild-chroot optimizations.
> 
> So we are just left with the inconsistency in the devshell which sent me
> down the wrong road. Patch will follow.
> 
> Jan