From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Anton Mikanovich <amikan@ilbers.de>,
isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] meta-isar: Use exact matches for COMPATIBLE_MACHINE
Date: Tue, 16 Dec 2025 12:24:01 +0100 [thread overview]
Message-ID: <53f18241-b111-4441-89a4-778405e4b287@siemens.com> (raw)
In-Reply-To: <82086aa7-dde7-4b05-be54-7c8e3ede35a0@ilbers.de>
On 16.12.25 10:41, Anton Mikanovich wrote:
> Hello Jan,
>
> 12/12/2025 22:04, 'Jan Kiszka' via isar-users wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> COMPATIBLE_MACHINE is evaluated as regular expression. To avoid wrong
>> matches in the future or with downstream layers, make sure that we only
>> match if the current machine is identical to the expected one.
>>
>> Brackets are not strictly needed for the match but improve readability.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> meta-isar/recipes-bsp/bootconfig-rpi/bootconfig-rpi.bb | 2 +-
>> .../jh7110-u-boot-spl-tool/jh7110-u-boot-spl-tool_0.2.bb | 2 +-
>> meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_1.1.bb | 2 +-
>> .../recipes-bsp/opensbi/opensbi-starfive-visionfive2_1.4.bb | 2 +-
>> .../recipes-bsp/optee-client/optee-client-stm32mp15x_3.21.0.bb | 2 +-
>> .../optee-examples/optee-examples-stm32mp15x_3.21.0.bb | 2 +-
>> .../optee-ftpm/optee-ftpm-stm32mp15x_0~230316+git.bb | 2 +-
>> meta-isar/recipes-bsp/optee-os/optee-os-beagleplay_4.0.0.bb | 2 +-
>> meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.21.0.inc | 2 +-
>> .../trusted-firmware-a/trusted-firmware-a-beagleplay_2.10.bb | 2 +-
>> .../trusted-firmware-a/trusted-firmware-a-stm32mp15x_2.4.bb | 2 +-
>> meta-isar/recipes-bsp/u-boot/u-boot-beagleplay_2025.10.bb | 2 +-
>> meta-isar/recipes-bsp/u-boot/u-boot-de0-nano-soc_2020.10.bb | 2 +-
>> .../recipes-bsp/u-boot/u-boot-starfive-visionfive2_2024.01.bb | 2 +-
>> meta-isar/recipes-bsp/u-boot/u-boot-stm32mp15x_2020.10.bb | 2 +-
>> meta-isar/recipes-kernel/linux/linux-phy_6.12.58.bb | 2 +-
>> .../recipes-kernel/linux/linux-starfive_6.6.20-visionfive2.bb | 2 +-
>> 17 files changed, 17 insertions(+), 17 deletions(-)
>>
>> diff --git a/meta-isar/recipes-bsp/bootconfig-rpi/bootconfig-rpi.bb b/
>> meta-isar/recipes-bsp/bootconfig-rpi/bootconfig-rpi.bb
>> index 91ae221d..299e2488 100644
>> --- a/meta-isar/recipes-bsp/bootconfig-rpi/bootconfig-rpi.bb
>> +++ b/meta-isar/recipes-bsp/bootconfig-rpi/bootconfig-rpi.bb
>> @@ -27,4 +27,4 @@ do_install() {
>> fi
>> }
>> -COMPATIBLE_MACHINE = "rpi"
>> +COMPATIBLE_MACHINE = "^(rpi)$"
> We have different rpi machines (rpi-arm, rpi-arm-v7, rpi-arm-v7l, rpi-
> arm64-v8, rpi-arm64-v8-efi),
> so here it was really used for multiple machines.
> We should have more complex regexp for bootconfig recipe here.
So "^rpi-arm.*" then? Just "rpi" was highly risky for downstream.
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/53f18241-b111-4441-89a4-778405e4b287%40siemens.com.
prev parent reply other threads:[~2025-12-16 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 20:04 'Jan Kiszka' via isar-users
2025-12-16 9:41 ` Anton Mikanovich
2025-12-16 11:24 ` 'Jan Kiszka' via isar-users [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f18241-b111-4441-89a4-778405e4b287@siemens.com \
--to=isar-users@googlegroups.com \
--cc=amikan@ilbers.de \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox