Re: [PATCH] image: check if the file is core dump

[Uladzimir Bely <ubely@ilbers.de>]

On Tue, 2024-04-16 at 23:50 -0700, Zhibin Dong wrote:
> How about using `--mime-type`?
> 
> 在2024年4月17日星期三 UTC+8 14:47:25<Zhibin Dong> 写道：
> > The previous code does a wrong judgement in two cases:
> > 1. a file is suffixed by .core but is not a core dump file
> > 2. a file is a core dump file but is not suffixed by .core
> > 
> > The new code uses `file` to determine the type of files, which is
> > more
> > accurate.
> > 
> > Signed-off-by: Zhibin Dong <zhibi...@siemens.com>
> > ---
> >  meta/classes/image.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/image.bbclass
> > b/meta/classes/image.bbclass
> > index 98741da0..2b0995d2 100644
> > --- a/meta/classes/image.bbclass
> > +++ b/meta/classes/image.bbclass
> > @@ -444,7 +444,7 @@ EOSUDO
> >  
> >  # Sometimes qemu-user-static generates coredumps in chroot, move
> > them
> >  # to work temporary directory and inform user about it.
> > - for f in $(sudo find ${ROOTFSDIR} -type f -name *.core); do
> > + for f in $(sudo find ${ROOTFSDIR} -type f -exec file --mime-type
> > {} \; | grep 'application/x-coredump' | cut -d: -f1); do
> >  sudo mv "${f}" "${WORKDIR}/temp/"
> >  bbwarn "found core dump in rootfs, check it in
> > ${WORKDIR}/temp/${f##*/}"
> >  done

Applied to next, thanks.

-- 
Best regards,
Uladzimir.