From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6875334414772994048 X-Received: by 2002:a1c:3285:: with SMTP id y127mr3533749wmy.183.1602077810621; Wed, 07 Oct 2020 06:36:50 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:428e:: with SMTP id k14ls2925392wrq.0.gmail; Wed, 07 Oct 2020 06:36:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUhHWNUPPvbkuN+wMuOh2MViXACpGpBj11kUw/8wmtjcuoUjfzIT5PL5Fz58bcOXSiJuGj X-Received: by 2002:adf:df07:: with SMTP id y7mr3925228wrl.347.1602077809468; Wed, 07 Oct 2020 06:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602077809; cv=none; d=google.com; s=arc-20160816; b=t1zZ7XErLIOW1jM3sIvuwnTNEIjAmVwcVxwQLyrs6SZanoMHWnLJBDkr/ptUxWRHew lV02lhqldsruRWoUo0D1zzSVa5quLSdkpVcguYyi4QRis3VUJ1M5eVzvNyaVJF/UfePZ 0w8tCtpcZLVtzrCpcG5MeCoVv+59aUVcBJ4GZm7XiZxZ4TZA4Z5YB86STE/+pHZKel/s Gu6mtIVmGT72m8zM0nicHLvhXBzhJ/5eWHApivdvc90agOUm0p/YhpRvhbPeqytKP557 2eME/s7IvL//sF5Ne5gxB0IzUeg18DlROAyOmXiiPzuI7fazoir2t+VwQG2N8GqVMhBD 8nug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=p2UA0d0ofCL8vUKBWae2w7Q8HOOesik1UdN8QBqKMDE=; b=acoIGuzs1jCtR97AaOFllE6SdM30+VrFAaRyaZv2mz4E4T8j7EVTJqAP1qTi2IvQ7m cxs0HPvvnfADX7hlUoBo53WIoYIHMH1Cxkrz2pr0/sL0VQDZWtovZV17jwp5P3q+MGcw mat+5v7mdb8P7OoardlrLtnaTNONXhHsuAWVg6VR+j5nlQm+Ox4KuWvwQROD49KP6nvh /VZ+P40kdGIcA0t03rO9aUqXC1GCPUdQjagwEe6SQn0NMSR52qjS/QVJq8+khJtt5FZW BkRbQVvPZn5qBu56XXaIB6Lk3DbpJ996IV6EGMpXkOe7XS4/Rx+CdsPxWMgpACUaG8c9 gA1Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f144si161141wmf.0.2020.10.07.06.36.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Oct 2020 06:36:49 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 097DanJh013590 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 7 Oct 2020 15:36:49 +0200 Received: from [139.22.113.50] ([139.22.113.50]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 097DalQ3020182 for ; Wed, 7 Oct 2020 15:36:48 +0200 Subject: Re: [PATCH v3 06/16] sdk: Add support for adding self-defined sdk packages To: isar-users@googlegroups.com References: <20200929191526.GD5400@yssyq.m.ilbers.de> <20201006090015.GE5019@yssyq.m.ilbers.de> <9f4047a0-d11f-adff-1601-643b4e8a5cae@siemens.com> <20201007080638.GI5019@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: <542d2f98-574d-4c14-0eae-098da5f73730@siemens.com> Date: Wed, 7 Oct 2020 15:36:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201007080638.GI5019@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: kk/iI5JPz0Mr On 07.10.20 10:06, Baurzhan Ismagulov wrote: > On Wed, Oct 07, 2020 at 09:30:06AM +0200, Jan Kiszka wrote: >> OK, need to check again. Cannot explain yet why that should happen, >> given the change in patch 9. Maybe I have a regression further down the >> series... > > Thanks, please let us know. I also stared at the line for some time and > couldn't see what is wrong. > Fixed: test with "==", rather than "=". Cleaned up more around that. Will send v4. > >>> This explains to the user how Debian multiarch works with option 2. This >>> example works inside or outside of the chroot. We should not be removing >>> documentation for a supported use case, thus NAK here. >>> >> >> This hunk looks pointless to me. Why should the user try out all that >> stuff? It's the duty of the SDK creator to do that upfront and ship a >> properly working package. > > Trying in the context of SDK -- that's a matter of taste, I like when some > background is presented rather than "do 1, 2, 3", sometimes without > understanding what I'm really doing. The hunk explains how Debian officially > handles cross-building with multiarch, so I'd be reluctant to remove that > completely. Maybe we could make it a separate section on Debian basics or > details how SDK option 2 is implemented. I'm all for adding relevant information, but this one does not qualify. Checking for the toolchain being install was always completely pointless in the context of an SDK that always has this pre-installed according to our recipes. And since isar-apt is now a special case and SDK_INSTALL will ensure that all required packages are already installed, the second hint is also irrelevant for normal users. It is only for the case of SDK_INCLUDE_ISAR_APT = 1 *and* SDK_INSTALL *not* listing self-built devel packages needed for building applications. If you have other information that may help users with using the SDK in chroot mode, feel free to add that on top. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux