From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7180000193640660992 X-Received: by 2002:a05:6102:3214:b0:3ce:8f56:67c1 with SMTP id r20-20020a056102321400b003ce8f5667c1mr1168168vsf.70.1672815889722; Tue, 03 Jan 2023 23:04:49 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6102:23cc:b0:3b1:1703:92cb with SMTP id x12-20020a05610223cc00b003b1170392cbls8176218vsr.1.-pod-prod-gmail; Tue, 03 Jan 2023 23:04:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXs2xkhkoQzVabOsqKoEyL6H404QuUO+VzNjC/OzsRTyi+Z89mZ/IocTBopHt1/giwfH2SRN X-Received: by 2002:a67:f785:0:b0:3ce:a272:722b with SMTP id j5-20020a67f785000000b003cea272722bmr2506839vso.8.1672815888903; Tue, 03 Jan 2023 23:04:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672815888; cv=none; d=google.com; s=arc-20160816; b=dFEq0vJoNPBge71HTUyueZCg4z2uXxbf2SdE6mkKeosQNEFS8vNOofv9eiE3lDm3wl rU6wpKp5iPstx4V2PJ7NZVLv+XtZRINLdC/BXVzhaAgwsQKqmGqIiX0T4ULZ9Z5llobV fF4/8D8voCK1f3+jIjTdztuNW8UL2Vhbp8XRaMEBMVxFeQFT1TJvmko5jxsDiUMOfrej 9fR0S6pBKVMgraZARwZyoK3dMHHOndAJpIRnu3ZsbNB+OCu1EWZF1fxu3+fP9LAtPnM5 kgAIQyXVudgyirvTh+gQUNp+FbhPaXHz6VWagO+p1wYT61X1Hn2JKZHvrggkQA2xIxI3 OI9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=ajHADZZ4lxwi/x/fEEbCuIZQoTxXoVFWbC/Hvt6D7d0=; b=bvP0nTOsOKxD5pw/hqeIP4oF7Wnv/93+M6qi2eIYjMBTCzG31Q+o29/VrhK+Uqi1SO u1SDIw+9M6jqOne+F9BDlgCOx2M4syfaMAHrW2uNA5AgjjSfjQIpaha8LcPU/RYgYpz2 1ag5/Um3GrkEdnYw56KDqJWKDOnKofbVkm6ncv5xWUm6ezjwxSnLMOzlGVRv9k973awH AqwuAPYtU9BV43DhJxnjna/9ubi6+LWBR77GwSqz66w6/yPIem4dS9sEU99mu2bJFL27 oAR2urM6x3lezB3HHjyBbjhrCoScUUecZJjrARd1PCPd+duYzVJI4KBf/qXIoTQnmFJ7 sQiA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id j5-20020a67e305000000b003ce9fcc1ea2si260093vsf.0.2023.01.03.23.04.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jan 2023 23:04:48 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 30474kRd001433 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 Jan 2023 08:04:46 +0100 From: Uladzimir Bely To: Henning Schild Cc: isar-users@googlegroups.com Subject: Re: [PATCH v3] meta: drop debian stretch support Date: Wed, 04 Jan 2023 10:04:48 +0300 Message-ID: <5438450.rdbgypaU67@home> In-Reply-To: <20230102230302.5055b112@md1za8fc.ad001.siemens.net> References: <20221227063555.22836-1-amikan@ilbers.de> <20230102165624.635728f9@md1za8fc.ad001.siemens.net> <20230102230302.5055b112@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: UrRYQgmjDMA1 In the email from Tuesday, 3 January 2023 01:03:02 +03 user Henning Schild wrote: > On Mon, 2 Jan 2023 16:56:24 +0100 > > Henning Schild wrote: > > This one maybe should have waited a little longer for review, it fell > > right into the time between christmas and new year. > > > > A changelog to v1 would have been nice, or a reply to my review > > comments i gave. > > > > Am Tue, 27 Dec 2022 09:35:55 +0300 > > > > schrieb Anton Mikanovich : > > > Debian Stretch state was moved to EOL since July 2020, so drop it. > > > This will allow us to get rid of many hacks inside Isar core and > > > single example packages. > > > Also drop raspbian-stretch distro and rpi machine used it. > > > Drop wic_fakeroot fsck hack because it is no more needed. > > > > > > Update documentation to remove Debian Stretch there also. > > > > > > Signed-off-by: Anton Mikanovich > > > --- > > > > > > README.md | 2 +- > > > doc/offline.md | 4 +- > > > doc/technical_overview.md | 6 +-- > > > doc/user_manual.md | 48 > > > > > > +++++++------------ meta-isar/conf/distro/raspbian-stretch.conf | > > > 17 ------- meta-isar/conf/distro/raspbian-stretch.list | 2 - > > > > > > meta-isar/conf/local.conf.sample | 7 --- > > > meta-isar/conf/machine/rpi.conf | 8 ---- > > > .../multiconfig/container-amd64-stretch.conf | 7 --- > > > .../conf/multiconfig/qemuamd64-stretch.conf | 5 -- > > > .../conf/multiconfig/qemuarm-stretch.conf | 5 -- > > > .../conf/multiconfig/qemuarm64-stretch.conf | 6 --- > > > .../conf/multiconfig/qemui386-stretch.conf | 5 -- > > > .../conf/multiconfig/qemumipsel-stretch.conf | 5 -- > > > meta-isar/conf/multiconfig/rpi-stretch.conf | 47 > > > > > > ------------------ meta/classes/buildchroot.bbclass | > > > 3 +- meta/classes/dpkg-gbp.bbclass | 7 +-- > > > > > > meta/classes/image.bbclass | 2 - > > > meta/classes/sbuild.bbclass | 3 +- > > > meta/conf/distro/debian-stretch.conf | 17 ------- > > > meta/conf/distro/debian-stretch.list | 8 ---- > > > .../files/isar-apt-fallback.conf | 4 -- > > > .../isar-bootstrap/isar-bootstrap.inc | 18 +------ > > > meta/recipes-kernel/linux/linux-custom.inc | 1 - > > > scripts/start_vm | 2 +- > > > scripts/wic_fakeroot | 8 ---- > > > > I think this complete file can be removed. Not sure how i said it in > > my review to v1. Right now this wrapper does nothing but wrap. All the > > work it used to do has been deprecated and removed. > > > > I suggest to throw a patch on top to remove the file and set > > > > FAKEROOTCMD ?= "true;" > > > > like the removed comment suggested. > > I tried dropping the now seemingly useless wrapper but that somehow did > not work like it used to. So maybe we need to keep it after all. > > But it would be nice to know why we need to have it in place and have > that written down in a comment and a commit message. > > regards, > Henning > Hello. I've experimented with this FAKEROOTCMD a bit and it seems we really still need it. It really almost dummy except removing first argument from command line passed (`args.pop(0)`) and it seems to be the main thing we want from it (removing "pseudo" or "fakeroot"?). Simple replacing the script call with `true` command doesn't work as well as attempt to use this logic without `pop(0)`. -- Uladzimir Bely