From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7203376969598107648 X-Received: by 2002:a5b:d45:0:b0:a58:7139:cf85 with SMTP id f5-20020a5b0d45000000b00a587139cf85mr815877ybr.13.1677566414863; Mon, 27 Feb 2023 22:40:14 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a25:5206:0:b0:98d:d8a0:6318 with SMTP id g6-20020a255206000000b0098dd8a06318ls6998916ybb.4.-pod-prod-gmail; Mon, 27 Feb 2023 22:40:14 -0800 (PST) X-Google-Smtp-Source: AK7set8GBLKdPoUN5wADCrbOgf8umeV6cnoJguBgoWRawIKJDGvcYFWu3lyuifira9NwKp1m06C/PhTZZQ== X-Received: by 2002:a05:6902:161a:b0:8a3:d147:280b with SMTP id bw26-20020a056902161a00b008a3d147280bmr1935627ybb.3.1677566413838; Mon, 27 Feb 2023 22:40:13 -0800 (PST) X-Google-Web-Client: true Date: Mon, 27 Feb 2023 22:40:13 -0800 (PST) From: Cedric Hombourger To: isar-users Message-Id: <54d90fb4-72e0-4b13-ac72-ce30534a7fefn@googlegroups.com> In-Reply-To: <20230223154131.132362-7-amikan@ilbers.de> References: <20230223154131.132362-1-amikan@ilbers.de> <20230223154131.132362-7-amikan@ilbers.de> Subject: Re: [PATCH 06/11] CI: Make quite option to be set by default MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_136_1230823385.1677566413544" X-TUID: 48osHuFPSQjO ------=_Part_136_1230823385.1677566413544 Content-Type: multipart/alternative; boundary="----=_Part_137_658407701.1677566413544" ------=_Part_137_658407701.1677566413544 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thursday, February 23, 2023 at 4:41:44=E2=80=AFPM UTC+1 Anton Mikanovich= wrote: It looks like nobody run bitbake with additional verbose during=20 normal testsuite operation, so set non verbose output ("quite") to=20 be default one. Verbose output still can be enabled by adding=20 "-p quite=3D0" directly to avocado command. typo: quite =3D> quiet =20 Signed-off-by: Anton Mikanovich =20 ---=20 .gitlab-ci.yml | 6 +++---=20 scripts/ci_build.sh | 7 ++-----=20 testsuite/README.md | 4 ++--=20 testsuite/cibuilder.py | 2 +-=20 4 files changed, 8 insertions(+), 11 deletions(-)=20 diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml=20 index f9235fc..eb38be5 100644=20 --- a/.gitlab-ci.yml=20 +++ b/.gitlab-ci.yml=20 @@ -27,14 +27,14 @@ dev-ci:=20 except:=20 - schedules=20 script:=20 - - scripts/ci_build.sh -q -T dev=20 + - scripts/ci_build.sh -T dev=20 fast-ci:=20 <<: *common-build=20 only:=20 - schedules=20 script:=20 - - scripts/ci_build.sh -q -T fast=20 + - scripts/ci_build.sh -T fast=20 full-ci:=20 <<: *common-build=20 @@ -44,7 +44,7 @@ full-ci:=20 - PREVIOUS_SHA=3D"$(cat .CI_COMMIT_SHA || true)"=20 - if [ "$CI_COMMIT_SHA" !=3D "$PREVIOUS_SHA" ]; then=20 echo "$CI_COMMIT_SHA" > .CI_COMMIT_SHA;=20 - scripts/ci_build.sh -q -T full;=20 + scripts/ci_build.sh -T full;=20 fi=20 cache:=20 key: "$CI_COMMIT_REF_SLUG"=20 diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh=20 index 9f62db5..fcac180 100755=20 --- a/scripts/ci_build.sh=20 +++ b/scripts/ci_build.sh=20 @@ -50,7 +50,6 @@ show_help() {=20 echo " the tests will be started in current path."=20 echo " -d, --debug enable debug bitbake output."=20 echo " -T, --tags specify basic avocado tags."=20 - echo " -q, --quiet suppress verbose bitbake output."=20 echo " -n, --norun do not execute QEMU run tests."=20 echo " --help display this message and exit."=20 echo=20 @@ -59,8 +58,6 @@ show_help() {=20 echo " 3 if invalid parameters are passed."=20 }=20 -QUIET=3D"0"=20 -=20 # Parse command line to get user configuration=20 while [ $# -gt 0 ]=20 do=20 @@ -88,7 +85,7 @@ do=20 echo "warning: deprecated parameter '$key', consider using '-T fast'=20 instead"=20 ;;=20 -q|--quiet)=20 - QUIET=3D"1"=20 + echo "warning: deprecated parameter '$key', it is applied by default"=20 ;;=20 -n|--norun)=20 NORUN=3D"1"=20 @@ -151,4 +148,4 @@ set -x=20 avocado ${VERBOSE} run "${TESTSUITE_DIR}/citest.py" \=20 -t "${TAGS}" ${PARALLEL} --disable-sysinfo \=20 - -p quiet=3D"${QUIET}" ${TIMEOUT}=20 + ${TIMEOUT}=20 diff --git a/testsuite/README.md b/testsuite/README.md=20 index 10fbd79..c9d5862 100644=20 --- a/testsuite/README.md=20 +++ b/testsuite/README.md=20 @@ -27,13 +27,13 @@ $ avocado run ../testsuite/citest.py -t single=20 --max-parallel-tasks=3D1 -p machine=20 ## Fast build test=20 ```=20 -$ avocado run ../testsuite/citest.py -t fast --max-parallel-tasks=3D1 -p= =20 quiet=3D1=20 +$ avocado run ../testsuite/citest.py -t fast --max-parallel-tasks=3D1=20 ```=20 ## Full build test=20 ```=20 -$ avocado run ../testsuite/citest.py -t full --max-parallel-tasks=3D1 -p= =20 quiet=3D1=20 +$ avocado run ../testsuite/citest.py -t full --max-parallel-tasks=3D1=20 ```=20 ## Fast boot test=20 diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py=20 index 65eeb4b..0a07bf0 100755=20 --- a/testsuite/cibuilder.py=20 +++ b/testsuite/cibuilder.py=20 @@ -64,7 +64,7 @@ class CIBuilder(Test):=20 self.check_init()=20 # get parameters from avocado cmdline=20 - quiet =3D bool(int(self.params.get('quiet', default=3D0)))=20 + quiet =3D bool(int(self.params.get('quiet', default=3D1)))=20 if dl_dir is None:=20 dl_dir =3D os.path.join(isar_root, 'downloads')=20 --=20 2.34.1=20 ------=_Part_137_658407701.1677566413544 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Thursday, February 23, 2023 at 4:41:4= 4=E2=80=AFPM UTC+1 Anton Mikanovich wrote:
It looks like nobody run bitbake with additional verbose dur= ing
normal testsuite operation, so set non verbose output ("quite") to
be default one. Verbose output still can be enabled by adding
"-p quite=3D0" directly to avocado command.

typo: quite =3D> quiet
=C2=A0


Signed-off-by: Anton Mikanovich <ami= ...@ilbers.de>
---
.gitlab-ci.yml | 6 +++---
scripts/ci_build.sh | 7 ++-----
testsuite/README.md | 4 ++--
testsuite/cibuilder.py | 2 +-
4 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index f9235fc..eb38be5 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -27,14 +27,14 @@ dev-ci:
except:
- schedules
script:
- - scripts/ci_build.sh -q -T dev
+ - scripts/ci_build.sh -T dev
=20
fast-ci:
<<: *common-build
only:
- schedules
script:
- - scripts/ci_build.sh -q -T fast
+ - scripts/ci_build.sh -T fast
=20
full-ci:
<<: *common-build
@@ -44,7 +44,7 @@ full-ci:
- PREVIOUS_SHA=3D"$(cat .CI_COMMIT_SHA || true)"
- if [ "$CI_COMMIT_SHA" !=3D "$PREVIOUS_SHA" ]; then
echo "$CI_COMMIT_SHA" > .CI_COMMIT_SHA;
- scripts/ci_build.sh -q -T full;
+ scripts/ci_build.sh -T full;
fi
cache:
key: "$CI_COMMIT_REF_SLUG"
diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
index 9f62db5..fcac180 100755
--- a/scripts/ci_build.sh
+++ b/scripts/ci_build.sh
@@ -50,7 +50,6 @@ show_help() {
echo " the tests will be started in = current path."
echo " -d, --debug enable debug bitbake output."
echo " -T, --tags specify basic avocado tags."
- echo " -q, --quiet suppress verbose bitbake outp= ut."
echo " -n, --norun do not execute QEMU run tests= ."
echo " --help display this message and exit= ."
echo
@@ -59,8 +58,6 @@ show_help() {
echo " 3 if invalid parameters are passed."
}
=20
-QUIET=3D"0"
-
# Parse command line to get user configuration
while [ $# -gt 0 ]
do
@@ -88,7 +85,7 @@ do
echo "warning: deprecated parameter '$key', consider using '= -T fast' instead"
;;
-q|--quiet)
- QUIET=3D"1"
+ echo "warning: deprecated parameter '$key', it is applied by= default"
;;
-n|--norun)
NORUN=3D"1"
@@ -151,4 +148,4 @@ set -x
=20
avocado ${VERBOSE} run "${TESTSUITE_DIR}/citest.py" \
-t "${TAGS}" ${PARALLEL} --disable-sysinfo \
- -p quiet=3D"${QUIET}" ${TIMEOUT}
+ ${TIMEOUT}
diff --git a/testsuite/README.md b/testsuite/README.md
index 10fbd79..c9d5862 100644
--- a/testsuite/README.md
+++ b/testsuite/README.md
@@ -27,13 +27,13 @@ $ avocado run ../testsuite/citest.py -t single --= max-parallel-tasks=3D1 -p machine
## Fast build test
=20
```
-$ avocado run ../testsuite/citest.py -t fast --max-parallel-tasks=3D= 1 -p quiet=3D1
+$ avocado run ../testsuite/citest.py -t fast --max-parallel-tasks=3D= 1
```
=20
## Full build test
=20
```
-$ avocado run ../testsuite/citest.py -t full --max-parallel-tasks=3D= 1 -p quiet=3D1
+$ avocado run ../testsuite/citest.py -t full --max-parallel-tasks=3D= 1
```
=20
## Fast boot test
diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py
index 65eeb4b..0a07bf0 100755
--- a/testsuite/cibuilder.py
+++ b/testsuite/cibuilder.py
@@ -64,7 +64,7 @@ class CIBuilder(Test):
self.check_init()
=20
# get parameters from avocado cmdline
- quiet =3D bool(int(self.params.get('quiet', default=3D0)))
+ quiet =3D bool(int(self.params.get('quiet', default=3D1)))
=20
if dl_dir is None:
dl_dir =3D os.path.join(isar_root, 'downloads')
--=20
2.34.1

------=_Part_137_658407701.1677566413544-- ------=_Part_136_1230823385.1677566413544--