Re: [PATCH] expand-on-first-boot: Switch from resize2fs to systemd-growfs

[Jan Kiszka <jan.kiszka@siemens.com>]

On 25.05.22 15:04, Schmidl, Tobias (T CED SES-DE) wrote:
> Hi all,
> 
> Am Mittwoch, dem 25.05.2022 um 14:47 +0200 schrieb Jan Kiszka:
>>
>> Just for the sake of completeness: Since which Debian version is this
>> the case? I assume buster is fine, right? But stretch was not.
>>
>>
> 
> That's correct, it was introduced with v236 [1], so halfway between
> stretch (v232) and buster (v241).
> 
> 
> [1]:
> https://github.com/systemd/systemd/blob/ec5e113f099a3078194ae5fe43f72f52f41fe76b/NEWS#L6515-L6524
> 
>>>
>>> +if [ -x /lib/systemd/systemd-growfs ]; then
>>> +       MOUNT_POINT=$(findmnt "${LAST_PART}" -o target -n)
>>> +       if [ -z "$MOUNT_POINT" ]; then
>>> +               echo "Cannot find mount point for ${LAST_PART}"
>>> +               exit 1
>>> +       fi
>>> +       mount "${MOUNT_POINT}" || true
>>> +       /lib/systemd/systemd-growfs "${MOUNT_POINT}"
>>> +else
>>> +       resize2fs "${LAST_PART}"
>>> +fi
>>
>> I wonder if / how long we should keep the two paths...
>>
> 
> That's a strategic decision - do we want to keep the possibility of non-
> systemd systems open? Otherwise this script should IMHO add a runtime
> dependency to systemd (>=236).
> 

Well, we already depend on systemd today and provide only systemd unit
files here. In that light, adding a version dependency to systemd would
be fine IMHO.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux