From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.98.35.202 with SMTP id q71mr3138977pfj.57.1502218748918; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.143.132 with SMTP id r126ls9694417iod.10.gmail; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-Received: by 10.107.141.1 with SMTP id p1mr3125204iod.34.1502218748696; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) Received: by 10.55.11.141 with SMTP id 135msqkl; Tue, 8 Aug 2017 05:29:44 -0700 (PDT) X-Received: by 10.223.136.144 with SMTP id f16mr369764wrf.32.1502195383773; Tue, 08 Aug 2017 05:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502195383; cv=none; d=google.com; s=arc-20160816; b=tBR3bLM1Zd2shVINtyzh+At81gz2OaaMupfn3lgxiUKwkZesc4XCg5C+ZNeWaqfPo6 U9anvBSgSsjLT0/2bfpixAX72j155LT6QqZhVxi44SzhZem+1Z8/2MaTIzKDoG2m6BZn VqL+f8botEvh9ugX51DnubmL8VSMwPNsTbS2qRe0s9F95z0Ps/Tz8KU9/0D5D/kVQkYv 9BnJ4qIJqyaWouw3FuyrYTE1QdvZwOgbIYkvADe9htc+TCCu9T62aL+Gh+xjgmmMuepH /DKmY5gBttdHhazNUve/enFaixETVEqfmazvzMVeJMnteDxeAon5ZXhZlj0ZVXFLUMjV D6Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=4WeSleOwccfGXn/t3mwSv0QiyL/U0UcpWnfUSfEGMfA=; b=vpGRfVFuPT6a8WhXFBmWrE0MQ2VtIFg8YfvipDbtWd2iNX7R3b/21z+jbh8gHsEmg0 BEaKLPra5SQrGt+QocJLeo+3fCOr/a9yMCXycXO+P0ErMrpY3BdqNQemR44dz63N+Tg9 PB0h8SjCnzPGEIb0cZGX2UwRZzKl2zESySAF2cdlf1ImaBxX5vbQe7A6NR5p2VTdmckX KKKryIvI+EGvOsn5YC9J5QVb1rS1H8Waq06BLgeta98Oae+RHCStbkgn9dRQ4or5hAJ4 ZUaLa2xNaTaZpUDUelTPjvpcL2XCuE0j4FhLH4eJYOzeYGIA/zu9B2Hwz8KuhLTtvWLz qZQw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id 81si462805wmh.1.2017.08.08.05.29.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 05:29:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v78CTero022634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 8 Aug 2017 14:29:42 +0200 Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function To: Henning Schild Cc: isar-users@googlegroups.com References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> <20170808140809.1636322c@md1em3qc> From: Alexander Smirnov Message-ID: <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> Date: Tue, 8 Aug 2017 15:29:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170808140809.1636322c@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: iLXWXhSsa/PS Hi, On 08/08/2017 03:08 PM, Henning Schild wrote: > Am Tue, 8 Aug 2017 12:33:58 +0300 > schrieb Alexander Smirnov : > >> 2017-08-08 11:05 GMT+03:00 Henning Schild >> : >> >>> Am Mon, 7 Aug 2017 22:36:18 +0300 >>> schrieb Alexander Smirnov : >>> >>>> I'm not sure that this function is unused. It's usually used for >>>> debug purposes to route traces to console. >>> >>> It is unused in Isar and not part of the default base class of >>> bitbake. >>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html >>>> chapter: 2.3.8.2 >>> >>> OE implements it in meta/classes/logging.bbclass >>> >>> >> That's a good hint! So probably we can move this function to similar >> class instead of removing it. > > I would still remove it since it is not used. When people need it they > can introduce it again. For logging we have bbnote bbwarn and bbfatal > from base.bbclass already. > > Our bitbake does not seem to know "debug_level" so it is outdated and > unused. I'll send patch which introduces logging class and move all the 'bbXXX' helpers to it (also fix bbdebug). I really don't like the idea to drop debug capabilities only because they are not used at the moment. If this interface is going to be dropped, then we need to introduce new interface before. Alex > >> >>>> I think it makes sense to keep it to debug complicated classes and >>>> recipes in future. >>> >>> Ok. >>> >>> Henning >>> >>>> 2017-08-03 14:55 GMT+03:00 Henning Schild >>>> : >>>> >>>>> Signed-off-by: Henning Schild >>>>> --- >>>>> meta/classes/isar-base.bbclass | 12 ------------ >>>>> 1 file changed, 12 deletions(-) >>>>> >>>>> diff --git a/meta/classes/isar-base.bbclass >>>>> b/meta/classes/isar-base. bbclass >>>>> index 67d38a1..efd4223 100644 >>>>> --- a/meta/classes/isar-base.bbclass >>>>> +++ b/meta/classes/isar-base.bbclass >>>>> @@ -21,16 +21,4 @@ >>>>> >>>>> THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" >>>>> >>>>> -bbdebug() { >>>>> - test $# -ge 2 || { >>>>> - echo "Usage: bbdebug level \"message\"" >>>>> - exit 1 >>>>> - } >>>>> - >>>>> - test ${@bb.msg.debug_level['default']} -ge $1 && { >>>>> - shift >>>>> - echo "DEBUG:" $* >>>>> - } >>>>> -} >>>>> - >>>>> do_build[nostamp] = "0" >>>>> -- >>>>> 2.13.0 >>>>> >>>>> >>> >>> > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov