From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7325014627589292032 X-Received: by 2002:a1c:4c07:0:b0:40e:a555:803d with SMTP id z7-20020a1c4c07000000b0040ea555803dmr311539wmf.74.1706001206817; Tue, 23 Jan 2024 01:13:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:e58b:0:b0:337:bba8:3d9c with SMTP id l11-20020adfe58b000000b00337bba83d9cls559170wrm.0.-pod-prod-06-eu; Tue, 23 Jan 2024 01:13:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDNXF6B/V5uHCEMmdUKy41FCAI3J8Z30JLvsUgJXQ6GrRoPjaih3Cxn5NzH9vfm5xmWCKf X-Received: by 2002:a05:600c:45c9:b0:40e:3772:cb56 with SMTP id s9-20020a05600c45c900b0040e3772cb56mr328541wmo.8.1706001204678; Tue, 23 Jan 2024 01:13:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706001204; cv=none; d=google.com; s=arc-20160816; b=dBEaU9mq++C+NkFa37R67MDQTuxcRaXBKugLpZ89m2PXZBi7+OCCCaUhf3Hl4yE/oQ KMuNk3vkNtXPVT/5RsTRx1wR1BqvuAwOuDogx2BFzCp7u8GevGDeOs1R3BP/OkHvjHMs BRt6d2oRXm+GkBWahyiPihkyKfMzmhl0VftCvNNY3+ogFhGcpTTDT8l7q8yWtKD5JgjB eWfUnA7LX2jbz59p3o3qeyrWAjkhFQAhr2hd/1l9NG6lobZ+HfiFT0JyY6s/1LEVcwJx ZaA9mGsB4Ek4Pueb4NB3Q0c9vKPReTU7VM1cbMc/1Z4PCMSj2AD7z7C6QsU2QCHL3EPy umdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=51Xt004OVaT5uSiJ+AUdcJVMd21mZZow8CjoaMP37+k=; fh=ez+yYIN2+t1/A1KtVD1essDQ6+anTTnZTbSXjuK9WaU=; b=PFF4kE6RzbO/YVIKiVuqGAFKGHaML9p7azmnXFqzfUCF9Ppu4hDmVeGQ4TmU97iB6C +hTkaa8X6qkkulSqljUSeAqPQeAxzbOA9jlN4bv2N2ohfYoM+EMBNkvQN/Cu81CqHUln 6xOqSeOVENLrc3Dam0bmI7wD0smxtYLXFvu9L3NFB0q27EnBTg2SIcT/MZPgrbSJiFEI MdNSFbTyPrl9BkOOthlkBy3wsuyjQWue1/Ed20ZgRR8Mdfsr68zW9y6Oqf2AZKFRu6v+ ZpDpHD3KoZ/CTnghlQcd6sL+xfNtp8A+eHapWqcBnhs7toOVWNZoj21FglMNk8HES2Zl c58Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id v18-20020a05600c215200b0040eb9413165si29831wml.2.2024.01.23.01.13.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2024 01:13:24 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 40N9DLNj000879 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Jan 2024 10:13:23 +0100 Message-ID: <55a2741c7757e868af6491c207072ce7e436ed93.camel@ilbers.de> Subject: Re: [PATCH 1/1] fix dependencies of devshell tasks From: Uladzimir Bely To: Felix Moessbauer , isar-users@googlegroups.com Date: Tue, 23 Jan 2024 12:13:24 +0300 In-Reply-To: <20240117103730.241499-1-felix.moessbauer@siemens.com> References: <20240117103730.241499-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: P7kelCw4EcdW On Wed, 2024-01-17 at 11:37 +0100, 'Felix Moessbauer' via isar-users wrote: > In 21a0560 the local_isarapt task was introduced, which needs to run > before the devshell. By that, the dependencies of the devshell tasks > got updated as well. However, the do_prepare_build also needs to run > before the devshell, as otherwise the preparation logic is not > executed. >=20 > This commit re-introduces (adds) this dependency again. >=20 > Signed-off-by: Felix Moessbauer > --- > =C2=A0meta/classes/dpkg-base.bbclass | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg- > base.bbclass > index 7b054d3f..95ca3db8 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -323,7 +323,7 @@ python do_devshell() { > =C2=A0=C2=A0=C2=A0=C2=A0 bb.build.exec_func('schroot_delete_configs', d) > =C2=A0} > =C2=A0 > -addtask devshell after do_local_isarapt > +addtask devshell after do_local_isarapt do_prepare_build > =C2=A0DEVSHELL_STARTDIR ?=3D "${S}" > =C2=A0do_devshell[dirs] =3D "${DEVSHELL_STARTDIR}" > =C2=A0do_devshell[nostamp] =3D "1" > @@ -335,7 +335,7 @@ python do_devshell_nodeps() { > =C2=A0 > =C2=A0# devshell may be placed after do_instell_builddeps in downstream > classes. > =C2=A0# devshell_nodeps will always stay right after do_prepare_build. > -addtask devshell_nodeps after do_local_isarapt > +addtask devshell_nodeps after do_local_isarapt do_prepare_build > =C2=A0do_devshell_nodeps[dirs] =3D "${DEVSHELL_STARTDIR}" > =C2=A0do_devshell_nodeps[nostamp] =3D "1" > =C2=A0do_devshell_nodeps[network] =3D "${TASK_USE_SUDO}" > --=20 > 2.39.2 >=20 Applied to next, thanks.