Re: [PATCH] dpkg-raw: empty "Depends:" line is not allowed in .deb

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 12/13/2017 02:35 PM, [ext] Christian Storm wrote:
>> Apt-gat fails to install packages if the control-file contains a
>> "Depends:"-line without any packages listed.
>>
>>    E: Problem parsing dependency Depends
>>
>> So append that line to the control-file only if DEBIAN_DEPENDS was set
>> in the recipe. The user could still specify i.e. " " or anything
>> invalid, we do not check that. But now our default works.
>>
>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>> Reported-by: Claudius Heine <ch@denx.de>
>> ---
>>   meta/classes/dpkg-raw.bbclass | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass
>> index af62be4..1435e10 100644
>> --- a/meta/classes/dpkg-raw.bbclass
>> +++ b/meta/classes/dpkg-raw.bbclass
>> @@ -26,10 +26,15 @@ do_deb_package_prepare() {
>>   		Section: misc
>>   		Priority: optional
>>   		Maintainer: ${MAINTAINER}
>> -		Depends: `echo ${DEBIAN_DEPENDS} | tr '[:blank:]' ','`
> 
> Just as a side note: This doesn't work for versioned dependencies
> that should result in a line like, e.g.,
>    Depends: libc6 (>= 2.14)
> in DEBIAN/control.

Also stuff like that is not possible:

     Depends: tar | bsdtar, systemd

Maybe allow something like this:

     DEBIAN_DEPENDS = "'libc6 (>= 2.14)' 'tar | bsdtar' systemd"

But that would be a additional patch.

Cheers,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de